From: Bjorn Helgaas <helgaas@kernel.org>
To: Hongxing Zhu <hongxing.zhu@nxp.com>
Cc: Frank Li <frank.li@nxp.com>,
"l.stach@pengutronix.de" <l.stach@pengutronix.de>,
"lpieralisi@kernel.org" <lpieralisi@kernel.org>,
"kwilczynski@kernel.org" <kwilczynski@kernel.org>,
"mani@kernel.org" <mani@kernel.org>,
"robh@kernel.org" <robh@kernel.org>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"imx@lists.linux.dev" <imx@lists.linux.dev>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 08/11] PCI: dwc: Invoke post_init in dw_pcie_resume_noirq()
Date: Tue, 20 Jan 2026 16:04:41 -0600 [thread overview]
Message-ID: <20260120220441.GA1170239@bhelgaas> (raw)
In-Reply-To: <20260109152750.GA544801@bhelgaas>
On Fri, Jan 09, 2026 at 09:27:50AM -0600, Bjorn Helgaas wrote:
> ...
> The current commit log for this patch is this:
>
> Some SoCs like i.MX95 require enabling REFCLK after resuming from suspend
> in their post_init callback. So invoke the callback at the end of
> dw_pcie_resume_noirq() if available.
>
> When .post_init() is called, the link is already up and PCIe devices
> have already been enumerated. I think REFCLK is required for the link
> to come up, so it doesn't sound right to me that .post_init() would be
> *enabling* REFCLK.
This never got resolved.
https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/commit/?h=controller/dwc-imx6&id=199c18221622
says imx_pcie_host_post_init() enables REFCLK by applying the
IMX_PCIE_FLAG_8GT_ECN_ERR051586 workaround.
I don't think that commit log is correct. Can you please supply some
correct text for that commit?
Bjorn
next prev parent reply other threads:[~2026-01-20 22:04 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-15 3:04 [PATCH v6 0/11] PCI: imx6: Add a method to handle CLKREQ# override Richard Zhu
2025-10-15 3:04 ` [PATCH v6 01/11] arm64: dts: imx95-15x15-evk: Add supports-clkreq property to PCIe M.2 port Richard Zhu
2025-10-31 19:37 ` Frank Li
2025-11-11 7:11 ` Shawn Guo
2025-11-11 8:02 ` Hongxing Zhu
2025-11-11 16:10 ` Frank Li
2025-11-12 1:50 ` Shawn Guo
2025-11-12 17:27 ` Frank Li
2025-10-15 3:04 ` [PATCH v6 02/11] arm64: dts: imx95-19x19-evk: " Richard Zhu
2025-10-31 19:37 ` Frank Li
2025-10-15 3:04 ` [PATCH v6 03/11] arm64: dts: imx8mm-evk: " Richard Zhu
2025-10-31 19:37 ` Frank Li
2025-10-15 3:04 ` [PATCH v6 04/11] arm64: dts: imx8mp-evk: " Richard Zhu
2025-10-31 19:38 ` Frank Li
2025-10-15 3:04 ` [PATCH v6 05/11] arm64: dts: imx8mq-evk: " Richard Zhu
2025-10-31 19:38 ` Frank Li
2025-10-15 3:04 ` [PATCH v6 06/11] arm64: dts: imx8qm-mek: " Richard Zhu
2025-10-31 19:39 ` Frank Li
2025-10-15 3:04 ` [PATCH v6 07/11] arm64: dts: imx8qxp-mek: " Richard Zhu
2025-10-31 19:40 ` Frank Li
2025-10-15 3:04 ` [PATCH v6 08/11] PCI: dwc: Invoke post_init in dw_pcie_resume_noirq() Richard Zhu
2026-01-08 21:50 ` Bjorn Helgaas
2026-01-09 2:10 ` Hongxing Zhu
2026-01-09 15:27 ` Bjorn Helgaas
2026-01-20 22:04 ` Bjorn Helgaas [this message]
2026-01-21 2:24 ` Hongxing Zhu
2026-01-21 7:42 ` mani
2025-10-15 3:04 ` [PATCH v6 09/11] PCI: imx6: Add a new imx8mm_pcie_clkreq_override() for i.MX8M PCIes Richard Zhu
2025-10-31 19:40 ` Frank Li
2025-10-15 3:04 ` [PATCH v6 10/11] PCI: imx6: Add CLKREQ# override to enable REFCLK for i.MX95 PCIe Richard Zhu
2025-10-30 10:54 ` Alexander Stein
2025-10-31 19:48 ` Frank Li
2025-10-15 3:04 ` [PATCH v6 11/11] PCI: imx6: Add a callback to clear CLKREQ# override Richard Zhu
2025-10-31 19:46 ` Frank Li
2025-11-12 1:52 ` [PATCH v6 0/11] PCI: imx6: Add a method to handle " Shawn Guo
2026-01-06 12:54 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260120220441.GA1170239@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=frank.li@nxp.com \
--cc=hongxing.zhu@nxp.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox