From: Florian Fainelli <florian.fainelli@broadcom.com>
To: linux-kernel@vger.kernel.org
Cc: Doug Berger <opendmb@gmail.com>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Linus Walleij <linusw@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Christophe Leroy <chleroy@kernel.org>,
linux-gpio@vger.kernel.org (open list:GPIO SUBSYSTEM),
linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM
BCM7XXX ARM ARCHITECTURE)
Subject: [PATCH 1/3] gpio: brcmstb: correct hwirq to bank map
Date: Wed, 21 Jan 2026 17:05:14 -0800 [thread overview]
Message-ID: <20260122010516.1200630-2-florian.fainelli@broadcom.com> (raw)
In-Reply-To: <20260122010516.1200630-1-florian.fainelli@broadcom.com>
From: Doug Berger <opendmb@gmail.com>
The brcmstb_gpio_hwirq_to_bank() function was designed to
accommodate the downward numbering of dynamic GPIOs by
traversing the bank list in the reverse order. However, the
dynamic numbering has changed to increment upward which can
produce an incorrect mapping.
The function is modified to no longer assume an ordering of
the list to accommodate either option.
Fixes: 7b61212f2a07 ("gpiolib: Get rid of ARCH_NR_GPIOS")
Signed-off-by: Doug Berger <opendmb@gmail.com>
Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
---
drivers/gpio/gpio-brcmstb.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/gpio/gpio-brcmstb.c b/drivers/gpio/gpio-brcmstb.c
index af9287ff5dc4..2352d099709c 100644
--- a/drivers/gpio/gpio-brcmstb.c
+++ b/drivers/gpio/gpio-brcmstb.c
@@ -301,12 +301,10 @@ static struct brcmstb_gpio_bank *brcmstb_gpio_hwirq_to_bank(
struct brcmstb_gpio_priv *priv, irq_hw_number_t hwirq)
{
struct brcmstb_gpio_bank *bank;
- int i = 0;
- /* banks are in descending order */
- list_for_each_entry_reverse(bank, &priv->bank_list, node) {
- i += bank->chip.gc.ngpio;
- if (hwirq < i)
+ list_for_each_entry(bank, &priv->bank_list, node) {
+ if (hwirq >= bank->chip.gc.offset &&
+ hwirq < (bank->chip.gc.offset + bank->chip.gc.ngpio))
return bank;
}
return NULL;
--
2.43.0
next prev parent reply other threads:[~2026-01-22 1:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-22 1:05 [PATCH 0/3] gpio: brcmstb: Bug fixes and wake-up interrupt improvements Florian Fainelli
2026-01-22 1:05 ` Florian Fainelli [this message]
2026-01-22 1:05 ` [PATCH 2/3] gpio: brcmstb: implement irq_mask_ack Florian Fainelli
2026-01-22 7:36 ` Andy Shevchenko
2026-01-22 19:17 ` Florian Fainelli
2026-01-22 19:26 ` Florian Fainelli
2026-01-23 19:01 ` Florian Fainelli
2026-01-22 1:05 ` [PATCH 3/3] gpio: brcmstb: allow parent_irq to wake Florian Fainelli
2026-01-22 7:42 ` Andy Shevchenko
2026-01-22 19:24 ` Florian Fainelli
2026-01-26 16:26 ` Andy Shevchenko
2026-01-22 7:44 ` Andy Shevchenko
2026-01-22 7:45 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260122010516.1200630-2-florian.fainelli@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=andy.shevchenko@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=brgl@kernel.org \
--cc=chleroy@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=opendmb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox