From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0C069D3EE95 for ; Thu, 22 Jan 2026 16:54:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:To:From:Subject :Message-ID:Mime-Version:Date:Reply-To:Cc:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=ptohnX8yCM46UmZak3D8AP5tKkb3cPUe+4O8l8XtsLs=; b=nBjAiXbZ6oHmbblEscO2LEv+bQ xhq+XL2+mDF7kJAvPXeFyRIDsS6EwmIyNcPON/AZKmYjrv+a6GPBhfYT7E2g0XIzCV57O+cJBEw6h 0mBEyCnDEpjiqIs7dapi4CBhdbJ2RC9CVFWDVj5C0CEjr4tC0+jC5ys/3Z6zWBHxzaHhJo9yjNHOM EWXATVjV8dQhQEadru5h1OsFfgG3/4K5g/DWrf4xr7sChh3q7A7OxLWbU6L86INhsQnFhGIR70aqa p/r1EyuKUgCH9cuEVNf5lwVMhCQvVVHlH1x5YfSYJVPHZmHga5seAmvWu5PS4Rvp/TlMdnIBpA2zO yZEsn3kg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vixwq-00000007TeJ-0GU9; Thu, 22 Jan 2026 16:54:20 +0000 Received: from mail-dy1-x1349.google.com ([2607:f8b0:4864:20::1349]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vixwm-00000007Tcn-3BdA for linux-arm-kernel@lists.infradead.org; Thu, 22 Jan 2026 16:54:18 +0000 Received: by mail-dy1-x1349.google.com with SMTP id 5a478bee46e88-2b722bc1be1so932873eec.0 for ; Thu, 22 Jan 2026 08:54:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1769100855; x=1769705655; darn=lists.infradead.org; h=to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=ptohnX8yCM46UmZak3D8AP5tKkb3cPUe+4O8l8XtsLs=; b=BZ2lODS4egrfxseiK3peKcTq/JO9SLa6ODpLu1EL/xIw1zWzH+zmCMXzBSVC6sxE9d hO0EM9wlfxXj4IVIrtaFDwv3jFRv0hUxKuXJi3GKU7SnbyGQ1T8b5TewAunF+d1Fb4bR fp4YZiNvw4gBjDnufcozJijsgU7bXDJoRpLgXCE1zjyndm4iRJgT3adaiULAe306s8LP KibXNsKL4mwMUSjLb1fA8JBiUWLlOvFsiM4m2ATO2wSZJwUotFEa6TO3N5S0jEtWIPAo BKBw0EsOEU01tsVWDYgfxBUarvEWIvttoH/lcqVhfocQyZBoq0i24iZUUczTLVXuPOoK f4Gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769100855; x=1769705655; h=to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ptohnX8yCM46UmZak3D8AP5tKkb3cPUe+4O8l8XtsLs=; b=aQBtuSFLvzXqhFRZDKmab3o9zqE+aYzPQEAlFbA3wwwx2zEliWgQ5UPedPj7HmKVcr Y2ixqhwUiA5+19Hx+41X7sgYfcXUgjhlqTeEOnzRPIVk15JBvFcHjJB4xjnTmTq9YUcC PDGwUcrKJopompDG8D5nZOb690fcbJMnf3daqMHtQDVww9IEXuoXx94Z9PGMrjzM+01Y ahB/Qvi8ekxStODTCeCFpn6Ndkb6RWg0O9DNsHxW9g34wj0crE2ktpOeSZaamslXur3q XrxtLPAuLRkrzYgioNS8e3mHDZwtYdfEhXu40a3g5m0yGKsJTfP6vbyM2Hu00TGG/9xc Zujg== X-Forwarded-Encrypted: i=1; AJvYcCVM+2A97pfoxNbFQobFEwJTIn2ejVr5gwByoDboRPo57SkYNKJzscCGYQiReTp4WGRq9HYKIQxev8j989QxZRHb@lists.infradead.org X-Gm-Message-State: AOJu0YxH3NWuDNc1Gv7W1L7bLSmln4qVODwasKqFcxOSoWoMlI4gwX8n MFvoeUuDyiEN+7nJuR2TentLbvZXKMgGgSoCnLWXp2JjwXHPsTD56hM5HPpJZSAUDEwOgi7vqAQ ozm8BCjPlWg== X-Received: from dybgn17.prod.google.com ([2002:a05:7301:2511:b0:2b7:3bb:5997]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7301:650c:b0:2ae:51ae:5cfd with SMTP id 5a478bee46e88-2b6b4104264mr16128244eec.22.1769100854683; Thu, 22 Jan 2026 08:54:14 -0800 (PST) Date: Thu, 22 Jan 2026 08:53:55 -0800 Mime-Version: 1.0 X-Mailer: git-send-email 2.52.0.457.g6b5491de43-goog Message-ID: <20260122165407.561888-1-irogers@google.com> Subject: [PATCH v2 00/12] perf annotate arch clean up From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , John Garry , Will Deacon , Leo Yan , Guo Ren , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Zecheng Li , Tianyou Li , Thomas Falcon , Julia Lawall , Suchit Karunakaran , Athira Rajeev , Aditya Bodkhe , Howard Chu , "=?UTF-8?q?Krzysztof=20=C5=81opatowski?=" , "Dr. David Alan Gilbert" , Shimin Guo , Sergei Trofimovich , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org Content-Type: text/plain; charset="UTF-8" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260122_085416_810067_92A3954D X-CRM114-Status: GOOD ( 20.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org 3 initial memory leak fix patches for perf annotate. Move the disasm.c #included arch files into a new util/annotate-arch directory. Make the code compile standalone. Try to better encapsulate architecture specific code within the files and with a arch__new_ function that allows additional data to be associated with the struct arch using the standard container_of trick. Make the lookup of struct arch use the ELF machine gather from a thread rather than an evsel. For example, the evsel can't determine the difference between EM_386 and EM_X86_64 so generally the latter has currently been used. This means the dwarf registers are off as register 1 is CX with EM_386 and DX with EM_X86_64. To facilitate this change map_symbol is refactored to use a struct thread rather than a struct maps, the maps being obtainable from the thread. To make in and out arguments clearer, for safety, etc. try to constify struct arch and its related structs. v2: Add a patch to fix a domain info memory leak that was blocking leak sanitizer analysis. Fix more map_symbol leaks or uses after reference count put (Suchit Karunakaran ). Try to repro annotate test crash (James Clark) but suspect it was addressed in the other reference count fixes. v1: https://lore.kernel.org/lkml/20260122073127.375139-1-irogers@google.com/ Ian Rogers (12): perf header: Fix memory leaks in process_cpu_domain_info perf annotate: Fix args leak of map_symbol perf maps: Fix reference count leak in maps__find_ams perf disasm: Constify use of struct arch perf disasm: Constify use of struct ins_op perf disasm: Constify use of struct ins perf disasm: Rework the string arch__is to use the ELF machine perf disasm: Don't include C files from the arch directory perf disasm: Refactor ins__is_call/jump to avoid exposing arch ins_ops perf map_symbol: Switch from holding maps to holding thread perf disasm: Refactor arch__find and initialization of arch structs perf disasm: Minor layout tweaks for struct arch tools/perf/arch/arc/annotate/instructions.c | 11 - .../perf/arch/riscv64/annotate/instructions.c | 36 -- tools/perf/ui/browsers/annotate.c | 6 +- tools/perf/ui/browsers/hists.c | 3 +- tools/perf/util/Build | 1 + tools/perf/util/addr_location.c | 4 - tools/perf/util/addr_location.h | 1 - tools/perf/util/annotate-arch/Build | 11 + tools/perf/util/annotate-arch/annotate-arc.c | 18 + .../annotate-arch/annotate-arm.c} | 48 +- .../annotate-arch/annotate-arm64.c} | 59 +-- .../annotate-arch/annotate-csky.c} | 29 +- .../annotate-arch/annotate-loongarch.c} | 71 +-- .../annotate-arch/annotate-mips.c} | 29 +- .../annotate-arch/annotate-powerpc.c} | 125 ++++- .../util/annotate-arch/annotate-riscv64.c | 41 ++ .../annotate-arch/annotate-s390.c} | 70 +-- .../annotate-arch/annotate-sparc.c} | 26 +- .../annotate-arch/annotate-x86.c} | 89 ++-- tools/perf/util/annotate-data.c | 12 +- tools/perf/util/annotate-data.h | 2 +- tools/perf/util/annotate.c | 88 ++-- tools/perf/util/annotate.h | 10 +- tools/perf/util/callchain.c | 12 +- tools/perf/util/capstone.c | 18 +- tools/perf/util/db-export.c | 1 - tools/perf/util/disasm.c | 428 +++++++----------- tools/perf/util/disasm.h | 95 ++-- tools/perf/util/event.c | 2 - tools/perf/util/header.c | 17 +- tools/perf/util/hist.c | 18 +- tools/perf/util/llvm.c | 8 +- tools/perf/util/machine.c | 13 +- tools/perf/util/map_symbol.c | 5 +- tools/perf/util/map_symbol.h | 3 +- tools/perf/util/maps.c | 1 + tools/perf/util/sort.c | 2 +- tools/perf/util/unwind-libdw.c | 2 +- tools/perf/util/unwind-libunwind-local.c | 2 +- 39 files changed, 774 insertions(+), 643 deletions(-) delete mode 100644 tools/perf/arch/arc/annotate/instructions.c delete mode 100644 tools/perf/arch/riscv64/annotate/instructions.c create mode 100644 tools/perf/util/annotate-arch/Build create mode 100644 tools/perf/util/annotate-arch/annotate-arc.c rename tools/perf/{arch/arm/annotate/instructions.c => util/annotate-arch/annotate-arm.c} (59%) rename tools/perf/{arch/arm64/annotate/instructions.c => util/annotate-arch/annotate-arm64.c} (70%) rename tools/perf/{arch/csky/annotate/instructions.c => util/annotate-arch/annotate-csky.c} (67%) rename tools/perf/{arch/loongarch/annotate/instructions.c => util/annotate-arch/annotate-loongarch.c} (60%) rename tools/perf/{arch/mips/annotate/instructions.c => util/annotate-arch/annotate-mips.c} (59%) rename tools/perf/{arch/powerpc/annotate/instructions.c => util/annotate-arch/annotate-powerpc.c} (73%) create mode 100644 tools/perf/util/annotate-arch/annotate-riscv64.c rename tools/perf/{arch/s390/annotate/instructions.c => util/annotate-arch/annotate-s390.c} (66%) rename tools/perf/{arch/sparc/annotate/instructions.c => util/annotate-arch/annotate-sparc.c} (85%) rename tools/perf/{arch/x86/annotate/instructions.c => util/annotate-arch/annotate-x86.c} (93%) -- 2.52.0.457.g6b5491de43-goog