From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BAF21D6CFA4 for ; Thu, 22 Jan 2026 21:35:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:To:From:Subject :Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DnbHjkP7sr2MY8dvLIuI6wPgadGKGFiX6WTYohRo5Kw=; b=DrUPRjZlPcODLK/UrIBMnVcZOb a+UjgLv2hTuG6zQtIEvPyabjvcDnZptjj+M7oLpKVVcDB/7lgZXw3CjlsRkAoJj8qFiOioaPQXhVb vS/+vFZEZspOaDjvGdAx7+0+oPlX/eaX3KjIOCNuykxUAImmaEA/tFVlu+LxYDpkNq3dh3ibMXius nH772iV6pBczrW6Tc3550Y76DhRubU1Ht4B2z6rmrMw8gvV0nqDTUwJ5/F+ccSlgHLss4kF3NqzIr di6YC9rK9gpXLL0bwyPIu3FIGlbM+MDd7NM91+cVH2VUcWn33KcaocmzKv8HHWC7ihAknKYy419P4 cu5khhIQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vj2L6-00000007mOq-47OY; Thu, 22 Jan 2026 21:35:41 +0000 Received: from mail-dy1-x134a.google.com ([2607:f8b0:4864:20::134a]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vj2Kw-00000007mIG-0oO2 for linux-arm-kernel@lists.infradead.org; Thu, 22 Jan 2026 21:35:31 +0000 Received: by mail-dy1-x134a.google.com with SMTP id 5a478bee46e88-2b70c92f404so2062585eec.0 for ; Thu, 22 Jan 2026 13:35:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1769117729; x=1769722529; darn=lists.infradead.org; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=DnbHjkP7sr2MY8dvLIuI6wPgadGKGFiX6WTYohRo5Kw=; b=zhLTrDPBW0Nu+S9nGlP0IuRQVwaAvz6c3DyprSns/6FovEt/ZG9AQXMAtaZ/LdCovV gSlDb3ywBhaSyLPaJ3OQ6SFCx/buAwN4YSklfBJ79aiq/KSDcfwveG+3J3bePvcZTA9m 5m05oHlafpuoZtz0hAv3Vpe1iqlbIPSaIdgBjVSpb0fU6v2ZfQiGlYKEn+rQgR9Vw2Na s60qdBOdpX5dI4Y3B/VNCbelU2dLpfOB3xNrWWHiactegBcbXo6kK9VO3hffv2abMtJ0 AFdNe9nafHIuYwO2FWgmxPQ7c/L1iPS3BgNyKuS3MlOhInYPj2pae7uV7RfuQQdCqmRE 6Ung== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769117729; x=1769722529; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DnbHjkP7sr2MY8dvLIuI6wPgadGKGFiX6WTYohRo5Kw=; b=T/IVBkcQDB/kQFB16VHn9CmjcnfPR944VN61QXDKYF2gFTYlNDJT6wJCtKTN2n75Ac UBMJW0shjorLLcVGy0S1FSpJfMFKxN5SpPLFtKMF5l7bFNojuM7afTlH8lhxrn4o12fG F/4JimLvkZSBvGryKBRwnGPjhcLdowrPTu6LC/2T3fd2x40r0UQzw1z0wPjjI9rY9BIN IzMe0Fnwoil2IVvGybanWQto7zLTCkwFWaZSa6DfNSF/3RKRImk/anhMse4lLySnrHPK jd1hqC5w7ZszcB/rc3DhTZIsHkOh26OG1x3pQz+3MNOv2qRoMrzisxhCtPkoeP/2l2ft pNoQ== X-Forwarded-Encrypted: i=1; AJvYcCUtW7VXnkCvZKkfniKztYSVPBKVr+xT0vdX/sqdx9BzEZYWy0+HkYlx+Pus0jSNBvuVSnZILXjD8x//hoDhfNw+@lists.infradead.org X-Gm-Message-State: AOJu0Yyvt4C4vEPW9/Y4xOeAeTrTdWn9pt6NmgVtEvyu2LezqOYvLKOt b6OyvK5hm7cxunfu1BkV+KNNfjMuxYj6rKRwtnvq5AMz/yaYBbVAEDfriZLsfIEOBgywurBAJdp yRv7BGg4m1A== X-Received: from dycok8.prod.google.com ([2002:a05:7301:db08:b0:2ac:32e7:3ccd]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7301:4084:b0:2b7:2263:3d3c with SMTP id 5a478bee46e88-2b739b6d29fmr262486eec.24.1769117728705; Thu, 22 Jan 2026 13:35:28 -0800 (PST) Date: Thu, 22 Jan 2026 13:35:07 -0800 In-Reply-To: <20260122213516.671089-1-irogers@google.com> Mime-Version: 1.0 References: <20260122213516.671089-1-irogers@google.com> X-Mailer: git-send-email 2.52.0.457.g6b5491de43-goog Message-ID: <20260122213516.671089-4-irogers@google.com> Subject: [PATCH v3 03/12] perf maps: Fix reference count leak in maps__find_ams From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , John Garry , Will Deacon , Leo Yan , Guo Ren , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Zecheng Li , Tianyou Li , Thomas Falcon , Julia Lawall , Suchit Karunakaran , Athira Rajeev , Aditya Bodkhe , Howard Chu , "=?UTF-8?q?Krzysztof=20=C5=81opatowski?=" , "Dr. David Alan Gilbert" , Shimin Guo , Sergei Trofimovich , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org Content-Type: text/plain; charset="UTF-8" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260122_133530_246587_EC93687A X-CRM114-Status: GOOD ( 11.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org ams and so ams->ms.map is an in argument, however, it is also overwritten. As a map is reference counted, ensure a map__put is done before overwriting it. Signed-off-by: Ian Rogers Fixes: 42fd623b58db ("perf maps: Get map before returning in maps__find") --- tools/perf/util/maps.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/perf/util/maps.c b/tools/perf/util/maps.c index 8ccc46d515b6..4092211cff62 100644 --- a/tools/perf/util/maps.c +++ b/tools/perf/util/maps.c @@ -708,6 +708,7 @@ int maps__find_ams(struct maps *maps, struct addr_map_symbol *ams) if (ams->addr < map__start(ams->ms.map) || ams->addr >= map__end(ams->ms.map)) { if (maps == NULL) return -1; + map__put(ams->ms.map); ams->ms.map = maps__find(maps, ams->addr); if (ams->ms.map == NULL) return -1; -- 2.52.0.457.g6b5491de43-goog