From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5F8D3D19512 for ; Tue, 27 Jan 2026 00:41:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4TdKw4Zr/RrtcmcKfIpV4EqrVSeuMGDLi2XBQz0FdGQ=; b=MyVeN6p+uliHXSsfGQ51T4FKP3 8bgTqzSeibKjWyj/j+XKxLyt0j6NQp4GnERXeUJIUiO3YEnhRPmBQY8D7iqbeslCMYe9DQBSSN9XP LPv4KGvHO/nKNHveaDvjkO1cS4eEqQ1fOAKLHMfE/kO1qy8f/GIeL5F0GUOwHgqyuLgZpDc6H0HPg T3pydcDieeHLutDHi2T3hXjkbKEWMAII41u5sy9ljA853EyLq8U+n3Af1fjaIdgfefyHvImKF9VQA wQLyYo4kBYPrgtVatO/oAoN5SHVSLgcqmwfd6xVgOPyrHMdlOq5Sq31QzsTspcNzJHShzj1LPE7em cbv5/9Dw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vkX8u-0000000DOE0-3ypc; Tue, 27 Jan 2026 00:41:16 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vkX8l-0000000DO8v-2fpR; Tue, 27 Jan 2026 00:41:08 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id ED48144158; Tue, 27 Jan 2026 00:41:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4AEAAC116C6; Tue, 27 Jan 2026 00:41:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769474464; bh=nB6yjbNXx42GKTBaXT02ZrBwPDOQ+Wsz8KL8vGzVQaU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nCLiRYhXSjC0cyWgFzfpBfJz3GNGLNuwr8vZmbLNiPP0025V4EsEpQZ2mNpPf5yLV S+N/f4ZgDlNfz6MiEJahyApVGOTfnTp3e/Dhyj39TDiQfKpKYyw6UsxbPCG4wiwQog PDXoIrevY3UX/IqyOqJQpVLeSRwWcON7gX1EthcZZV9NqkeUMMpfICM7AnomZSpJKA IS8yLo13jC5CYTQk39EdkZpsbmvdOyUgwkppwIHx3E/0anYLWw2rOIXPsJIobLh213 5CqFqOGb5/euCk663qw+qv+iYaPHWqs+DIEFRzsbCVhxJFHwSFBJnzsU8q+5kvtUxF ArgQDm22sXoKQ== From: Jakub Kicinski To: rmk+kernel@armlinux.org.uk Cc: Jakub Kicinski , linux-stm32@st-md-mailman.stormreply.com, andrew+netdev@lunn.ch, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, pabeni@redhat.com, linux-rockchip@lists.infradead.org, heiko@sntech.de, alexandre.torgue@foss.st.com, andrew@lunn.ch, davem@davemloft.net, edumazet@google.com Subject: Re: [net-next,v2,22/22] net: stmmac: rk: rk3506, rk3528 and kk3588 have rmii_mode in clock register Date: Mon, 26 Jan 2026 16:41:03 -0800 Message-ID: <20260127004103.3785897-1-kuba@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260126_164107_698705_9F0BEC18 X-CRM114-Status: UNSURE ( 6.49 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This is an AI-generated review of your patch. The human sending this email has considered the AI review valid, or at least plausible. For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html --- net: stmmac: rk: rk3506, rk3528 and kk3588 have rmii_mode in clock register This patch moves the rmii_mode bit configuration for rk3506, rk3528 and rk3588 from the SoC-specific set_to_rmii() functions to the common rk_gmac_powerup() path, using the new rmii_mode_mask field in the clock register configuration. > net: stmmac: rk: rk3506, rk3528 and kk3588 have rmii_mode in clock register ^^^^^^ This isn't a bug, but the subject line has a typo: "kk3588" should be "rk3588". The commit body correctly refers to "rk3588" and the code changes reference rk3588_ops, rk3588_init, and RK3588_* macros.