From: Janne Grunau <j@jannau.net>
To: Thomas Gleixner <tglx@kernel.org>
Cc: Sven Peter <sven@kernel.org>, Neal Gompa <neal@gompa.dev>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] irqchip/apple-aic: Add support for "apple,t8122-aic3"
Date: Wed, 28 Jan 2026 09:29:31 +0100 [thread overview]
Message-ID: <20260128082931.GC1667597@robin.jannau.net> (raw)
In-Reply-To: <87fr7scqxl.ffs@tglx>
On Mon, Jan 26, 2026 at 04:52:06PM +0100, Thomas Gleixner wrote:
> On Sun, Jan 25 2026 at 12:08, Janne Grunau wrote:
> > +/*
> > + * AIC v3 registers (MMIO)
> > + */
> > +
>
> Pointless newline and please make this a /* Oneline comment */
copy-n-pasted from AICv2 (and AICv1) above, changed locally for v2
> > +#define AIC3_IRQ_CFG 0x10000
> > +
> > }
> > + case 3:
> > case 2: {
>
> 1 3 2 is a weird count order...
version 3 was using a fall-through in the intial version so the order
made sense then. Change locally to 'case 2 ... 3:'
Janne
prev parent reply other threads:[~2026-01-28 8:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-25 11:08 [PATCH 0/2] Add Apple interrupt controller 3 support Janne Grunau
2026-01-25 11:08 ` [PATCH 1/2] dt-bindings: interrupt-controller: apple,aic2: Add AICv3 Janne Grunau
2026-01-25 11:35 ` Mark Kettenis
2026-01-25 11:48 ` Janne Grunau
2026-01-25 11:08 ` [PATCH 2/2] irqchip/apple-aic: Add support for "apple,t8122-aic3" Janne Grunau
2026-01-25 11:42 ` Sven Peter
2026-01-25 11:59 ` Janne Grunau
2026-01-26 15:52 ` Thomas Gleixner
2026-01-28 8:29 ` Janne Grunau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260128082931.GC1667597@robin.jannau.net \
--to=j@jannau.net \
--cc=asahi@lists.linux.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neal@gompa.dev \
--cc=robh@kernel.org \
--cc=sven@kernel.org \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox