From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A125DD49C9E for ; Fri, 30 Jan 2026 10:49:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:CC:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tW4Px4smL5fi+ix12RtFigxB6fK8VdHpj2MG+SERwNI=; b=WIjvEo8kjyhrzs16QfnVZphLHy rysI0sLNwElTR1ZnUfn2IqXz2EntLDkp4VuR6mN2/R4Z0A2m/kRJmXRKIAmDDOeqjlYFjNubCFPIf mqYWTx1IZKxqK0phpRs72akL5apPGot3jYmVdoirznULdQqxVngM6K7Z4TOHgOk27zJWe93nBRASc naqq1kcsuaYXNgqKBNK60xqUHSOWqXDyXr5S/aZFvlKMqt0PYvLEi/6EC4XTfIdoTEQqhE6/6bs+p P0MyfsUYiatie9OVUkRh+B1kJGql5V/xzm7w1ZqBs4C8wKgTgiE8E+P53Hf3ejqAxtkTIwE0vYd+D iiDiNaNA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vlm4M-00000001L4T-3DVq; Fri, 30 Jan 2026 10:49:42 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vlm4K-00000001L42-17Lk for linux-arm-kernel@lists.infradead.org; Fri, 30 Jan 2026 10:49:41 +0000 Received: from mail.maildlp.com (unknown [172.18.224.83]) by frasgout.his.huawei.com (SkyGuard) with ESMTPS id 4f2Xmt4F0pzHnGkW; Fri, 30 Jan 2026 18:48:46 +0800 (CST) Received: from dubpeml500005.china.huawei.com (unknown [7.214.145.207]) by mail.maildlp.com (Postfix) with ESMTPS id DED4440569; Fri, 30 Jan 2026 18:49:37 +0800 (CST) Received: from localhost (10.203.177.15) by dubpeml500005.china.huawei.com (7.214.145.207) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Fri, 30 Jan 2026 10:49:37 +0000 Date: Fri, 30 Jan 2026 10:49:36 +0000 From: Jonathan Cameron To: Abdurrahman Hussain via B4 Relay CC: , Michal Simek , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Shevchenko , , , , , Andrew Lunn Subject: Re: [PATCH v7 3/6] i2c: xiic: remove duplicate error message Message-ID: <20260130104936.00005ee1@huawei.com> In-Reply-To: <20260129-i2c-xiic-v7-3-727e434897ef@nexthop.ai> References: <20260129-i2c-xiic-v7-0-727e434897ef@nexthop.ai> <20260129-i2c-xiic-v7-3-727e434897ef@nexthop.ai> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.15] X-ClientProxiedBy: lhrpeml100012.china.huawei.com (7.191.174.184) To dubpeml500005.china.huawei.com (7.214.145.207) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260130_024940_459163_3F152EDE X-CRM114-Status: GOOD ( 14.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 29 Jan 2026 21:43:15 +0000 Abdurrahman Hussain via B4 Relay wrote: > From: Abdurrahman Hussain > > The devm_request_threaded_irq() already prints an error message. Remove > the duplicate. > > Reviewed-by: Andy Shevchenko > Reviewed-by: Andrew Lunn > Signed-off-by: Abdurrahman Hussain > --- > drivers/i2c/busses/i2c-xiic.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c > index a480cbb86d93..ca5685660e45 100644 > --- a/drivers/i2c/busses/i2c-xiic.c > +++ b/drivers/i2c/busses/i2c-xiic.c > @@ -1493,11 +1493,8 @@ static int xiic_i2c_probe(struct platform_device *pdev) > ret = devm_request_threaded_irq(&pdev->dev, irq, NULL, > xiic_process, IRQF_ONESHOT, > pdev->name, i2c); > - > - if (ret < 0) { > - dev_err_probe(&pdev->dev, ret, "Cannot claim IRQ\n"); > + if (ret) > return ret; Ah ok. I'd be tempted to drop that before the previous patch then we don't have the dance that I guess was there to reduce churn. > - } > > i2c->singlemaster = > of_property_read_bool(pdev->dev.of_node, "single-master"); >