Re: [PATCH 2/3] dt-bindings: arm: rockchip: Add OneThing Edge Cube series

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1669 bytes --]

On Sat, Jan 31, 2026 at 11:31:02PM +0800, Jun Yan wrote:
> Add devicetree binding for the OneThing OEC and OEC-turbo
> 
> The OneThing Edge Cube (OEC) series features the RK3566 SoC, 8GB
> eMMC storage, and supports one SATA interface, one Gigabit Ethernet
> port, and one USB 3.0 port.
> Among the lineup, the standard OEC model comes with 2GB of RAM, while
> the OEC-turbo features 4GB of RAM; The rest of the specifications are
> identical.
> 
> The OneThing Edge Cube series (shipping with the vendor firmware) is
> originally designed as a PCDN (P2P Content Delivery Network) device.
> 
> Signed-off-by: Jun Yan <jerrysteve1101@gmail.com>
> ---
>  Documentation/devicetree/bindings/arm/rockchip.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index ae77ded9fe47..eeafe40e0f23 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -813,6 +813,12 @@ properties:
>            - const: openailab,eaidk-610
>            - const: rockchip,rk3399
>  
> +      - description: OneThing Edge Cube series
> +        items:
> +          - const: onething,oec
> +          - const: onething,oec-turbo

This doesn't match your dts, so clearly you have not tested this
sufficiently. oec and oec-turbo should be in an enum.
pw-bot: changes-requested

> +          - const: rockchip,rk3566
> +
>        - description: Xunlong Orange Pi RK3399 board
>          items:
>            - const: xunlong,rk3399-orangepi
> -- 
> 2.52.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]