Re: [PATCH 2/3] dt-bindings: arm: rockchip: Add OneThing Edge Cube series

[Jun Yan <jerrysteve1101@gmail.com>]

> > Add devicetree binding for the OneThing OEC and OEC-turbo
> >=20
> > The OneThing Edge Cube (OEC) series features the RK3566 SoC, 8GB
> > eMMC storage, and supports one SATA interface, one Gigabit Ethernet
> > port, and one USB 3.0 port.
> > Among the lineup, the standard OEC model comes with 2GB of RAM, while
> > the OEC-turbo features 4GB of RAM; The rest of the specifications are
> > identical.
> >=20
> > The OneThing Edge Cube series (shipping with the vendor firmware) is
> > originally designed as a PCDN (P2P Content Delivery Network) device.
> >=20
> > Signed-off-by: Jun Yan <jerrysteve1101@gmail.com>
> > ---
> >  Documentation/devicetree/bindings/arm/rockchip.yaml | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >=20
> > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Docume=
> ntation/devicetree/bindings/arm/rockchip.yaml
> > index ae77ded9fe47..eeafe40e0f23 100644
> > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> > @@ -813,6 +813,12 @@ properties:
> >            - const: openailab,eaidk-610
> >            - const: rockchip,rk3399
> > =20
> > +      - description: OneThing Edge Cube series
> > +        items:
> > +          - const: onething,oec
> > +          - const: onething,oec-turbo
> 
> This doesn't match your dts, so clearly you have not tested this
> sufficiently. oec and oec-turbo should be in an enum.
> pw-bot: changes-requested

Sorry for that. Following Dragan Simic's suggestion, I will merge 
these two board items into one in the V3 patch set.

> 
> > +          - const: rockchip,rk3566
> > +
> >        - description: Xunlong Orange Pi RK3399 board
> >          items:
> >            - const: xunlong,rk3399-orangepi
> > --=20
> > 2.52.0
> >=20