From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 35C03E7FDFB for ; Tue, 3 Feb 2026 00:22:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=thJ1sEYwFgH0EvKxYK16kbar1XTDnkSFrt//2tTCrRU=; b=kYINkgjitVKQBPASK7reKjpQ9r gOK2WhBftAeAboIX04e1ZVM9HzF+p8QyLp0fZtdfVhEHW6UOXyIwlR65KxudFcqtwdrcncaJN+3w9 m/o3LaVOjHCwL7c72C9Yee9icecem3PXeR+g6GySyoz0RTQ6yN2mn+pakyZ8qDKUO8WpazzdcHR+O k74dMlf3+mEOOAHwG9SNyUcP4UIIfz7Evc56DcAT3lflOcDbk04FQonmmExre0XprljHZb4pHDhRj PKHZ3FpahtSXV8b237WeYn4IBW4GRuMv0T9kVnMvsO2EakId89DNH9LwonkvRQ9137iQU1clvzqTX vgbemT3g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vn4B1-00000005min-0Jk6; Tue, 03 Feb 2026 00:21:55 +0000 Received: from out-172.mta0.migadu.com ([91.218.175.172]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vn4Ay-00000005mey-0qLN for linux-arm-kernel@lists.infradead.org; Tue, 03 Feb 2026 00:21:53 +0000 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1770078109; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=thJ1sEYwFgH0EvKxYK16kbar1XTDnkSFrt//2tTCrRU=; b=F56dhBSkAWENXfvqexDxxPOibf1MniHSlSg6KfR3MGZFA9/oZaLVyAlV1239KOjLP073rC dz2ohdPnqZpgUZakeqtU1ySICG7LLFePZbVos+3ZQvWxNIEPXwDBBFMzWqbo8KEuRgaL/F p9FMmbWygvHrJYq0b36bpoIQuRwu9m0= From: Sean Anderson To: Laurent Pinchart , Vinod Koul , linux-phy@lists.infradead.org Cc: =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Lorenzo Pieralisi , Radhey Shyam Pandey , linux-kernel@vger.kernel.org, Michal Simek , linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, Neil Armstrong , Rob Herring , Thippeswamy Havalige , Manivannan Sadhasivam , Bjorn Helgaas , Sean Anderson Subject: [PATCH 2/8] phy: zynqmp: Refactor bus width configuration into helper Date: Mon, 2 Feb 2026 19:21:22 -0500 Message-Id: <20260203002128.935842-3-sean.anderson@linux.dev> In-Reply-To: <20260203002128.935842-1-sean.anderson@linux.dev> References: <20260203002128.935842-1-sean.anderson@linux.dev> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260202_162152_387715_688ABA06 X-CRM114-Status: UNSURE ( 8.75 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Split off the bus width configuration into a helper function for reuse. Signed-off-by: Sean Anderson --- drivers/phy/xilinx/phy-zynqmp.c | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/drivers/phy/xilinx/phy-zynqmp.c b/drivers/phy/xilinx/phy-zynqmp.c index fe6b4925d166..0d3c578d0f3f 100644 --- a/drivers/phy/xilinx/phy-zynqmp.c +++ b/drivers/phy/xilinx/phy-zynqmp.c @@ -502,6 +502,17 @@ static void xpsgtr_lane_set_protocol(struct xpsgtr_phy *gtr_phy) } } +/* Set the bus width */ +static void xpsgtr_phy_init_bus_width(struct xpsgtr_phy *gtr_phy, u32 width) +{ + struct xpsgtr_dev *gtr_dev = gtr_phy->dev; + u32 mask = PROT_BUS_WIDTH_MASK(gtr_phy->lane); + u32 val = width << PROT_BUS_WIDTH_SHIFT(gtr_phy->lane); + + xpsgtr_clr_set(gtr_dev, TX_PROT_BUS_WIDTH, mask, val); + xpsgtr_clr_set(gtr_dev, RX_PROT_BUS_WIDTH, mask, val); +} + /* Bypass (de)scrambler and 8b/10b decoder and encoder. */ static void xpsgtr_bypass_scrambler_8b10b(struct xpsgtr_phy *gtr_phy) { @@ -535,14 +546,7 @@ static void xpsgtr_phy_init_sata(struct xpsgtr_phy *gtr_phy) /* SGMII-specific initialization. */ static void xpsgtr_phy_init_sgmii(struct xpsgtr_phy *gtr_phy) { - struct xpsgtr_dev *gtr_dev = gtr_phy->dev; - u32 mask = PROT_BUS_WIDTH_MASK(gtr_phy->lane); - u32 val = PROT_BUS_WIDTH_10 << PROT_BUS_WIDTH_SHIFT(gtr_phy->lane); - - /* Set SGMII protocol TX and RX bus width to 10 bits. */ - xpsgtr_clr_set(gtr_dev, TX_PROT_BUS_WIDTH, mask, val); - xpsgtr_clr_set(gtr_dev, RX_PROT_BUS_WIDTH, mask, val); - + xpsgtr_phy_init_bus_width(gtr_phy, PROT_BUS_WIDTH_10); xpsgtr_bypass_scrambler_8b10b(gtr_phy); } -- 2.35.1.1320.gc452695387.dirty