public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
* [PATCH 1/2] [RFC] debugobjects: avoid gcc-16.0.1 section mismatch
@ 2026-02-03 16:23 Arnd Bergmann
  2026-02-03 16:24 ` [PATCH 2/2] [RFC] iommu: io-pgtable-arm-v7s: " Arnd Bergmann
  0 siblings, 1 reply; 5+ messages in thread
From: Arnd Bergmann @ 2026-02-03 16:23 UTC (permalink / raw)
  To: Will Deacon, Robin Murphy, Joerg Roedel, Andrew Morton,
	Thomas Gleixner
  Cc: linux-arm-kernel, iommu, linux-kernel, Arnd Bergmann,
	Sebastian Andrzej Siewior

From: Arnd Bergmann <arnd@arndb.de>

gcc-16 has gained some more advanced inlining techniques that enable
it to inline the is_static_object() function pointer into a specialized
version of lookup_object_or_alloc:

WARNING: modpost: vmlinux: section mismatch in reference: lookup_object_or_alloc.part.0+0x1ac (section: .text) -> is_static_object (section: .init.text)

From what I can tell, the transformation is correct, as this
is only called when lookup_object_or_alloc() is called from
debug_objects_selftest(), which is also __init.

I have not come up with a good workaround, so this simply marks
is_static_object() as not __init. Since there are currently only two
files where this happens, that may be an easy way out.

If anyone has a better idea for how to deal with that, let me know!

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 lib/debugobjects.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/debugobjects.c b/lib/debugobjects.c
index 89a1d6745dc2..056957c4e52f 100644
--- a/lib/debugobjects.c
+++ b/lib/debugobjects.c
@@ -1195,7 +1195,7 @@ struct self_test {
 
 static __initconst const struct debug_obj_descr descr_type_test;
 
-static bool __init is_static_object(void *addr)
+static bool is_static_object(void *addr)
 {
 	struct self_test *obj = addr;
 
-- 
2.39.5



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/2] [RFC] iommu: io-pgtable-arm-v7s: avoid gcc-16.0.1 section mismatch
  2026-02-03 16:23 [PATCH 1/2] [RFC] debugobjects: avoid gcc-16.0.1 section mismatch Arnd Bergmann
@ 2026-02-03 16:24 ` Arnd Bergmann
  2026-03-10 16:40   ` Will Deacon
  0 siblings, 1 reply; 5+ messages in thread
From: Arnd Bergmann @ 2026-02-03 16:24 UTC (permalink / raw)
  To: Will Deacon, Robin Murphy, Joerg Roedel, Andrew Morton,
	Thomas Gleixner
  Cc: linux-arm-kernel, iommu, linux-kernel, Arnd Bergmann

From: Arnd Bergmann <arnd@arndb.de>

gcc-16 has gained some more advanced inlining techniques that enable
it to inline the dummy_tlb_add_page() and dummy_tlb_flush() function
pointers into a specialized version of __arm_v7s_unmap:

WARNING: modpost: vmlinux: section mismatch in reference: __arm_v7s_unmap+0x2cc (section: .text) -> dummy_tlb_add_page (section: .init.text)

From what I can tell, the transformation is correct, as this
is only called when __arm_v7s_unmap() is called from
arm_v7s_do_selftests(), which is also __init.

I have not come up with a good workaround, so this simply marks
dummy_tlb_add_page() as not __init. Since there are currently only two
files where this happens, that may be an easy way out.

If anyone has a better idea for how to deal with that, let me know!

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/iommu/io-pgtable-arm-v7s.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/iommu/io-pgtable-arm-v7s.c b/drivers/iommu/io-pgtable-arm-v7s.c
index 523355e91a2c..705885924afb 100644
--- a/drivers/iommu/io-pgtable-arm-v7s.c
+++ b/drivers/iommu/io-pgtable-arm-v7s.c
@@ -775,23 +775,23 @@ struct io_pgtable_init_fns io_pgtable_arm_v7s_init_fns = {
 
 #ifdef CONFIG_IOMMU_IO_PGTABLE_ARMV7S_SELFTEST
 
-static struct io_pgtable_cfg *cfg_cookie __initdata;
+static struct io_pgtable_cfg *cfg_cookie;
 
 static void __init dummy_tlb_flush_all(void *cookie)
 {
 	WARN_ON(cookie != cfg_cookie);
 }
 
-static void __init dummy_tlb_flush(unsigned long iova, size_t size,
+static void dummy_tlb_flush(unsigned long iova, size_t size,
 				   size_t granule, void *cookie)
 {
 	WARN_ON(cookie != cfg_cookie);
 	WARN_ON(!(size & cfg_cookie->pgsize_bitmap));
 }
 
-static void __init dummy_tlb_add_page(struct iommu_iotlb_gather *gather,
-				      unsigned long iova, size_t granule,
-				      void *cookie)
+static void dummy_tlb_add_page(struct iommu_iotlb_gather *gather,
+			       unsigned long iova, size_t granule,
+			       void *cookie)
 {
 	dummy_tlb_flush(iova, granule, granule, cookie);
 }
-- 
2.39.5



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/2] [RFC] iommu: io-pgtable-arm-v7s: avoid gcc-16.0.1 section mismatch
  2026-02-03 16:24 ` [PATCH 2/2] [RFC] iommu: io-pgtable-arm-v7s: " Arnd Bergmann
@ 2026-03-10 16:40   ` Will Deacon
  2026-03-10 19:26     ` Arnd Bergmann
  0 siblings, 1 reply; 5+ messages in thread
From: Will Deacon @ 2026-03-10 16:40 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Robin Murphy, Joerg Roedel, Andrew Morton, Thomas Gleixner,
	linux-arm-kernel, iommu, linux-kernel, Arnd Bergmann

On Tue, Feb 03, 2026 at 05:24:00PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> gcc-16 has gained some more advanced inlining techniques that enable
> it to inline the dummy_tlb_add_page() and dummy_tlb_flush() function
> pointers into a specialized version of __arm_v7s_unmap:
> 
> WARNING: modpost: vmlinux: section mismatch in reference: __arm_v7s_unmap+0x2cc (section: .text) -> dummy_tlb_add_page (section: .init.text)
> 
> From what I can tell, the transformation is correct, as this
> is only called when __arm_v7s_unmap() is called from
> arm_v7s_do_selftests(), which is also __init.
> 
> I have not come up with a good workaround, so this simply marks
> dummy_tlb_add_page() as not __init. Since there are currently only two
> files where this happens, that may be an easy way out.
> 
> If anyone has a better idea for how to deal with that, let me know!

Can we mark the dummy_* functions as 'noinline' instead? We shouldn't
have to keep the selftest code kicking around in memory after boot.

Will


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/2] [RFC] iommu: io-pgtable-arm-v7s: avoid gcc-16.0.1 section mismatch
  2026-03-10 16:40   ` Will Deacon
@ 2026-03-10 19:26     ` Arnd Bergmann
  2026-03-13 16:57       ` Will Deacon
  0 siblings, 1 reply; 5+ messages in thread
From: Arnd Bergmann @ 2026-03-10 19:26 UTC (permalink / raw)
  To: Will Deacon, Arnd Bergmann
  Cc: Robin Murphy, Joerg Roedel, Andrew Morton, Thomas Gleixner,
	linux-arm-kernel, iommu, linux-kernel, Mostafa Saleh

On Tue, Mar 10, 2026, at 17:40, Will Deacon wrote:
> On Tue, Feb 03, 2026 at 05:24:00PM +0100, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>> 
>> gcc-16 has gained some more advanced inlining techniques that enable
>> it to inline the dummy_tlb_add_page() and dummy_tlb_flush() function
>> pointers into a specialized version of __arm_v7s_unmap:
>> 
>> WARNING: modpost: vmlinux: section mismatch in reference: __arm_v7s_unmap+0x2cc (section: .text) -> dummy_tlb_add_page (section: .init.text)
>> 
>> From what I can tell, the transformation is correct, as this
>> is only called when __arm_v7s_unmap() is called from
>> arm_v7s_do_selftests(), which is also __init.
>> 
>> I have not come up with a good workaround, so this simply marks
>> dummy_tlb_add_page() as not __init. Since there are currently only two
>> files where this happens, that may be an easy way out.
>> 
>> If anyone has a better idea for how to deal with that, let me know!
>
> Can we mark the dummy_* functions as 'noinline' instead? We shouldn't
> have to keep the selftest code kicking around in memory after boot.

I think that would work as well, but I'd have to test it properly,
as the gcc behavior was already not what I had expected.

Another option may be to take this a bit further and do the
same for the arm_v7s selftest that Mostafa did in the lpae
selftest with 7e06063a43d3 ("iommu/io-pgtable-arm-selftests:
Use KUnit") and a3c24b6d7cd6 ("iommu/io-pgtable-arm-selftests:
Modularize the test").

I think that would be the most logical step, but it's also
beyond what I can do as a simple build fix.

     Arnd


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/2] [RFC] iommu: io-pgtable-arm-v7s: avoid gcc-16.0.1 section mismatch
  2026-03-10 19:26     ` Arnd Bergmann
@ 2026-03-13 16:57       ` Will Deacon
  0 siblings, 0 replies; 5+ messages in thread
From: Will Deacon @ 2026-03-13 16:57 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Arnd Bergmann, Robin Murphy, Joerg Roedel, Andrew Morton,
	Thomas Gleixner, linux-arm-kernel, iommu, linux-kernel,
	Mostafa Saleh

On Tue, Mar 10, 2026 at 08:26:40PM +0100, Arnd Bergmann wrote:
> On Tue, Mar 10, 2026, at 17:40, Will Deacon wrote:
> > On Tue, Feb 03, 2026 at 05:24:00PM +0100, Arnd Bergmann wrote:
> >> From: Arnd Bergmann <arnd@arndb.de>
> >> 
> >> gcc-16 has gained some more advanced inlining techniques that enable
> >> it to inline the dummy_tlb_add_page() and dummy_tlb_flush() function
> >> pointers into a specialized version of __arm_v7s_unmap:
> >> 
> >> WARNING: modpost: vmlinux: section mismatch in reference: __arm_v7s_unmap+0x2cc (section: .text) -> dummy_tlb_add_page (section: .init.text)
> >> 
> >> From what I can tell, the transformation is correct, as this
> >> is only called when __arm_v7s_unmap() is called from
> >> arm_v7s_do_selftests(), which is also __init.
> >> 
> >> I have not come up with a good workaround, so this simply marks
> >> dummy_tlb_add_page() as not __init. Since there are currently only two
> >> files where this happens, that may be an easy way out.
> >> 
> >> If anyone has a better idea for how to deal with that, let me know!
> >
> > Can we mark the dummy_* functions as 'noinline' instead? We shouldn't
> > have to keep the selftest code kicking around in memory after boot.
> 
> I think that would work as well, but I'd have to test it properly,
> as the gcc behavior was already not what I had expected.
> 
> Another option may be to take this a bit further and do the
> same for the arm_v7s selftest that Mostafa did in the lpae
> selftest with 7e06063a43d3 ("iommu/io-pgtable-arm-selftests:
> Use KUnit") and a3c24b6d7cd6 ("iommu/io-pgtable-arm-selftests:
> Modularize the test").
> 
> I think that would be the most logical step, but it's also
> beyond what I can do as a simple build fix.

tbh, I'm happy to take the noinline variant as a quick hack if it works.

Will


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-03-13 16:57 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-03 16:23 [PATCH 1/2] [RFC] debugobjects: avoid gcc-16.0.1 section mismatch Arnd Bergmann
2026-02-03 16:24 ` [PATCH 2/2] [RFC] iommu: io-pgtable-arm-v7s: " Arnd Bergmann
2026-03-10 16:40   ` Will Deacon
2026-03-10 19:26     ` Arnd Bergmann
2026-03-13 16:57       ` Will Deacon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox