From: Krzysztof Kozlowski <krzk@kernel.org>
To: Joey Lu <a0987203069@gmail.com>
Cc: airlied@gmail.com, simona@ffwll.ch,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, ychuang3@nuvoton.com, schung@nuvoton.com,
yclu4@nuvoton.com, linux-arm-kernel@lists.infradead.org,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: display: nuvoton: add MA35D1 DCU binding
Date: Thu, 5 Feb 2026 14:18:31 +0100 [thread overview]
Message-ID: <20260205-psychedelic-brave-toad-db4936@quoll> (raw)
In-Reply-To: <20260129040532.382693-2-a0987203069@gmail.com>
On Thu, Jan 29, 2026 at 12:05:30PM +0800, Joey Lu wrote:
> +
> + clocks:
> + items:
> + - description: DCU Gate clock for register access
> + - description: DCU Pixel clock for display timing
> +
> + clock-names:
> + items:
> + - const: dcu_gate
That's bus or apb
> + - const: dcup_div
That's pixel
Use descriptive names of functions here. Not your clock controller. It
is completely irrelevant whether you provide here gate or div or mux or
whatever else. If by any chance in new design you put here mux, not div,
then completely new binding?
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-02-05 13:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-29 4:05 [PATCH v2 0/3] drm: nuvoton: Add MA35D1 display controller support Joey Lu
2026-01-29 4:05 ` [PATCH v2 1/3] dt-bindings: display: nuvoton: add MA35D1 DCU binding Joey Lu
2026-02-05 13:18 ` Krzysztof Kozlowski [this message]
2026-02-06 7:05 ` Joey Lu
2026-01-29 4:05 ` [PATCH v2 2/3] arm64: dts: nuvoton: ma35d1: add display controller support Joey Lu
2026-02-05 13:23 ` Krzysztof Kozlowski
2026-02-06 7:12 ` Joey Lu
2026-02-06 8:56 ` Krzysztof Kozlowski
2026-02-06 9:21 ` Joey Lu
2026-01-29 4:05 ` [PATCH v2 3/3] drm/nuvoton: add MA35D1 display controller driver Joey Lu
2026-02-05 13:22 ` Krzysztof Kozlowski
2026-02-06 7:23 ` Joey Lu
2026-02-06 15:09 ` Icenowy Zheng
2026-02-09 8:45 ` Joey Lu
2026-02-10 12:02 ` Icenowy Zheng
2026-03-03 8:15 ` Joey Lu
2026-03-08 15:20 ` Icenowy Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260205-psychedelic-brave-toad-db4936@quoll \
--to=krzk@kernel.org \
--cc=a0987203069@gmail.com \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=robh@kernel.org \
--cc=schung@nuvoton.com \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
--cc=ychuang3@nuvoton.com \
--cc=yclu4@nuvoton.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox