* [PATCH] soc: fsl: cpm1: qmc: Fix error check for devm_ioremap_resource() in qmc_qe_init_resources()
@ 2026-02-09 1:59 Chen Ni
2026-02-09 7:50 ` Herve Codina
2026-02-09 9:04 ` Christophe Leroy (CS GROUP)
0 siblings, 2 replies; 3+ messages in thread
From: Chen Ni @ 2026-02-09 1:59 UTC (permalink / raw)
To: herve.codina, qiang.zhao, chleroy
Cc: linuxppc-dev, linux-arm-kernel, linux-kernel, Chen Ni
Fix wrong variable used for error checking after devm_ioremap_resource()
call. The function checks qmc->scc_pram instead of qmc->dpram, which
could lead to incorrect error handling.
Fixes: eb680d563089 ("soc: fsl: cpm1: qmc: Add support for QUICC Engine (QE) implementation")
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
drivers/soc/fsl/qe/qmc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/soc/fsl/qe/qmc.c b/drivers/soc/fsl/qe/qmc.c
index c4587b32a59b..672adff8e35f 100644
--- a/drivers/soc/fsl/qe/qmc.c
+++ b/drivers/soc/fsl/qe/qmc.c
@@ -1790,8 +1790,8 @@ static int qmc_qe_init_resources(struct qmc *qmc, struct platform_device *pdev)
return -EINVAL;
qmc->dpram_offset = res->start - qe_muram_dma(qe_muram_addr(0));
qmc->dpram = devm_ioremap_resource(qmc->dev, res);
- if (IS_ERR(qmc->scc_pram))
- return PTR_ERR(qmc->scc_pram);
+ if (IS_ERR(qmc->dpram))
+ return PTR_ERR(qmc->dpram);
return 0;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] soc: fsl: cpm1: qmc: Fix error check for devm_ioremap_resource() in qmc_qe_init_resources()
2026-02-09 1:59 [PATCH] soc: fsl: cpm1: qmc: Fix error check for devm_ioremap_resource() in qmc_qe_init_resources() Chen Ni
@ 2026-02-09 7:50 ` Herve Codina
2026-02-09 9:04 ` Christophe Leroy (CS GROUP)
1 sibling, 0 replies; 3+ messages in thread
From: Herve Codina @ 2026-02-09 7:50 UTC (permalink / raw)
To: Chen Ni; +Cc: qiang.zhao, chleroy, linuxppc-dev, linux-arm-kernel, linux-kernel
Hi Chen,
On Mon, 9 Feb 2026 09:59:04 +0800
Chen Ni <nichen@iscas.ac.cn> wrote:
> Fix wrong variable used for error checking after devm_ioremap_resource()
> call. The function checks qmc->scc_pram instead of qmc->dpram, which
> could lead to incorrect error handling.
>
> Fixes: eb680d563089 ("soc: fsl: cpm1: qmc: Add support for QUICC Engine (QE) implementation")
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
> drivers/soc/fsl/qe/qmc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/soc/fsl/qe/qmc.c b/drivers/soc/fsl/qe/qmc.c
> index c4587b32a59b..672adff8e35f 100644
> --- a/drivers/soc/fsl/qe/qmc.c
> +++ b/drivers/soc/fsl/qe/qmc.c
> @@ -1790,8 +1790,8 @@ static int qmc_qe_init_resources(struct qmc *qmc, struct platform_device *pdev)
> return -EINVAL;
> qmc->dpram_offset = res->start - qe_muram_dma(qe_muram_addr(0));
> qmc->dpram = devm_ioremap_resource(qmc->dev, res);
> - if (IS_ERR(qmc->scc_pram))
> - return PTR_ERR(qmc->scc_pram);
> + if (IS_ERR(qmc->dpram))
> + return PTR_ERR(qmc->dpram);
>
> return 0;
> }
Yes, indeed.
Thanks for the fix.
Acked-by: Herve Codina <herve.codina@bootlin.com>
Best regards,
Hervé
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] soc: fsl: cpm1: qmc: Fix error check for devm_ioremap_resource() in qmc_qe_init_resources()
2026-02-09 1:59 [PATCH] soc: fsl: cpm1: qmc: Fix error check for devm_ioremap_resource() in qmc_qe_init_resources() Chen Ni
2026-02-09 7:50 ` Herve Codina
@ 2026-02-09 9:04 ` Christophe Leroy (CS GROUP)
1 sibling, 0 replies; 3+ messages in thread
From: Christophe Leroy (CS GROUP) @ 2026-02-09 9:04 UTC (permalink / raw)
To: herve.codina, qiang.zhao, Chen Ni
Cc: Christophe Leroy, linuxppc-dev, linux-arm-kernel, linux-kernel
On Mon, 09 Feb 2026 09:59:04 +0800, Chen Ni wrote:
> Fix wrong variable used for error checking after devm_ioremap_resource()
> call. The function checks qmc->scc_pram instead of qmc->dpram, which
> could lead to incorrect error handling.
>
>
Applied, thanks!
[1/1] soc: fsl: cpm1: qmc: Fix error check for devm_ioremap_resource() in qmc_qe_init_resources()
commit: 39676244858f24089f83134bbf975dd31abe7544
Best regards,
--
Christophe Leroy (CS GROUP) <chleroy@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-02-09 9:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-09 1:59 [PATCH] soc: fsl: cpm1: qmc: Fix error check for devm_ioremap_resource() in qmc_qe_init_resources() Chen Ni
2026-02-09 7:50 ` Herve Codina
2026-02-09 9:04 ` Christophe Leroy (CS GROUP)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox