* [PATCH] drm/rockchip: vop2: Use drm_err_ratelimited() for wait timeouts
@ 2026-02-09 16:16 Hsieh Hung-En
2026-02-21 22:17 ` Heiko Stuebner
0 siblings, 1 reply; 2+ messages in thread
From: Hsieh Hung-En @ 2026-02-09 16:16 UTC (permalink / raw)
To: Sandy Huang, Heiko Stübner, Andy Yan
Cc: dri-devel, linux-arm-kernel, linux-rockchip, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Hsieh Hung-En
Replace deprecated DRM_DEV_ERROR() with drm_err_ratelimited() in the VOP2
register wait timeout paths to align with current DRM logging helpers and
avoid flooding the kernel log when timeouts repeat.
Signed-off-by: Hsieh Hung-En <hungen3108@gmail.com>
---
drivers/gpu/drm/rockchip/rockchip_vop2_reg.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c b/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c
index f3950e8476a7..02a788a4dfdd 100644
--- a/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c
+++ b/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c
@@ -2106,8 +2106,8 @@ static void rk3568_vop2_wait_for_port_mux_done(struct vop2 *vop2)
ret = readx_poll_timeout_atomic(rk3568_vop2_read_port_mux, vop2, port_mux_sel,
port_mux_sel == vop2->old_port_sel, 10, 50 * 1000);
if (ret)
- DRM_DEV_ERROR(vop2->dev, "wait port_mux done timeout: 0x%x--0x%x\n",
- port_mux_sel, vop2->old_port_sel);
+ drm_err_ratelimited(vop2->drm, "wait port_mux done timeout: 0x%x--0x%x\n",
+ port_mux_sel, vop2->old_port_sel);
}
static u32 rk3568_vop2_read_layer_cfg(struct vop2 *vop2)
@@ -2126,8 +2126,8 @@ static void rk3568_vop2_wait_for_layer_cfg_done(struct vop2 *vop2, u32 cfg)
ret = readx_poll_timeout_atomic(rk3568_vop2_read_layer_cfg, vop2, atv_layer_cfg,
atv_layer_cfg == cfg, 10, 50 * 1000);
if (ret)
- DRM_DEV_ERROR(vop2->dev, "wait layer cfg done timeout: 0x%x--0x%x\n",
- atv_layer_cfg, cfg);
+ drm_err_ratelimited(vop2->drm, "wait layer cfg done timeout: 0x%x--0x%x\n",
+ atv_layer_cfg, cfg);
}
static void rk3568_vop2_setup_layer_mixer(struct vop2_video_port *vp)
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/rockchip: vop2: Use drm_err_ratelimited() for wait timeouts
2026-02-09 16:16 [PATCH] drm/rockchip: vop2: Use drm_err_ratelimited() for wait timeouts Hsieh Hung-En
@ 2026-02-21 22:17 ` Heiko Stuebner
0 siblings, 0 replies; 2+ messages in thread
From: Heiko Stuebner @ 2026-02-21 22:17 UTC (permalink / raw)
To: Sandy Huang, Andy Yan, Hsieh Hung-En
Cc: Heiko Stuebner, dri-devel, linux-arm-kernel, linux-rockchip,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter
On Tue, 10 Feb 2026 00:16:21 +0800, Hsieh Hung-En wrote:
> Replace deprecated DRM_DEV_ERROR() with drm_err_ratelimited() in the VOP2
> register wait timeout paths to align with current DRM logging helpers and
> avoid flooding the kernel log when timeouts repeat.
>
>
Applied, thanks!
[1/1] drm/rockchip: vop2: Use drm_err_ratelimited() for wait timeouts
commit: f33a0a7f902d0715c1c09d7a128b1c94c09fcfc1
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-02-21 22:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-09 16:16 [PATCH] drm/rockchip: vop2: Use drm_err_ratelimited() for wait timeouts Hsieh Hung-En
2026-02-21 22:17 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox