From: Heiko Stuebner <heiko@sntech.de>
To: heiko@sntech.de
Cc: quentin.schulz@cherry.de, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Heiko Stuebner <heiko.stuebner@cherry.de>
Subject: [PATCH v2 2/4] arm64: dts: rockchip: use gated-fixed-clock for pcie-refclk on rk3588-tiger
Date: Tue, 10 Feb 2026 09:03:00 +0100 [thread overview]
Message-ID: <20260210080303.680403-3-heiko@sntech.de> (raw)
In-Reply-To: <20260210080303.680403-1-heiko@sntech.de>
From: Heiko Stuebner <heiko.stuebner@cherry.de>
Using a combination of fixed clock and gpio-gate clock works but does
not describe the actual hardware. Use the gated-fixed-clock binding
to describe this in a nicer way.
Signed-off-by: Heiko Stuebner <heiko.stuebner@cherry.de>
---
.../arm64/boot/dts/rockchip/rk3588-tiger.dtsi | 19 +++++--------------
1 file changed, 5 insertions(+), 14 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3588-tiger.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-tiger.dtsi
index 27269b7b08aa..b4b8f305935f 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-tiger.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3588-tiger.dtsi
@@ -47,23 +47,14 @@ led-1 {
};
};
- /*
- * 100MHz reference clock for PCIe peripherals from PI6C557-05BLE
- * clock generator.
- * The clock output is gated via the OE pin on the clock generator.
- * This is modeled as a fixed-clock plus a gpio-gate-clock.
- */
- pcie_refclk_gen: pcie-refclk-gen-clock {
- compatible = "fixed-clock";
+ /* 100MHz PCIe reference clock from PI6C557-05BLE */
+ pcie_refclk: pcie-clock-generator {
+ compatible = "gated-fixed-clock";
#clock-cells = <0>;
clock-frequency = <100000000>;
- };
-
- pcie_refclk: pcie-refclk-clock {
- compatible = "gpio-gate-clock";
- clocks = <&pcie_refclk_gen>;
- #clock-cells = <0>;
+ clock-output-names = "pcie-refclk-clock";
enable-gpios = <&gpio4 RK_PB4 GPIO_ACTIVE_HIGH>; /* PCIE30X4_CLKREQN_M1_L */
+ vdd-supply = <&vcca_3v3_s0>;
};
vcc_1v1_nldo_s3: regulator-vcc-1v1-nldo-s3 {
--
2.47.2
next prev parent reply other threads:[~2026-02-10 8:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-10 8:02 [PATCH v2 0/4] Move to gated-fixed-clock for Theobroma/Cherry boards Heiko Stuebner
2026-02-10 8:02 ` [PATCH v2 1/4] arm64: dts: rockchip: use gated-fixed-clock for pcie-refclk on rk3588-jaguar Heiko Stuebner
2026-02-10 9:40 ` Quentin Schulz
2026-02-11 14:20 ` Shawn Lin
2026-02-10 8:03 ` Heiko Stuebner [this message]
2026-02-10 9:41 ` [PATCH v2 2/4] arm64: dts: rockchip: use gated-fixed-clock for pcie-refclk on rk3588-tiger Quentin Schulz
2026-02-11 14:24 ` Shawn Lin
2026-02-10 8:03 ` [PATCH v2 3/4] arm64: dts: rockchip: add pinctrl for clk-generator GPIO " Heiko Stuebner
2026-02-10 8:03 ` [PATCH v2 4/4] arm64: dts: rockchip: Make Jaguar PCIe-refclk pin use pull-up config Heiko Stuebner
2026-02-10 9:50 ` Quentin Schulz
2026-02-11 14:31 ` Shawn Lin
2026-03-02 12:58 ` [PATCH v2 0/4] Move to gated-fixed-clock for Theobroma/Cherry boards Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260210080303.680403-3-heiko@sntech.de \
--to=heiko@sntech.de \
--cc=heiko.stuebner@cherry.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=quentin.schulz@cherry.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox