public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Albert Yang <yangzh0906@thundersoft.com>
To: krzk@kernel.org
Cc: adrian.hunter@intel.com, arnd@arndb.de, bst-upstream@bstai.top,
	conor+dt@kernel.org, devicetree@vger.kernel.org,
	gordon.ge@bst.ai, krzk+dt@kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
	robh@kernel.org, ulf.hansson@linaro.org,
	yangzh0906@thundersoft.com
Subject: Re: [PATCH v5 5/6] arm64: defconfig: enable BST SDHCI controller
Date: Tue, 10 Feb 2026 19:56:06 +0800	[thread overview]
Message-ID: <20260210115606.270000-1-yangzh0906@thundersoft.com> (raw)
In-Reply-To: <93bff61b-ffc3-4b09-ac97-99f576e6d48f@kernel.org>

On Sun, 8 Feb 2026 at 12:38, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> On 23/01/2026 10:53, Albert Yang wrote:
> > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > index 45288ec9eaf7..7f4da3117329 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -1222,6 +1222,7 @@ CONFIG_MMC_BLOCK_MINORS=32
> >  CONFIG_MMC_ARMMMCI=y
> >  CONFIG_MMC_SDHCI=y
> >  CONFIG_MMC_SDHCI_ACPI=y
> > +CONFIG_MMC_SDHCI_BST=y
> 
> This is still wrongly ordered. Look at your Kconfig. Run savedefconfig.

Hi Krzysztof,

Thank you for catching this again. Sorry for the repeated mistake.

I incorrectly placed CONFIG_MMC_SDHCI_BST right after CONFIG_MMC_SDHCI_ACPI,
but in Kconfig, MMC_SDHCI_BST is defined after MMC_SDHCI_BCM_KONA (much later
than MMC_SDHCI_ACPI). I have now run savedefconfig and confirmed the correct
position is between CONFIG_MMC_SDHCI_TEGRA and CONFIG_MMC_SDHCI_F_SDH30:

  CONFIG_MMC_SDHCI_TEGRA=y
 +CONFIG_MMC_SDHCI_BST=y
  CONFIG_MMC_SDHCI_F_SDH30=y

Will fix this in v6 along with the DTS patch, which will be submitted to
the SoC tree as per Ulf's direction.

Best regards,
Albert


  reply	other threads:[~2026-02-10 11:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-23  9:53 [PATCH v5 0/6] mmc: add support for BST C1200 SDHCI controller Albert Yang
2026-01-23  9:53 ` [PATCH v5 1/6] dt-bindings: mmc: add binding for BST DWCMSHC " Albert Yang
2026-01-23  9:53 ` [PATCH v5 2/6] mmc: sdhci: allow drivers to pre-allocate bounce buffer Albert Yang
2026-01-23  9:53 ` [PATCH v5 3/6] mmc: sdhci: add Black Sesame Technologies BST C1200 controller driver Albert Yang
2026-01-23  9:53 ` [PATCH v5 4/6] arm64: dts: bst: enable eMMC controller in C1200 CDCU1.0 board Albert Yang
2026-01-23  9:53 ` [PATCH v5 5/6] arm64: defconfig: enable BST SDHCI controller Albert Yang
2026-02-08 11:38   ` Krzysztof Kozlowski
2026-02-10 11:56     ` Albert Yang [this message]
2026-01-23  9:53 ` [PATCH v5 6/6] MAINTAINERS: add MMC files to BST entry Albert Yang
2026-01-27 11:01 ` [PATCH v5 0/6] mmc: add support for BST C1200 SDHCI controller Ulf Hansson
2026-01-30  9:54   ` Albert Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260210115606.270000-1-yangzh0906@thundersoft.com \
    --to=yangzh0906@thundersoft.com \
    --cc=adrian.hunter@intel.com \
    --cc=arnd@arndb.de \
    --cc=bst-upstream@bstai.top \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gordon.ge@bst.ai \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox