From: Rob Herring <robh@kernel.org>
To: "André Draszik" <andre.draszik@linaro.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Peter Griffin <peter.griffin@linaro.org>,
Tudor Ambarus <tudor.ambarus@linaro.org>,
Juan Yescas <jyescas@google.com>,
Will McVicker <willmcvicker@google.com>,
kernel-team@android.com, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH v5 04/10] dt-bindings: soc: google: gs101-pmu: allow power domains as children
Date: Wed, 11 Feb 2026 15:12:29 -0600 [thread overview]
Message-ID: <20260211211229.GA3882182-robh@kernel.org> (raw)
In-Reply-To: <20260205-gs101-pd-v5-4-ede49cdb57a6@linaro.org>
On Thu, Feb 05, 2026 at 09:42:32PM +0000, André Draszik wrote:
> The power domains are a property of / implemented in the PMU. As such,
> they should be modelled as child nodes of the PMU.
>
> Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Signed-off-by: André Draszik <andre.draszik@linaro.org>
> ---
> v4:
> - consistent quoting using " (Krzysztof)
> - add samsung,dtzpc to example
>
> Note: Ideally, the newly added properties (ranges, etc.) should only be
> 'required' if "^power-domain@[0-9a-f]+$" exists as a patternProperty,
> as they're needed only in that case. As-is, this patch now causes
> warnings for existing DTs as they don't specify the new properties (and
> they shouldn't need to).
We can't have warnings added if they aren't valid.
> Only if DTs are updated to include
> power-domains, such an update should also add the new properties.
>
> I've not been able to come up with the correct schema syntax to achieve
> that. dependencies, dependentRequired, and dependentSchemas don't seem
> to support patterns. Similarly,
> - if:
> required:
> - ...
> then:
> required:
> - ...
>
> doesn't allow patterns in the 'if' block (or I didn't get the syntax
> right).
>
> Rob said in
> https://lore.kernel.org/all/20251010141357.GA219719-robh@kernel.org/
> that this is a known limitation in json-schema.
For a given compatible, you should either have child nodes or you don't.
The h/w is not variable. So something like this should work:
if:
properties:
compatible:
contains:
const: foo,bar
then:
required:
- ranges
- '#address-cells'
- '#size-cells'
Rob
next prev parent reply other threads:[~2026-02-11 21:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-05 21:42 [PATCH v5 00/10] pmdomain: samsung: add support for Google GS101 André Draszik
2026-02-05 21:42 ` [PATCH v5 01/10] dt-bindings: soc: google: add google,gs101-dtzpc André Draszik
2026-02-11 20:58 ` Rob Herring (Arm)
2026-02-05 21:42 ` [PATCH v5 02/10] dt-bindings: power: samsung: add google,gs101-pd André Draszik
2026-02-11 21:01 ` Rob Herring (Arm)
2026-02-05 21:42 ` [PATCH v5 03/10] dt-bindings: soc: samsung: exynos-pmu: move gs101-pmu into separate binding André Draszik
2026-02-11 21:03 ` Rob Herring (Arm)
2026-02-05 21:42 ` [PATCH v5 04/10] dt-bindings: soc: google: gs101-pmu: allow power domains as children André Draszik
2026-02-11 21:12 ` Rob Herring [this message]
2026-02-12 12:03 ` André Draszik
2026-02-12 20:06 ` Rob Herring
2026-02-12 20:33 ` André Draszik
2026-02-05 21:42 ` [PATCH v5 05/10] pmdomain: samsung: convert to using regmap André Draszik
2026-02-05 21:42 ` [PATCH v5 06/10] pmdomain: samsung: don't hard-code offset for registers to 0 and 4 André Draszik
2026-02-05 21:42 ` [PATCH v5 07/10] pmdomain: samsung: add support for google,gs101-pd André Draszik
2026-02-05 21:42 ` [PATCH v5 08/10] pmdomain: samsung: use dev_err() instead of pr_err() André Draszik
2026-02-05 21:42 ` [PATCH v5 09/10] pmdomain: samsung: implement SMC to save / restore TZ config André Draszik
2026-02-05 21:42 ` [PATCH v5 10/10] pmdomain: samsung: implement domain-supply regulator André Draszik
2026-03-03 15:46 ` [PATCH v5 00/10] pmdomain: samsung: add support for Google GS101 Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260211211229.GA3882182-robh@kernel.org \
--to=robh@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andre.draszik@linaro.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jyescas@google.com \
--cc=kernel-team@android.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=peter.griffin@linaro.org \
--cc=tudor.ambarus@linaro.org \
--cc=ulf.hansson@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox