Re: [PATCH 05/11] media: Add missing types to v4l2_ctrl_ptr

Nicolas Dufresne
2026-04-28T19:33:39Z

[-- Attachment #1: Type: text/plain, Size: 1781 bytes --]

Le jeudi 12 février 2026 à 11:23 -0500, Detlev Casanova a écrit :
> The v4l2_ctrl_ptr union contains pointers for all control types, but
> v4l2_ctrl_hevc_decode_params and v4l2_ctrl_hevc_scaling_matrix are missing.
>
> Add them.
>
> Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>

Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>

> ---
>  include/media/v4l2-ctrls.h | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/include/media/v4l2-ctrls.h b/include/media/v4l2-ctrls.h
> index 327976b14d50..a2b4c96a9a6f 100644
> --- a/include/media/v4l2-ctrls.h
> +++ b/include/media/v4l2-ctrls.h
> @@ -49,6 +49,8 @@ struct video_device;
>   * @p_hevc_sps: Pointer to an HEVC sequence parameter
> set structure.
>   * @p_hevc_pps: Pointer to an HEVC picture parameter
> set structure.
>   * @p_hevc_slice_params: Pointer to an HEVC slice parameters
> structure.
> + * @p_hevc_decode_params: Pointer to an HEVC decode parameters
> structure.
> + * @p_hevc_scaling_matrix Pointer to an HEVC scaling matrix structure.
>   * @p_hdr10_cll: Pointer to an HDR10 Content Light Level
> structure.
>   * @p_hdr10_mastering: Pointer to an HDR10 Mastering Display
> structure.
>   * @p_area: Pointer to an area.
> @@ -81,6 +83,8 @@ union v4l2_ctrl_ptr {
>   struct v4l2_ctrl_hevc_sps *p_hevc_sps;
>   struct v4l2_ctrl_hevc_pps *p_hevc_pps;
>   struct v4l2_ctrl_hevc_slice_params *p_hevc_slice_params;
> + struct v4l2_ctrl_hevc_decode_params *p_hevc_decode_params;
> + struct v4l2_ctrl_hevc_scaling_matrix *p_hevc_scaling_matrix;
>   struct v4l2_ctrl_vp9_compressed_hdr *p_vp9_compressed_hdr_probs;
>   struct v4l2_ctrl_vp9_frame *p_vp9_frame;
>   struct v4l2_ctrl_hdr10_cll_info *p_hdr10_cll;

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]