From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7EBE8E9A02C for ; Wed, 18 Feb 2026 23:55:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=TuixTbq+UbZmc2icBS3qUNjXj1Lf1+Ib3BW6X2nshk8=; b=yXgUD3s9up0VIeRhvYfDjVkBeF Xv9QAiWK+PNMtZbCCTRSh1+I+65z92W658VbTiiZC86TXVPVhAU2t7OOtcYBJDIq8b7U/qwwYcr5R /MV72e1mpUnLz0VCOHKPzGAYgzIb/2OPmGisBIX1IgBrUmiuOaSguh5O9qBPRnnbPIOh58waHeLv7 fhOzEnu2zFtAsGduWSR3DoD4Ng3vcMVvLqjgQt9ppyVN//F1S/S6qUHArC3xIvMJH6XL2Kx3YeUVD mhlx96LK3lTLU5G+to8bd8GLnKACGdSR78BLZ1edSuYPZcIHxwKQ9ubUteZhIE0K/JySrnWbnvM+T pPA90Jig==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vsrNv-0000000Abtc-22mh; Wed, 18 Feb 2026 23:55:11 +0000 Received: from out-171.mta1.migadu.com ([2001:41d0:203:375::ab]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vsrNr-0000000Abt9-0dPk for linux-arm-kernel@lists.infradead.org; Wed, 18 Feb 2026 23:55:09 +0000 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1771458901; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=TuixTbq+UbZmc2icBS3qUNjXj1Lf1+Ib3BW6X2nshk8=; b=MGlG8QMyM4+g+2aDC+DjxoSxCS2QkPvffqW1/+1fNNpkFHq6ibEzZMBNb7lEk3WueITGbn iNmL+qbBQRj6LHqy9/K2jLVD0314CTNyArfTf7T/SklueOC7X4xfbKlJpHbWTcCatnzhjI VT/qZ+uqtqBQ8FGRHpoktKWxuiYdalY= From: Thorsten Blum To: Herbert Xu , "David S. Miller" , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Linus Walleij , Ard Biesheuvel Cc: Thorsten Blum , stable@vger.kernel.org, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] crypto: atmel-sha204a - Fix OOM ->tfm_count leak Date: Thu, 19 Feb 2026 00:54:00 +0100 Message-ID: <20260218235358.973341-3-thorsten.blum@linux.dev> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260218_155507_426613_30CF6937 X-CRM114-Status: GOOD ( 10.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org If memory allocation fails, decrement ->tfm_count to avoid blocking future reads. Cc: stable@vger.kernel.org Fixes: da001fb651b0 ("crypto: atmel-i2c - add support for SHA204A random number generator") Signed-off-by: Thorsten Blum --- drivers/crypto/atmel-sha204a.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/atmel-sha204a.c b/drivers/crypto/atmel-sha204a.c index 2081a4d538d0..63633d2b8763 100644 --- a/drivers/crypto/atmel-sha204a.c +++ b/drivers/crypto/atmel-sha204a.c @@ -53,9 +53,10 @@ static int atmel_sha204a_rng_read_nonblocking(struct hwrng *rng, void *data, rng->priv = 0; } else { work_data = kmalloc(sizeof(*work_data), GFP_ATOMIC); - if (!work_data) + if (!work_data) { + atomic_dec(&i2c_priv->tfm_count); return -ENOMEM; - + } work_data->ctx = i2c_priv; work_data->client = i2c_priv->client; -- Thorsten Blum GPG: 1D60 735E 8AEF 3BE4 73B6 9D84 7336 78FD 8DFE EAD4