public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
* [PATCH 0/2] arm64: dts: mediatek: mt6359: give regulators unique names
@ 2026-02-19 22:55 David Lechner
  2026-02-19 22:55 ` [PATCH 1/2] " David Lechner
                   ` (3 more replies)
  0 siblings, 4 replies; 7+ messages in thread
From: David Lechner @ 2026-02-19 22:55 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
	AngeloGioacchino Del Regno, Liam Girdwood, Mark Brown,
	Hsin-Hsiung Wang
  Cc: devicetree, linux-kernel, linux-arm-kernel, linux-mediatek,
	David Lechner

While working on this regulator in U-Boot, I noticed that the regulator
names were not unique. This is considered an error in U-Boot and we get
the following error messages:

mt6359_regulator ldo_vrfck_1: 'regulator-name' has nonunique value: 'vrfck
mt6359_regulator ldo_vemc_1: 'regulator-name' has nonunique value: 'vemc

To fix, we add the _1 suffix regulator-name devicetree property to match
the same pattern seen in the node names.

Signed-off-by: David Lechner <dlechner@baylibre.com>
---
David Lechner (2):
      arm64: dts: mediatek: mt6359: give regulators unique names
      dt-bindings: regulator: mt6359: make regulator names unique

 Documentation/devicetree/bindings/regulator/mt6359-regulator.yaml | 4 ++--
 arch/arm64/boot/dts/mediatek/mt6359.dtsi                          | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
---
base-commit: 44982d352c33767cd8d19f8044e7e1161a587ff7
change-id: 20260219-mtk-mt6359-fix-regulator-names-cea2ddc697f3

Best regards,
-- 
David Lechner <dlechner@baylibre.com>



^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 1/2] arm64: dts: mediatek: mt6359: give regulators unique names
  2026-02-19 22:55 [PATCH 0/2] arm64: dts: mediatek: mt6359: give regulators unique names David Lechner
@ 2026-02-19 22:55 ` David Lechner
  2026-02-23 13:44   ` AngeloGioacchino Del Regno
  2026-02-19 22:55 ` [PATCH 2/2] dt-bindings: regulator: mt6359: make regulator names unique David Lechner
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 7+ messages in thread
From: David Lechner @ 2026-02-19 22:55 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
	AngeloGioacchino Del Regno, Liam Girdwood, Mark Brown,
	Hsin-Hsiung Wang
  Cc: devicetree, linux-kernel, linux-arm-kernel, linux-mediatek,
	David Lechner

Change the regulator-name properties to be unique for all regulators.
U-Boot cannot handle duplicate names.

Signed-off-by: David Lechner <dlechner@baylibre.com>
---
 arch/arm64/boot/dts/mediatek/mt6359.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt6359.dtsi b/arch/arm64/boot/dts/mediatek/mt6359.dtsi
index 467d8a4c2aa7..45ad69ee49ed 100644
--- a/arch/arm64/boot/dts/mediatek/mt6359.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt6359.dtsi
@@ -205,7 +205,7 @@ mt6359_vrfck_ldo_reg: ldo_vrfck {
 				regulator-max-microvolt = <1700000>;
 			};
 			mt6359_vrfck_1_ldo_reg: ldo_vrfck_1 {
-				regulator-name = "vrfck";
+				regulator-name = "vrfck_1";
 				regulator-min-microvolt = <1240000>;
 				regulator-max-microvolt = <1600000>;
 			};
@@ -227,7 +227,7 @@ mt6359_vemc_ldo_reg: ldo_vemc {
 				regulator-max-microvolt = <3300000>;
 			};
 			mt6359_vemc_1_ldo_reg: ldo_vemc_1 {
-				regulator-name = "vemc";
+				regulator-name = "vemc_1";
 				regulator-min-microvolt = <2500000>;
 				regulator-max-microvolt = <3300000>;
 			};

-- 
2.43.0



^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 2/2] dt-bindings: regulator: mt6359: make regulator names unique
  2026-02-19 22:55 [PATCH 0/2] arm64: dts: mediatek: mt6359: give regulators unique names David Lechner
  2026-02-19 22:55 ` [PATCH 1/2] " David Lechner
@ 2026-02-19 22:55 ` David Lechner
  2026-02-20  7:51   ` Krzysztof Kozlowski
  2026-02-23 14:46 ` (subset) [PATCH 0/2] arm64: dts: mediatek: mt6359: give regulators unique names Mark Brown
  2026-02-24  9:34 ` AngeloGioacchino Del Regno
  3 siblings, 1 reply; 7+ messages in thread
From: David Lechner @ 2026-02-19 22:55 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
	AngeloGioacchino Del Regno, Liam Girdwood, Mark Brown,
	Hsin-Hsiung Wang
  Cc: devicetree, linux-kernel, linux-arm-kernel, linux-mediatek,
	David Lechner

Update the example devicetree with unique regulator names for all
regulators. This reflects the same change made to the actual .dtsi file.

Signed-off-by: David Lechner <dlechner@baylibre.com>
---
 Documentation/devicetree/bindings/regulator/mt6359-regulator.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/regulator/mt6359-regulator.yaml b/Documentation/devicetree/bindings/regulator/mt6359-regulator.yaml
index d6b3b5a5c0b3..fe4ac9350ba0 100644
--- a/Documentation/devicetree/bindings/regulator/mt6359-regulator.yaml
+++ b/Documentation/devicetree/bindings/regulator/mt6359-regulator.yaml
@@ -287,7 +287,7 @@ examples:
           regulator-max-microvolt = <1700000>;
         };
         mt6359_vrfck_1_ldo_reg: ldo_vrfck_1 {
-          regulator-name = "vrfck";
+          regulator-name = "vrfck_1";
           regulator-min-microvolt = <1240000>;
           regulator-max-microvolt = <1600000>;
         };
@@ -309,7 +309,7 @@ examples:
           regulator-max-microvolt = <3300000>;
         };
         mt6359_vemc_1_ldo_reg: ldo_vemc_1 {
-          regulator-name = "vemc";
+          regulator-name = "vemc_1";
           regulator-min-microvolt = <2500000>;
           regulator-max-microvolt = <3300000>;
         };

-- 
2.43.0



^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH 2/2] dt-bindings: regulator: mt6359: make regulator names unique
  2026-02-19 22:55 ` [PATCH 2/2] dt-bindings: regulator: mt6359: make regulator names unique David Lechner
@ 2026-02-20  7:51   ` Krzysztof Kozlowski
  0 siblings, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2026-02-20  7:51 UTC (permalink / raw)
  To: David Lechner
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
	AngeloGioacchino Del Regno, Liam Girdwood, Mark Brown,
	Hsin-Hsiung Wang, devicetree, linux-kernel, linux-arm-kernel,
	linux-mediatek

On Thu, Feb 19, 2026 at 04:55:30PM -0600, David Lechner wrote:
> Update the example devicetree with unique regulator names for all
> regulators. This reflects the same change made to the actual .dtsi file.
> 
> Signed-off-by: David Lechner <dlechner@baylibre.com>
> ---

Subject: regulator

>  Documentation/devicetree/bindings/regulator/mt6359-regulator.yaml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/2] arm64: dts: mediatek: mt6359: give regulators unique names
  2026-02-19 22:55 ` [PATCH 1/2] " David Lechner
@ 2026-02-23 13:44   ` AngeloGioacchino Del Regno
  0 siblings, 0 replies; 7+ messages in thread
From: AngeloGioacchino Del Regno @ 2026-02-23 13:44 UTC (permalink / raw)
  To: David Lechner, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Matthias Brugger, Liam Girdwood, Mark Brown, Hsin-Hsiung Wang
  Cc: devicetree, linux-kernel, linux-arm-kernel, linux-mediatek

Il 19/02/26 23:55, David Lechner ha scritto:
> Change the regulator-name properties to be unique for all regulators.
> U-Boot cannot handle duplicate names.
> 
> Signed-off-by: David Lechner <dlechner@baylibre.com>

Okay, makes sense.

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>




^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: (subset) [PATCH 0/2] arm64: dts: mediatek: mt6359: give regulators unique names
  2026-02-19 22:55 [PATCH 0/2] arm64: dts: mediatek: mt6359: give regulators unique names David Lechner
  2026-02-19 22:55 ` [PATCH 1/2] " David Lechner
  2026-02-19 22:55 ` [PATCH 2/2] dt-bindings: regulator: mt6359: make regulator names unique David Lechner
@ 2026-02-23 14:46 ` Mark Brown
  2026-02-24  9:34 ` AngeloGioacchino Del Regno
  3 siblings, 0 replies; 7+ messages in thread
From: Mark Brown @ 2026-02-23 14:46 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
	AngeloGioacchino Del Regno, Liam Girdwood, Hsin-Hsiung Wang,
	David Lechner
  Cc: devicetree, linux-kernel, linux-arm-kernel, linux-mediatek

On Thu, 19 Feb 2026 16:55:28 -0600, David Lechner wrote:
> While working on this regulator in U-Boot, I noticed that the regulator
> names were not unique. This is considered an error in U-Boot and we get
> the following error messages:
> 
> mt6359_regulator ldo_vrfck_1: 'regulator-name' has nonunique value: 'vrfck
> mt6359_regulator ldo_vemc_1: 'regulator-name' has nonunique value: 'vemc
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[2/2] dt-bindings: regulator: mt6359: make regulator names unique
      commit: be704107e79696e855aa41e901a926039b6d2410

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: (subset) [PATCH 0/2] arm64: dts: mediatek: mt6359: give regulators unique names
  2026-02-19 22:55 [PATCH 0/2] arm64: dts: mediatek: mt6359: give regulators unique names David Lechner
                   ` (2 preceding siblings ...)
  2026-02-23 14:46 ` (subset) [PATCH 0/2] arm64: dts: mediatek: mt6359: give regulators unique names Mark Brown
@ 2026-02-24  9:34 ` AngeloGioacchino Del Regno
  3 siblings, 0 replies; 7+ messages in thread
From: AngeloGioacchino Del Regno @ 2026-02-24  9:34 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
	Liam Girdwood, Mark Brown, Hsin-Hsiung Wang, David Lechner
  Cc: devicetree, linux-kernel, linux-arm-kernel, linux-mediatek

On Thu, 19 Feb 2026 16:55:28 -0600, David Lechner wrote:
> While working on this regulator in U-Boot, I noticed that the regulator
> names were not unique. This is considered an error in U-Boot and we get
> the following error messages:
> 
> mt6359_regulator ldo_vrfck_1: 'regulator-name' has nonunique value: 'vrfck
> mt6359_regulator ldo_vemc_1: 'regulator-name' has nonunique value: 'vemc
> 
> [...]

Applied to v7.0-next/dts64, thanks!

[1/2] arm64: dts: mediatek: mt6359: give regulators unique names
      commit: d91639d0ab3223b61c00442021dc639c9ddc2b76

Cheers,
Angelo




^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2026-02-24  9:34 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-19 22:55 [PATCH 0/2] arm64: dts: mediatek: mt6359: give regulators unique names David Lechner
2026-02-19 22:55 ` [PATCH 1/2] " David Lechner
2026-02-23 13:44   ` AngeloGioacchino Del Regno
2026-02-19 22:55 ` [PATCH 2/2] dt-bindings: regulator: mt6359: make regulator names unique David Lechner
2026-02-20  7:51   ` Krzysztof Kozlowski
2026-02-23 14:46 ` (subset) [PATCH 0/2] arm64: dts: mediatek: mt6359: give regulators unique names Mark Brown
2026-02-24  9:34 ` AngeloGioacchino Del Regno

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox