From: Leo Yan <leo.yan@arm.com>
To: Jisheng Zhang <jszhang@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Thomas Gleixner <tglx@kernel.org>, Paul Walmsley <pjw@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>, Guo Ren <guoren@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-csky@vger.kernel.org
Subject: Re: [PATCH 3/3] arm64: use runtime constant to optimize handle_arch_irq access
Date: Fri, 20 Feb 2026 12:34:14 +0000 [thread overview]
Message-ID: <20260220123414.GF136967@e132581.arm.com> (raw)
In-Reply-To: <20260220090922.1506-4-jszhang@kernel.org>
Hi Jisheng,
On Fri, Feb 20, 2026 at 05:09:22PM +0800, Jisheng Zhang wrote:
> Currently, on arm64 platforms, the handle_arch_irq is a pointer which
> is set during booting, and every irq processing needs to access it,
> so it sits in hot code path. We can use the runtime constant mechanism
> which was introduced by Linus to speed up its accessing.
>
> Tested on Quad CA55 platform, the perf sched benchmark is improved
> by ~6.5%
6.5% is a quite high margin, especially for only one pointer's change.
Maybe it is good to share more info for which compiler you are using,
how you tested and the detailed results.
I played a bit on my juno board on CA73 cores with the command:
perf bench sched all
Run 3 iterations, and measures three metrics (messaging/pipe/seccomp)
and results in seconds. Less is better.
+---------------------+--------+--------+--------+--------+
|Without change | run1 | run2 | run3 | avg |
+---------------------+--------+--------+--------+--------+
|messaging (sec) | 4.546 | 4.508 | 4.591 | 4.548 |
|pipe (sec) | 24.258 | 24.224 | 24.017 | 24.166 |
|seccomp-notify (sec) | 48.393 | 48.457 | 48.232 | 48.361 |
+---------------------+--------+--------+--------+--------+
+---------------------+--------+--------+--------+--------+--------+
|With change | run1 | run2 | run3 | avg | diff |
+---------------------+--------+--------+--------+--------+--------+
|messaging (sec) | 4.493 | 4.523 | 4.556 | 4.524 | +0.52% |
|pipe (sec) | 23.159 | 23.702 | 28.649 | 25.170 | -4.15% |
|seccomp-notify (sec) | 46.848 | 46.938 | 46.973 | 46.920 | +2.98% |
+---------------------+--------+--------+--------+--------+--------+
With this patch, the messaging test shows a minor improvement (0.52%).
The pipe test performs worse (-4.15%) after applying the patch. However,
one positive signal is that the minimum latency is 23.159, which is
lower than without the change (24.017).
For seccomp, the results indicate a benefit (2.98%) from the change.
Hope this is helpful for maintainers to judge the change.
I'd leave maintainers to review the code.
Thanks,
Leo
next prev parent reply other threads:[~2026-02-20 12:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-20 9:09 [PATCH 0/3] use runtime constant to optimize handle_arch_irq access Jisheng Zhang
2026-02-20 9:09 ` [PATCH 1/3] vmlinux.lds.h: add _handle_arch_irq RUNTIME_CONST section Jisheng Zhang
2026-02-24 2:01 ` Guo Ren
2026-02-20 9:09 ` [PATCH 2/3] genirq: use runtime constant to optimize handle_arch_irq access Jisheng Zhang
2026-02-22 22:06 ` Thomas Gleixner
2026-02-23 12:41 ` Jisheng Zhang
2026-02-23 13:11 ` Mark Rutland
2026-02-23 13:22 ` Jisheng Zhang
2026-02-23 13:55 ` Mark Rutland
2026-02-24 1:40 ` Guo Ren
2026-02-24 1:59 ` Guo Ren
2026-02-20 9:09 ` [PATCH 3/3] arm64: " Jisheng Zhang
2026-02-20 12:34 ` Leo Yan [this message]
2026-02-20 13:16 ` Jisheng Zhang
2026-02-20 13:34 ` Jisheng Zhang
2026-02-20 16:47 ` Leo Yan
2026-02-21 0:14 ` Jisheng Zhang
2026-02-23 9:15 ` Leo Yan
2026-02-25 14:40 ` Jisheng Zhang
2026-02-23 12:56 ` Mark Rutland
2026-02-23 12:58 ` Jisheng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260220123414.GF136967@e132581.arm.com \
--to=leo.yan@arm.com \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=guoren@kernel.org \
--cc=jszhang@kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=tglx@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox