From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 003B3E98DEF for ; Mon, 23 Feb 2026 07:28:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EKvU/PNxjAddR2yAhFrCBL4lcj3bDh4g/P+pXxlhagQ=; b=d4b0YLU4y2z6u1TN+TIp3lhm0D EgTWg4KaQu9kuwFo2YGSrzlQsjZHLPoQhHq0E8Z3WC3v9PM81mFBNXiWpWNtT2gLtKZ7oC/siKAJO lTylrwHzUoF4yYKL7FGOMrfha5fGbBNN6TwTwKKgT/P748LtlcnzGY/Dc1feZ+vpqf6FoMLt1IJql pSL/2ha0qetJIUPuZbwDf5/mJvWXqZ3rrotjWS0h4aJGP6bRgc+DxBKrdwkxD9KivwSI4L+tiew/6 MSgalRLM/k0l+7GORLx1spmbdodbgTayVBbevBoPGtU1/gtFTIqnRfZvyTmugKn2N5OiBUx7WXKdt iR0GUIGg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vuQMP-0000000HMt0-1gso; Mon, 23 Feb 2026 07:28:05 +0000 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vuQMK-0000000HMl9-0uhq for linux-arm-kernel@lists.infradead.org; Mon, 23 Feb 2026 07:28:01 +0000 Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61MNGj8H1776702 for ; Mon, 23 Feb 2026 07:27:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= EKvU/PNxjAddR2yAhFrCBL4lcj3bDh4g/P+pXxlhagQ=; b=imRR7dQaLra0EmG/ CLVgZzMTSjtFjvJGWsatrgZAxI4+8sXNgtBdn1m6ntzrKLeq9IoCDcJaD4E3psOG 6JiFR1sLUNsl4jhyyPcb2jMWdYLw+O8Gba1KrBolfaV1Mxvk3w136p/s1b+JzTPk AU5y09iTzyUYHqPbbUQ2ARe3wymQutpxvg8ec6ZSR6cIjR5XtsDFRnYwDPw4WWF6 5PwoXLBgw9oEHZYTw3BPH/V0UYAFGm340rZH25TN2XM+1m4fs5jNEDnrv4D7ISBZ D17OfkIqZG7l1taNVj1/E6iThifPdwIKFpB3KgEO4A53amQh1OXpdj2h1s2fNJMU fhRdHA== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cf5u9useq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 23 Feb 2026 07:27:59 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-8966c2b187bso488165856d6.2 for ; Sun, 22 Feb 2026 23:27:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771831679; x=1772436479; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=EKvU/PNxjAddR2yAhFrCBL4lcj3bDh4g/P+pXxlhagQ=; b=fxf8Bn5Q+u2VWKNxQgGJ3LdMYGEBS93DetFbDHYswPdYLbeMM6wIkfFQGH4Zww3nJ3 fhaFRu2AHCoSXxVTtEHkklLmCzJWSggMZACaiKDYVxJuAyqvJi2rBTiMM1HO2OKdzdw1 D//ewrP8csT7yM5WYnu4hXNH59/98LgSRS2XLFMar1dS7v1+Jk0B3DoO4zGRR2+NdVN4 jFrNtGUG/M/hVz6KqoKf0fIqrDdY7BexPR6tvBqXBGNcesS1l8ZZCIBSCuFMMGwAw5XW vdX2LId0FXqGmPRnYt9W3ruu4B0FVq6SW8zE9VjydOnLJL6kZ3gVkfaiGy+rdFXXsU4d eJCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771831679; x=1772436479; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=EKvU/PNxjAddR2yAhFrCBL4lcj3bDh4g/P+pXxlhagQ=; b=nD5hSJOr3URmb6LCfANI5+HGk9evJWnCMlUEmfyT0n5Biii3yNqaBWaRZ8tbzEBKjx BtNRyjM6S9qsFmQQZfjRsoheJ6g4OUOw28rTYzEHgs8uTfRCyn343oeLvmb6eJq0jUL6 7swaAw/QNs+enDCssT93nspAbVqRK5kf1+arTpWqhJirFnBlg3eoqRaViLjX8OIZPrNq j+I0RHVlwvNkw1Ea7NRANzjnjOyCh0Z0KavqctLzNAgcEPnFifcjqqdQ8pJlxbsEOFBY DgA2fXQrdOd1xHEgQQjIZr4iejE1k1DciTpbhAKvdMcfoxXng2f4Ga6rK6Z796nDQbaR A1GA== X-Forwarded-Encrypted: i=1; AJvYcCWf7AmvKyKATPJfyurOkUAcznd2bJPtqEE88kaM932SaaYNy2shXufjrpfUZ1MFTqnpOvIvZ8vpNbONMVhz6OOt@lists.infradead.org X-Gm-Message-State: AOJu0Yz0u/+ny0+2/oHrWWpTGu7LMMGaX8QHikLmKahlxqUmBUXT8+tX PJHs8iXWUyS/Xdhh6cbz8LLZQSY71iITNoDeUTJHiWvQ6tNeyC835xYFSSDCgGNnShgyLQTZPkz S3VZMdbvlPbejDzYd8lXqY3Mg9FlaCXomVyA/5sJaAbS3TWNnohwPQmbBM6CRxV9IuVZ/a+tpOp uATw== X-Gm-Gg: AZuq6aL6rl8W6IuwkOKgCiO7SlGwHpnsiDukv/bUKFacVekmNflf98EScCeFVNzGpov dVyexX2tyxGHRb/C+wlmN0G3znDb5fN4Q05NPi6zZ1jwugZ+QVPv/BMNvmzXGoF+cx6ygm77I9s P7Im8GSO5vpxE+K00lMZEMWGs3P0TP5WM0P+LdMvrIUyd690N+sNegqPp4sX0Q7zLwN/Sbujv3i 90VDJcGAvtb+Z+7FbdOEHBIT1gsJLEjZICNENwFkS/Nb0JwZ3ru08Zj0rbTmpPBv8ziPqy0W1IW fVViJEjsT1Aew3u832StjVXnIshFT+spC/KD32Mp0so6GhdcbgSZUQd4Z5xXV+5Uhqrn3VhvM5B hOfCOAwqZUawu697KTzze2JVytPFomHd7cAX7HYCliP1Seg== X-Received: by 2002:a05:620a:bc6:b0:8c2:3f3b:dae8 with SMTP id af79cd13be357-8cb8ca02729mr953887385a.24.1771831678589; Sun, 22 Feb 2026 23:27:58 -0800 (PST) X-Received: by 2002:a05:620a:bc6:b0:8c2:3f3b:dae8 with SMTP id af79cd13be357-8cb8ca02729mr953885685a.24.1771831678191; Sun, 22 Feb 2026 23:27:58 -0800 (PST) Received: from [127.0.1.1] ([178.197.223.140]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43970bf9ff5sm18550286f8f.4.2026.02.22.23.27.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Feb 2026 23:27:57 -0800 (PST) From: Krzysztof Kozlowski Date: Mon, 23 Feb 2026 08:27:35 +0100 Subject: [PATCH 7/9] mfd: ezx-pcap: Return directly instead of empty gotos MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260223-workqueue-devm-v1-7-10b3a6087586@oss.qualcomm.com> References: <20260223-workqueue-devm-v1-0-10b3a6087586@oss.qualcomm.com> In-Reply-To: <20260223-workqueue-devm-v1-0-10b3a6087586@oss.qualcomm.com> To: Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Jonathan Corbet , Shuah Khan , Tejun Heo , Lai Jiangshan , Tobias Schrammm , Sebastian Reichel , Andy Shevchenko , Dan Carpenter , Krzysztof Kozlowski , Lee Jones , Dzmitry Sankouski , Matthias Brugger , AngeloGioacchino Del Regno , Benson Leung , Tzung-Bi Shih Cc: driver-core@lists.linux.dev, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, chrome-platform@lists.linux.dev, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1584; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=ESdCsaeIum29ouwuVQycaCeiYY4yOvrSCQxsV5yQYpU=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpnAFsdVOSZjLWU15fu6tXhkyH5o/JBZijmD+7F xJuktpOs16JAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaZwBbAAKCRDBN2bmhouD 11hqEACQeJWBcnOA0HqzOwEkeI7B9TgL3mN+MiZFvfd+qLHOhNAN5GPqKlAoYXkpu+ggDO0qWz9 oYB5wpEIyViQz6F7P1BbSk7JDPJNPXtSO8eCIPGH1pBauIFXYzYhV8mSvy5NBR7mEMYSKKu6Ki5 c2HHxYRYV34xSMpIrhaZh8QRVvQF+02ORACguJKiqALZysCqUV7Lssv6LmOneLzlHwOmppCNJ2o TB7ZxS4wPCl6edlbVzZrMMFQ1y+DfwdvIux3JU9oT1PriOQ+M1ocC9uh319Y9tCqJGVUBStU4+p SMFlYLPr0BTBAPNFFombh5ZS68gj4DqMJ6Unb/ZrUU/4jkXJNA681W6H59pOUOXo8QIziJ7gdHL yLif6Cex6xL/Ap+5oN2poWDdGsdcuj15yxkdz5lyJyRdBSslo4p7EGLMPzdeqY79LEwoqKafjAa vU3CpssLcVilmqPFQ3SZBwFW06aflTmZkGUbBUB/mUUo7I8VTS3SdhS635sblTp41z5mhW/xy0r vvKapnIZlD9rOw5Xxg19beyLy37OW1z/5cm0mAYucel1XB/13lDUq0v86dixoHMc1KA1qdQC67y qsmaAQwI4e7mlF47O+yr/jaCE6/Z8x6wiysP1jZxhoPdIGKyBILkDL/5cNMwz7/FT78JNlj7SK0 pLo5wqw2dA4WDpg== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjIzMDA2NCBTYWx0ZWRfX9AvDn1xdKu3G 9lTrKXbVUmKmwLjaVyNG0LPie6JSapIBLVDtZGwBoydKpPJ+Koo7UX6nP04p4hq5Bdhtz4wwRwT z7i2dY28l9H7Nvi5zjdNaTOztXojVGSep/o7eYD0Qln+Y8NX5Yd30BX9Fgnp5+mjDQiLG/JgIVZ MQT+ioGRZFYnwzsT6/vTAoKxqya6Ore2YV9aavY8e5BpoFAi55dot+gLJeIeff+AxyV7MxxmjLW YgKwWh0Eka/GvNizhpWbyEFy1eE03mgSeLOWOSh179GLm8pUVcO+Mix47KLw4/WIy8bkeXlRrS3 oyHNkkWljNJBHxuluxzUyfb3UFvFbQGD65TVljhZ2syGAzD4ywd6xb9vMmjZ3A69tyhzs/3XaYE Bxzv7IcoprrTiz25um59AKcKnPXt6GNtdCQBm4+tqrT+BZANECp1U8j4gLw+TCWnpSEiZBbBLnr 0d7l6PKzz9rQBfTMEAw== X-Proofpoint-GUID: GnEodNuuEhlY5kNSdtUKn8CuP_Clypdq X-Proofpoint-ORIG-GUID: GnEodNuuEhlY5kNSdtUKn8CuP_Clypdq X-Authority-Analysis: v=2.4 cv=RpDI7SmK c=1 sm=1 tr=0 ts=699c017f cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=6nO30s3o7FuWeffXwhKHTA==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=VGyNsPSQNFFz0_f43M8A:9 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-23_01,2026-02-20_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 adultscore=0 suspectscore=0 clxscore=1015 spamscore=0 bulkscore=0 impostorscore=0 phishscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602230064 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260222_232800_415347_E68846C9 X-CRM114-Status: GOOD ( 17.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Code is easier to read if empty error paths simply return, instead of jumping to empty label doing only "return ret". Signed-off-by: Krzysztof Kozlowski --- drivers/mfd/ezx-pcap.c | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/drivers/mfd/ezx-pcap.c b/drivers/mfd/ezx-pcap.c index 13cb185638a9..b929559d84ae 100644 --- a/drivers/mfd/ezx-pcap.c +++ b/drivers/mfd/ezx-pcap.c @@ -384,17 +384,15 @@ static int ezx_pcap_probe(struct spi_device *spi) struct pcap_platform_data *pdata = dev_get_platdata(&spi->dev); struct pcap_chip *pcap; int i, adc_irq; - int ret = -ENODEV; + int ret; /* platform data is required */ if (!pdata) - goto ret; + return -ENODEV; pcap = devm_kzalloc(&spi->dev, sizeof(*pcap), GFP_KERNEL); - if (!pcap) { - ret = -ENOMEM; - goto ret; - } + if (!pcap) + return -ENOMEM; spin_lock_init(&pcap->io_lock); spin_lock_init(&pcap->adc_lock); @@ -407,17 +405,15 @@ static int ezx_pcap_probe(struct spi_device *spi) spi->mode = SPI_MODE_0 | (pdata->config & PCAP_CS_AH ? SPI_CS_HIGH : 0); ret = spi_setup(spi); if (ret) - goto ret; + return ret; pcap->spi = spi; /* setup irq */ pcap->irq_base = pdata->irq_base; pcap->workqueue = create_singlethread_workqueue("pcapd"); - if (!pcap->workqueue) { - ret = -ENOMEM; - goto ret; - } + if (!pcap->workqueue) + return -ENOMEM; /* redirect interrupts to AP, except adcdone2 */ if (!(pdata->config & PCAP_SECOND_PORT)) -- 2.51.0