Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Cc: Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 Heiko Stuebner <heiko@sntech.de>,
	Detlev Casanova <detlev.casanova@collabora.com>,
	 Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	 Nicolas Dufresne <nicolas.dufresne@collabora.com>,
	Hans Verkuil <hverkuil@kernel.org>,
	kernel@collabora.com,  devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	 linux-rockchip@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	 Conor Dooley <conor.dooley@microchip.com>,
	linux-media@vger.kernel.org
Subject: Re: [PATCH v2 2/3] arm64: dts: rockchip: Fix vdec register blocks order on RK3576
Date: Tue, 24 Feb 2026 08:22:20 +0100	[thread overview]
Message-ID: <20260224-glaring-poetic-goshawk-b44d7b@quoll> (raw)
In-Reply-To: <20260223-vdec-reg-order-rk3576-v2-2-daf4942dfc02@collabora.com>

On Mon, Feb 23, 2026 at 09:49:50PM +0200, Cristian Ciocaltea wrote:
> When building device trees for the RK3576 based boards, DTC shows the
> following complaint:
> 
>   rk3576.dtsi:1282.30-1304.5: Warning (simple_bus_reg): /soc/video-codec@27b00000: simple-bus unit address format error, expected "27b00100"

So you need to fix the unit address. This is what the warning tells you.

> 
> Provide the register blocks in the expected address-based order.
> 
> Fixes: da0de806d8b4 ("arm64: dts: rockchip: Add the vdpu383 Video Decoder on rk3576")
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
> ---
>  arch/arm64/boot/dts/rockchip/rk3576.dtsi | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3576.dtsi b/arch/arm64/boot/dts/rockchip/rk3576.dtsi
> index 49ccdf12ef7e..45eb0d053a6f 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3576.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3576.dtsi
> @@ -1281,10 +1281,10 @@ gpu: gpu@27800000 {
>  
>  		vdec: video-codec@27b00000 {
>  			compatible = "rockchip,rk3576-vdec";
> -			reg = <0x0 0x27b00100 0x0 0x500>,
> -			      <0x0 0x27b00000 0x0 0x100>,
> +			reg = <0x0 0x27b00000 0x0 0x100>,
> +			      <0x0 0x27b00100 0x0 0x500>,
>  			      <0x0 0x27b00600 0x0 0x100>;

The main block, so probably the lowest address as in unit address,
should be used, but this ship has sailed. You shipped this DTS, because
the order of items is FIXED. Your binding change is clearly incorrect
and ABI break without explanation and without reason, so you cannot use
such as an argument here.

You cannot change it without impact, so just fix the unit address.

Best regards,
Krzysztof



  reply	other threads:[~2026-02-24  7:22 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-23 19:49 [PATCH v2 0/3] arm64: dts: rockchip: Fix vdec register blocks order on RK3576/RK3588 Cristian Ciocaltea
2026-02-23 19:49 ` [PATCH v2 1/3] media: dt-bindings: rockchip,vdec: Correct reg-names order for RK35{76,88} Cristian Ciocaltea
2026-02-23 23:05   ` Heiko Stübner
2026-02-24  7:17   ` Krzysztof Kozlowski
2026-02-24 13:14     ` Nicolas Dufresne
2026-02-24 13:17       ` Krzysztof Kozlowski
2026-02-24 13:18       ` Krzysztof Kozlowski
2026-02-24 13:48         ` Nicolas Dufresne
2026-02-24 13:54           ` Krzysztof Kozlowski
2026-02-24 14:07             ` Cristian Ciocaltea
2026-02-24 14:34               ` Krzysztof Kozlowski
2026-02-23 19:49 ` [PATCH v2 2/3] arm64: dts: rockchip: Fix vdec register blocks order on RK3576 Cristian Ciocaltea
2026-02-24  7:22   ` Krzysztof Kozlowski [this message]
2026-02-24 13:17     ` Nicolas Dufresne
2026-02-24 13:20       ` Krzysztof Kozlowski
2026-02-23 19:49 ` [PATCH v2 3/3] arm64: dts: rockchip: Fix vdec register blocks order on RK3588 Cristian Ciocaltea
2026-02-24  7:18   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260224-glaring-poetic-goshawk-b44d7b@quoll \
    --to=krzk@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=conor.dooley@microchip.com \
    --cc=cristian.ciocaltea@collabora.com \
    --cc=detlev.casanova@collabora.com \
    --cc=devicetree@vger.kernel.org \
    --cc=ezequiel@vanguardiasur.com.ar \
    --cc=heiko@sntech.de \
    --cc=hverkuil@kernel.org \
    --cc=kernel@collabora.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mchehab@kernel.org \
    --cc=nicolas.dufresne@collabora.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox