Re: [PATCH v2 4/5] dt-bindings: arm: atmel,at91rm9200-st: convert to DT schema

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2575 bytes --]

On Tue, Feb 24, 2026 at 02:46:49PM +0000, Akhila YS wrote:
> Convert System Timer binding to YAML format.
> 
> Signed-off-by: Akhila YS <akhilayalmati@gmail.com>
> ---
>  .../bindings/arm/atmel,at91rm9200-st.yaml          | 65 ++++++++++++++++++++++
>  1 file changed, 65 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/atmel,at91rm9200-st.yaml b/Documentation/devicetree/bindings/arm/atmel,at91rm9200-st.yaml
> new file mode 100644
> index 000000000000..ff485b37cba8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/atmel,at91rm9200-st.yaml
> @@ -0,0 +1,65 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/atmel,at91rm9200-st.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Atmel System Timer
> +
> +maintainers:
> +  - Nicolas Ferre <nicolas.ferre@microchip.com>
> +  - Claudiu Beznea <claudiu@tuxon.dev>
> +
> +description:
> +  The System Timer (ST) module in AT91RM9200 provides periodic tick and
> +  alarm capabilities. It is exposed as a simple multi-function device
> +  (simple-mfd + syscon) because it shares its register space and interrupt
> +  with other System Controller blocks.
> +
> +properties:
> +  compatible:
> +    items:
> +      - const: atmel,at91rm9200-st
> +      - const: syscon
> +      - const: simple-mfd
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  watchdog:
> +    type: object
> +    description: Watchdog timer subnode.
> +    properties:
> +      compatible:
> +        const: atmel,at91rm9200-wdt
> +    required:
> +      - compatible

This should just be a ref to the binding providing the watchdog.

I am guessing you didn't test this against all bindings, only against
/this/ binding and therefore missed the fact that it doesn't comply with
the binding for the watchdog itself.

> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - clocks
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    timer@fffffd00 {
> +        compatible = "atmel,at91rm9200-st", "syscon", "simple-mfd";
> +        reg = <0xfffffd00 0x100>;
> +        interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>;
> +        clocks = <&slow_xtal>;
> +
> +        watchdog {
> +                compatible = "atmel,at91rm9200-wdt";
> +        };
> +    };
> +...
> 
> -- 
> 2.43.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]