From: Rob Herring <robh@kernel.org>
To: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Cc: Saravana Kannan <saravanak@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>,
"Christophe Leroy (CS GROUP)" <chleroy@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
Chen-Yu Tsai <wens@kernel.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>, Frank Li <Frank.Li@nxp.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev,
linux-renesas-soc@vger.kernel.org, linux-sunxi@lists.linux.dev,
driver-core@lists.linux.dev
Subject: Re: [PATCH v2 8/9] soc: renesas: don't access of_root directly
Date: Tue, 24 Feb 2026 12:32:13 -0600 [thread overview]
Message-ID: <20260224183213.GA3239922-robh@kernel.org> (raw)
In-Reply-To: <20260223-soc-of-root-v2-8-b45da45903c8@oss.qualcomm.com>
On Mon, Feb 23, 2026 at 02:37:23PM +0100, Bartosz Golaszewski wrote:
> Don't access of_root directly as it reduces the build test coverage for
> this driver with COMPILE_TEST=y and OF=n. Use existing helper functions
> to retrieve the relevant information.
>
> Suggested-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
> ---
> drivers/soc/renesas/renesas-soc.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/soc/renesas/renesas-soc.c b/drivers/soc/renesas/renesas-soc.c
> index 38ff0b823bdaf1ba106bfb57ed423158d9103f8d..bd8ba0ac30fa91fcf2a10edd0d58b064650085cf 100644
> --- a/drivers/soc/renesas/renesas-soc.c
> +++ b/drivers/soc/renesas/renesas-soc.c
> @@ -6,6 +6,7 @@
> */
>
> #include <linux/bitfield.h>
> +#include <linux/cleanup.h>
> #include <linux/io.h>
> #include <linux/of.h>
> #include <linux/of_address.h>
> @@ -468,7 +469,11 @@ static int __init renesas_soc_init(void)
> const char *soc_id;
> int ret;
>
> - match = of_match_node(renesas_socs, of_root);
> + struct device_node *root __free(device_node) = of_find_node_by_path("/");
> + if (!root)
> + return -ENOENT;
> +
> + match = of_match_node(renesas_socs, root);
Doesn't of_machine_device_match() work here?
next prev parent reply other threads:[~2026-02-24 18:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-23 13:37 [PATCH v2 0/9] soc: remove direct accesses to of_root from drivers/soc/ Bartosz Golaszewski
2026-02-23 13:37 ` [PATCH v2 1/9] of: provide of_machine_read_compatible() Bartosz Golaszewski
2026-02-23 13:37 ` [PATCH v2 2/9] of: provide of_machine_read_model() Bartosz Golaszewski
2026-02-23 13:37 ` [PATCH v2 3/9] base: soc: order includes alphabetically Bartosz Golaszewski
2026-02-23 13:37 ` [PATCH v2 4/9] base: soc: rename and export soc_device_get_machine() Bartosz Golaszewski
2026-02-23 13:37 ` [PATCH v2 5/9] soc: fsl: guts: don't access of_root directly Bartosz Golaszewski
2026-02-23 13:37 ` [PATCH v2 6/9] soc: imx8m: " Bartosz Golaszewski
2026-02-25 7:55 ` Peng Fan
2026-03-24 10:24 ` Alexander Stein
2026-02-23 13:37 ` [PATCH v2 7/9] soc: imx9: " Bartosz Golaszewski
2026-02-23 13:37 ` [PATCH v2 8/9] soc: renesas: " Bartosz Golaszewski
2026-02-24 18:32 ` Rob Herring [this message]
2026-02-25 9:42 ` Bartosz Golaszewski
2026-02-25 21:47 ` Rob Herring
2026-03-02 16:32 ` Geert Uytterhoeven
2026-03-02 17:18 ` Bartosz Golaszewski
2026-02-23 13:37 ` [PATCH v2 9/9] soc: sunxi: mbus: " Bartosz Golaszewski
2026-02-24 18:38 ` [PATCH v2 0/9] soc: remove direct accesses to of_root from drivers/soc/ Rob Herring
2026-02-26 9:28 ` Bartosz Golaszewski
2026-03-12 15:18 ` Greg Kroah-Hartman
2026-03-13 8:36 ` Bartosz Golaszewski
2026-03-13 9:22 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260224183213.GA3239922-robh@kernel.org \
--to=robh@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=chleroy@kernel.org \
--cc=dakr@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=driver-core@lists.linux.dev \
--cc=festevam@gmail.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=imx@lists.linux.dev \
--cc=jernej.skrabec@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=magnus.damm@gmail.com \
--cc=rafael@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=samuel@sholland.org \
--cc=saravanak@kernel.org \
--cc=shawnguo@kernel.org \
--cc=wens@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox