From: Leo Yan <leo.yan@arm.com>
To: Mike Leach <Mike.Leach@arm.com>
Cc: Suzuki Poulose <Suzuki.Poulose@arm.com>,
James Clark <james.clark@linaro.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Tingwei Zhang <quic_tingwei@quicinc.com>,
Yingchao Deng <yingchao.deng@oss.qualcomm.com>,
Jie Gan <jie.gan@oss.qualcomm.com>,
"coresight@lists.linaro.org" <coresight@lists.linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
nd <nd@arm.com>
Subject: Re: [PATCH 7/8] coresight: cti: Remove hw_enabled flag
Date: Wed, 25 Feb 2026 16:02:31 +0000 [thread overview]
Message-ID: <20260225160231.GE4184494@e132581.arm.com> (raw)
In-Reply-To: <PAVPR08MB9674FF028BD91B6DDF5B035A8C68A@PAVPR08MB9674.eurprd08.prod.outlook.com>
Hi Mike,
On Fri, Feb 20, 2026 at 02:31:11PM +0000, Mike Leach wrote:
[...]
> > The enable_req_count field already tracks whether the CTI device is
> > enabled. A non-zero value indicates that the device is active, the
> > hw_enabled flag is redundant if so.
> >
>
> Minor nit - removal of this flag actually started in the previous patch.
> If respinning might be worth combining this and the previous one.
In the new version, I will keep separate patches for removing the
hw_enabled and hw_powered flags, as they are two different things.
This would be easier to review and friendly for bisection.
I will take your suggestion in patch 08.
Thanks,
Leo
next prev parent reply other threads:[~2026-02-25 16:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-09 18:01 [PATCH 0/8] coresight: cti: Miscellaneous fixes and CPU PM cleanup Leo Yan
2026-02-09 18:01 ` [PATCH 1/8] coresight: cti: Make spinlock usage consistent Leo Yan
2026-02-19 16:58 ` Mike Leach
2026-02-09 18:01 ` [PATCH 2/8] coresight: cti: Fix register reads Leo Yan
2026-02-20 8:10 ` Mike Leach
2026-02-09 18:01 ` [PATCH 3/8] coresight: cti: Access ASICCTL only when implemented Leo Yan
2026-02-20 8:16 ` Mike Leach
2026-02-09 18:01 ` [PATCH 4/8] coresight: cti: Remove CPU power management code Leo Yan
2026-02-20 13:19 ` Mike Leach
2026-02-09 18:01 ` [PATCH 5/8] coresight: cti: Rename cti_active() to cti_is_active() Leo Yan
2026-02-20 13:47 ` Mike Leach
2026-02-09 18:01 ` [PATCH 6/8] coresight: cti: Remove hw_powered flag Leo Yan
2026-02-20 14:25 ` Mike Leach
2026-02-09 18:01 ` [PATCH 7/8] coresight: cti: Remove hw_enabled flag Leo Yan
2026-02-20 14:31 ` Mike Leach
2026-02-25 16:02 ` Leo Yan [this message]
2026-02-09 18:01 ` [PATCH 8/8] coresight: cti: Refactor cti_reg32_{show|store}() Leo Yan
2026-02-20 14:44 ` Mike Leach
2026-02-20 17:35 ` Leo Yan
2026-02-25 13:48 ` Mike Leach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260225160231.GE4184494@e132581.arm.com \
--to=leo.yan@arm.com \
--cc=Mike.Leach@arm.com \
--cc=Suzuki.Poulose@arm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=coresight@lists.linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=james.clark@linaro.org \
--cc=jie.gan@oss.qualcomm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=nd@arm.com \
--cc=quic_tingwei@quicinc.com \
--cc=yingchao.deng@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox