public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: rockchip: Fix sdmmc pwren pinctrl for rk3576-evb2
@ 2026-02-26 10:20 Chaoyi Chen
  2026-02-26 11:24 ` Andy Yan
  2026-03-02 11:39 ` [PATCH] " Heiko Stuebner
  0 siblings, 2 replies; 3+ messages in thread
From: Chaoyi Chen @ 2026-02-26 10:20 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
	Alexey Charkov, Shawn Lin, Chaoyi Chen, Andy Yan,
	Sebastian Reichel
  Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel

From: Chaoyi Chen <chaoyi.chen@rock-chips.com>

In rk3576.dtsi, sdmmc0_pwren is configured as part of the sdmmc pinctrl.
However, on the rk3576 evb2 board, sdmmc0_pwren is used as the regulator
for vmmc-supply. Therefore, we need to reassign the sdmmc pinctrl and
remove sdmmc0_pwren to avoid conflicts.

Cc: Shawn Lin <shawn.lin@rock-chips.com>
Fixes: 86a82f7a7eed ("arm64: dts: rockchip: Add rk3576 evb2 board")
Signed-off-by: Chaoyi Chen <chaoyi.chen@rock-chips.com>
---
 arch/arm64/boot/dts/rockchip/rk3576-evb2-v10.dts | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3576-evb2-v10.dts b/arch/arm64/boot/dts/rockchip/rk3576-evb2-v10.dts
index 6bdc232ab267..98d5d00d63b5 100644
--- a/arch/arm64/boot/dts/rockchip/rk3576-evb2-v10.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3576-evb2-v10.dts
@@ -951,6 +951,8 @@ &sdmmc {
 	disable-wp;
 	no-sdio;
 	no-mmc;
+	pinctrl-names = "default";
+	pinctrl-0 = <&sdmmc0_clk &sdmmc0_cmd &sdmmc0_det &sdmmc0_bus4>;
 	sd-uhs-sdr104;
 	vmmc-supply = <&vcc3v3_sd>;
 	vqmmc-supply = <&vccio_sd_s0>;
-- 
2.51.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re:[PATCH] arm64: dts: rockchip: Fix sdmmc pwren pinctrl for rk3576-evb2
  2026-02-26 10:20 [PATCH] arm64: dts: rockchip: Fix sdmmc pwren pinctrl for rk3576-evb2 Chaoyi Chen
@ 2026-02-26 11:24 ` Andy Yan
  2026-03-02 11:39 ` [PATCH] " Heiko Stuebner
  1 sibling, 0 replies; 3+ messages in thread
From: Andy Yan @ 2026-02-26 11:24 UTC (permalink / raw)
  To: Chaoyi Chen
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
	Alexey Charkov, Shawn Lin, Chaoyi Chen, Andy Yan,
	Sebastian Reichel, devicetree, linux-arm-kernel, linux-rockchip,
	linux-kernel


Hello,

At 2026-02-26 18:20:52, "Chaoyi Chen" <kernel@airkyi.com> wrote:
>From: Chaoyi Chen <chaoyi.chen@rock-chips.com>
>
>In rk3576.dtsi, sdmmc0_pwren is configured as part of the sdmmc pinctrl.
>However, on the rk3576 evb2 board, sdmmc0_pwren is used as the regulator
>for vmmc-supply. Therefore, we need to reassign the sdmmc pinctrl and
>remove sdmmc0_pwren to avoid conflicts.
>
>Cc: Shawn Lin <shawn.lin@rock-chips.com>
>Fixes: 86a82f7a7eed ("arm64: dts: rockchip: Add rk3576 evb2 board")
>Signed-off-by: Chaoyi Chen <chaoyi.chen@rock-chips.com>
   Tested-by: Andy Yan <andy.yan@163.com>


>---
> arch/arm64/boot/dts/rockchip/rk3576-evb2-v10.dts | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/arch/arm64/boot/dts/rockchip/rk3576-evb2-v10.dts b/arch/arm64/boot/dts/rockchip/rk3576-evb2-v10.dts
>index 6bdc232ab267..98d5d00d63b5 100644
>--- a/arch/arm64/boot/dts/rockchip/rk3576-evb2-v10.dts
>+++ b/arch/arm64/boot/dts/rockchip/rk3576-evb2-v10.dts
>@@ -951,6 +951,8 @@ &sdmmc {
> 	disable-wp;
> 	no-sdio;
> 	no-mmc;
>+	pinctrl-names = "default";
>+	pinctrl-0 = <&sdmmc0_clk &sdmmc0_cmd &sdmmc0_det &sdmmc0_bus4>;
> 	sd-uhs-sdr104;
> 	vmmc-supply = <&vcc3v3_sd>;
> 	vqmmc-supply = <&vccio_sd_s0>;
>-- 
>2.51.1
>
>
>_______________________________________________
>Linux-rockchip mailing list
>Linux-rockchip@lists.infradead.org
>http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: rockchip: Fix sdmmc pwren pinctrl for rk3576-evb2
  2026-02-26 10:20 [PATCH] arm64: dts: rockchip: Fix sdmmc pwren pinctrl for rk3576-evb2 Chaoyi Chen
  2026-02-26 11:24 ` Andy Yan
@ 2026-03-02 11:39 ` Heiko Stuebner
  1 sibling, 0 replies; 3+ messages in thread
From: Heiko Stuebner @ 2026-03-02 11:39 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alexey Charkov,
	Shawn Lin, Chaoyi Chen, Andy Yan, Sebastian Reichel, Chaoyi Chen
  Cc: Heiko Stuebner, devicetree, linux-arm-kernel, linux-rockchip,
	linux-kernel


On Thu, 26 Feb 2026 18:20:52 +0800, Chaoyi Chen wrote:
> In rk3576.dtsi, sdmmc0_pwren is configured as part of the sdmmc pinctrl.
> However, on the rk3576 evb2 board, sdmmc0_pwren is used as the regulator
> for vmmc-supply. Therefore, we need to reassign the sdmmc pinctrl and
> remove sdmmc0_pwren to avoid conflicts.
> 
> 

Applied, thanks!

[1/1] arm64: dts: rockchip: Fix sdmmc pwren pinctrl for rk3576-evb2
      commit: 7d939032bd7e203e1c907a8c35e3672eeee08246

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-03-02 11:40 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-26 10:20 [PATCH] arm64: dts: rockchip: Fix sdmmc pwren pinctrl for rk3576-evb2 Chaoyi Chen
2026-02-26 11:24 ` Andy Yan
2026-03-02 11:39 ` [PATCH] " Heiko Stuebner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox