Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Xueyuan Chen <xueyuan.chen21@gmail.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
	Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 Peter Chen <peter.chen@cixtech.com>,
	Fugang Duan <fugang.duan@cixtech.com>,
	 Gary Yang <gary.yang@cixtech.com>,
	 CIX Linux Kernel Upstream Group
	<cix-kernel-upstream@cixtech.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	 linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 3/3] arm64: dts: cix: add src syscon nodes for sky1 resets
Date: Sun, 1 Mar 2026 12:05:27 +0100	[thread overview]
Message-ID: <20260301-neat-thistle-terrier-ab2885@quoll> (raw)
In-Reply-To: <20260301070910.6169-4-xueyuan.chen21@gmail.com>

On Sun, Mar 01, 2026 at 03:09:10PM +0800, Xueyuan Chen wrote:
> Add the SRC blocks for the CIX Sky1 SoC. These blocks
> provide reset capabilities to various peripherals across
> the S0 and S5 domain.
> 
> Signed-off-by: Gary Yang <gary.yang@cixtech.com>
> [Xueyuan Chen: Refactored to pure syscon nodes to fix v3 review issues]

v3? We are at v9!

> Signed-off-by: Xueyuan Chen <xueyuan.chen21@gmail.com>
> ---
>  arch/arm64/boot/dts/cix/sky1.dtsi | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/cix/sky1.dtsi b/arch/arm64/boot/dts/cix/sky1.dtsi
> index fb8c826bbc97..6ad5dc368a66 100644
> --- a/arch/arm64/boot/dts/cix/sky1.dtsi
> +++ b/arch/arm64/boot/dts/cix/sky1.dtsi
> @@ -348,6 +348,12 @@ i3c1: i3c@4100000 {
>  			status = "disabled";
>  		};
>  
> +		src_fch: reset-controller@4160000 {

Random set of changes without any explanation.

> +			compatible = "cix,sky1-src-fch", "syscon";
> +			reg = <0x0 0x04160000 0x0 0x90>;

And here...

Best regards,
Krzysztof



      reply	other threads:[~2026-03-01 11:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-01  7:09 [PATCH v4 0/3] reset: cix: add support for cix sky1 resets Xueyuan Chen
2026-03-01  7:09 ` [PATCH v4 1/3] dt-bindings: reset: add sky1 reset controller Xueyuan Chen
2026-03-01 11:04   ` Krzysztof Kozlowski
2026-03-01 13:13   ` 回复: " Gary Yang
2026-03-01  7:09 ` [PATCH v4 2/3] reset: cix: add support for cix sky1 resets Xueyuan Chen
2026-03-01  7:09 ` [PATCH v4 3/3] arm64: dts: cix: add src syscon nodes for " Xueyuan Chen
2026-03-01 11:05   ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260301-neat-thistle-terrier-ab2885@quoll \
    --to=krzk@kernel.org \
    --cc=cix-kernel-upstream@cixtech.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=fugang.duan@cixtech.com \
    --cc=gary.yang@cixtech.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=peter.chen@cixtech.com \
    --cc=robh@kernel.org \
    --cc=xueyuan.chen21@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox