From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2D2F0FD0049 for ; Sun, 1 Mar 2026 01:31:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=4oCUIAuUuSHOQPMmM0+8772q9CJB6QKtvTSB9DF7O3E=; b=N81xbVKJnDNPyHXPTQLcTm3j+g JjnzjVfSu0X8i9eq1VZB6hXk3zJcgbrmdu2MMd9tdlqPS8rbv4ObDJ2RxxzKScbvRWcPdS7PJXzra 0fOOduVJGBv7TbpxaAK6Vrv+YVu6yyvxW//LbHQOS1G6X09bUvd01vDVbatGCixG+fDc39LYkgDV2 aeILi50pjdlHoBLRpKKXQA16v9uhlNkAtXcvIZ4OxbT8F6Rpo82z6hqsZeRjsN5+scTuQIbuquPKV BwOTIfnFRN+QhwKhlJ9dVdN1zWx1QnCrUEns7Y5HyWKHP8R87heJjAh8G0Jb5zb5zK4a4tGCXoB6R ujsHNCTw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vwVe6-0000000AXtt-1qNS; Sun, 01 Mar 2026 01:30:58 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vwVe1-0000000AXqk-3rl3; Sun, 01 Mar 2026 01:30:54 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 611A660123; Sun, 1 Mar 2026 01:30:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 55FD2C19421; Sun, 1 Mar 2026 01:30:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772328653; bh=K1m+6FBJdr8JQKayLF3Q9xXI9VfQt/l0paMkPPxbuAM=; h=From:To:Cc:Subject:Date:From; b=mgzVHEWTzpmKld2+rLelDy5q0x5XJtXafMqrWpWq0QiRDmoRif6B9FlYg5li8OD2o 4Ov6KiqUo4YBzlT/eDVBElnJlHqCO/fK3awzKRAwNgyB2N2R6MD0fFIY88fzKz6NrG 0MmnTw35IXRFLKg9tyG4Dn4YTuMyJQPl8mAyocIRw8qEkpJQ6a6u1YQ5Mrc9tFsy4w 6JsPkhajtqH5zBnKLdnSyVimUNPSV5/yiESn12gd+oIt/3bgg4apEQjGuKvF9nwgUw 0+PCjxzLM620zinmWFxSrcMzxkofjX+c7GRwE+h8AOKs9wAmIsrvLoKfnS/iosyq7J 8X73/MhqmHMMA== From: Sasha Levin To: stable@vger.kernel.org, haoxiang_li2024@163.com Cc: Nicolas Dufresne , Hans Verkuil , linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: FAILED: Patch "media: mtk-mdp: Fix error handling in probe function" failed to apply to 6.6-stable tree Date: Sat, 28 Feb 2026 20:30:50 -0500 Message-ID: <20260301013051.1689178-1-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 X-Patchwork-Hint: ignore X-stable: review Content-Transfer-Encoding: 8bit X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The patch below does not apply to the 6.6-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . Thanks, Sasha ------------------ original commit in Linus's tree ------------------ >From 8a8a3232abac5b972058a5f2cb3e33199d2a8648 Mon Sep 17 00:00:00 2001 From: Haoxiang Li Date: Wed, 8 Oct 2025 16:55:03 +0800 Subject: [PATCH] media: mtk-mdp: Fix error handling in probe function Add mtk_mdp_unregister_m2m_device() on the error handling path to prevent resource leak. Add check for the return value of vpu_get_plat_device() to prevent null pointer dereference. And vpu_get_plat_device() increases the reference count of the returned platform device. Add platform_device_put() to prevent reference leak. Fixes: c8eb2d7e8202 ("[media] media: Add Mediatek MDP Driver") Cc: stable@vger.kernel.org Signed-off-by: Haoxiang Li Signed-off-by: Nicolas Dufresne Signed-off-by: Hans Verkuil --- .../media/platform/mediatek/mdp/mtk_mdp_core.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/mediatek/mdp/mtk_mdp_core.c b/drivers/media/platform/mediatek/mdp/mtk_mdp_core.c index 80fdc6ff57e0e..f78fa30f18648 100644 --- a/drivers/media/platform/mediatek/mdp/mtk_mdp_core.c +++ b/drivers/media/platform/mediatek/mdp/mtk_mdp_core.c @@ -194,11 +194,17 @@ static int mtk_mdp_probe(struct platform_device *pdev) } mdp->vpu_dev = vpu_get_plat_device(pdev); + if (!mdp->vpu_dev) { + dev_err(&pdev->dev, "Failed to get vpu device\n"); + ret = -ENODEV; + goto err_vpu_get_dev; + } + ret = vpu_wdt_reg_handler(mdp->vpu_dev, mtk_mdp_reset_handler, mdp, VPU_RST_MDP); if (ret) { dev_err(&pdev->dev, "Failed to register reset handler\n"); - goto err_m2m_register; + goto err_reg_handler; } platform_set_drvdata(pdev, mdp); @@ -206,7 +212,7 @@ static int mtk_mdp_probe(struct platform_device *pdev) ret = vb2_dma_contig_set_max_seg_size(&pdev->dev, DMA_BIT_MASK(32)); if (ret) { dev_err(&pdev->dev, "Failed to set vb2 dma mag seg size\n"); - goto err_m2m_register; + goto err_reg_handler; } pm_runtime_enable(dev); @@ -214,6 +220,12 @@ static int mtk_mdp_probe(struct platform_device *pdev) return 0; +err_reg_handler: + platform_device_put(mdp->vpu_dev); + +err_vpu_get_dev: + mtk_mdp_unregister_m2m_device(mdp); + err_m2m_register: v4l2_device_unregister(&mdp->v4l2_dev); -- 2.51.0