From: Leo Yan <leo.yan@arm.com>
To: Elsanti <santiagojoseleal27@gmail.com>
Cc: suzuki.poulose@arm.com, mike.leach@linaro.org,
james.clark@linaro.org, alexander.shishkin@linux.intel.com,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/hwtracing/coresight: remove unneeded variable in tmc_crashdata_release()
Date: Mon, 2 Mar 2026 09:08:35 +0000 [thread overview]
Message-ID: <20260302090835.GD1098637@e132581.arm.com> (raw)
In-Reply-To: <20260228222344.288639-1-santiagojoseleal27@gmail.com>
On Sat, Feb 28, 2026 at 06:23:44PM -0400, Elsanti wrote:
> The variable 'ret' is initialized to 0, never modified, and returned
> directly. Remove it and return 0 explicitly.
>
> Signed-off-by: Elsanti <santiagojoseleal27@gmail.com>
Reviewed-by: Leo Yan <leo.yan@arm.com>
> ---
> drivers/hwtracing/coresight/coresight-tmc-core.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-tmc-core.c b/drivers/hwtracing/coresight/coresight-tmc-core.c
> index 36599c431be6..e29012c451c5 100644
> --- a/drivers/hwtracing/coresight/coresight-tmc-core.c
> +++ b/drivers/hwtracing/coresight/coresight-tmc-core.c
> @@ -401,7 +401,6 @@ static ssize_t tmc_crashdata_read(struct file *file, char __user *data,
>
> static int tmc_crashdata_release(struct inode *inode, struct file *file)
> {
> - int ret = 0;
> unsigned long flags;
> struct tmc_resrv_buf *rbuf;
> struct tmc_drvdata *drvdata = container_of(file->private_data,
> @@ -414,7 +413,7 @@ static int tmc_crashdata_release(struct inode *inode, struct file *file)
> raw_spin_unlock_irqrestore(&drvdata->spinlock, flags);
>
> dev_dbg(&drvdata->csdev->dev, "%s: released\n", __func__);
> - return ret;
> + return 0;
> }
>
> static const struct file_operations tmc_crashdata_fops = {
> --
> 2.53.0
>
>
next prev parent reply other threads:[~2026-03-02 9:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-28 22:23 [PATCH] drivers/hwtracing/coresight: remove unneeded variable in tmc_crashdata_release() Elsanti
2026-03-02 9:08 ` Leo Yan [this message]
2026-03-02 9:24 ` Suzuki K Poulose
-- strict thread matches above, loose matches on Subject: below --
2026-02-27 23:33 Elsanti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260302090835.GD1098637@e132581.arm.com \
--to=leo.yan@arm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=coresight@lists.linaro.org \
--cc=james.clark@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.leach@linaro.org \
--cc=santiagojoseleal27@gmail.com \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox