Re: [PATCH 2/6] dt-bindings: remoteproc: k3-r5f: Add memory-region-names

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2247 bytes --]

On Tue, Mar 03, 2026 at 06:31:56PM +0000, Conor Dooley wrote:
> On Tue, Mar 03, 2026 at 04:13:00PM +0100, Markus Schneider-Pargmann (TI) wrote:
> > Add names to the memory-region-names for easier idenfitication of memory
> > regions.
> > 
> > Signed-off-by: Markus Schneider-Pargmann (TI) <msp@baylibre.com>
> > ---
> >  .../bindings/remoteproc/ti,k3-r5f-rproc.yaml          | 19 +++++++++++++++++++
> >  1 file changed, 19 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml
> > index 6aadc61e20f9f4c27f5b9c87ab2025a02776c5de..76ef23afe8c9f7f155dfec7fcabc7c60b8b286c6 100644
> > --- a/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml
> > +++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml
> > @@ -182,6 +182,25 @@ patternProperties:
> >            - description: DM RM/PM trace and firmware code/data
> >          additionalItems: true
> >  
> > +      memory-region-names:
> > +        description: |
> > +          Optional names for the memory regions specified in the memory-region
> 
> Is this really optional? Shouldn't it be made mandatory so that it is
> easy to tell the difference between the two configurations?

Actually, so that you can tell at all, since it looks like anything from
2 to 8 regions is permitted (which this prop doesn't account for I guess,
only allowing 2 or 6 regions).

> 
> > +          property.
> > +        oneOf:
> > +          - description: Basic configuration with DMA and firmware regions
> > +            items:
> > +              - const: dma
> > +              - const: firmware
> > +
> > +          - description: Extended LPM configuration with split memory regions
> > +            items:
> > +              - const: dma
> > +              - const: ipc
> > +              - const: lpm-stub
> > +              - const: lpm-metadata
> > +              - const: lpm-context
> > +              - const: dm-firmware
> > +
> >  # Optional properties:
> >  # --------------------
> >  # The following properties are optional properties for each of the R5F cores:
> > 
> > -- 
> > 2.51.0
> > 



[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]