Re: [PATCH 2/2] arm64: dts: exynos: add initial support for samsung-j5y17lte

[Krzysztof Kozlowski <krzk@kernel.org>]

On Wed, Mar 04, 2026 at 10:56:54PM +0530, Kaustabh Chakraborty wrote:
> From: Andras Sebok <sebokandris2009@gmail.com>
> 
> Add initial devicetree support for samsung-j5y17lte (exynos7870)
> 
> Signed-off-by: Andras Sebok <sebokandris2009@gmail.com>
> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
> ---
>  arch/arm64/boot/dts/exynos/Makefile                |   1 +
>  arch/arm64/boot/dts/exynos/exynos7870-j5y17lte.dts | 528 +++++++++++++++++++++
>  2 files changed, 529 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/exynos/Makefile b/arch/arm64/boot/dts/exynos/Makefile
> index fa6e6308e30a9..76cc23acb9b29 100644
> --- a/arch/arm64/boot/dts/exynos/Makefile
> +++ b/arch/arm64/boot/dts/exynos/Makefile
> @@ -8,6 +8,7 @@ dtb-$(CONFIG_ARCH_EXYNOS) += \
>  	exynos5433-tm2e.dtb		\
>  	exynos7-espresso.dtb		\
>  	exynos7870-a2corelte.dtb	\
> +	exynos7870-j5y17lte.dtb		\
>  	exynos7870-j6lte.dtb		\
>  	exynos7870-j7xelte.dtb		\
>  	exynos7870-on7xelte.dtb		\
> diff --git a/arch/arm64/boot/dts/exynos/exynos7870-j5y17lte.dts b/arch/arm64/boot/dts/exynos/exynos7870-j5y17lte.dts
> new file mode 100644
> index 0000000000000..d685bc0703cff
> --- /dev/null
> +++ b/arch/arm64/boot/dts/exynos/exynos7870-j5y17lte.dts
> @@ -0,0 +1,528 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Samsung Galaxy J5 (2017) (j5y17lte) device tree source
> + *
> + * Copyright (c) 2024 Andras Sebok <sebokandris2009@gmail.com>
> + */
> +
> +/dts-v1/;
> +#include "exynos7870.dtsi"
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/input/input.h>
> +#include <dt-bindings/interrupt-controller/irq.h>

These are ordered by name so interrupt < input.

> +
> +/ {
> +	model = "Samsung Galaxy J5 (2017)";
> +	compatible = "samsung,j5y17lte", "samsung,exynos7870";
> +	chassis-type = "handset";
> +
> +	aliases {
> +		mmc0 = &mmc0;
> +		mmc1 = &mmc1;
> +		mmc2 = &mmc2;
> +		serial0 = &serial0;
> +		serial1 = &serial1;
> +		serial2 = &serial2;
> +	};
> +
> +	chosen {
> +		#address-cells = <2>;
> +		#size-cells = <1>;
> +		ranges;
> +
> +		stdout-path = &serial2;
> +
> +		framebuffer@67000000 {
> +			compatible = "simple-framebuffer";
> +			reg = <0x0 0x67000000 (720 * 1280 * 4)>;
> +			width = <720>;
> +			height = <1280>;
> +			stride = <(720 * 4)>;
> +			format = "a8r8g8b8";
> +		};
> +	};
> +
> +	gpio-keys {
> +		compatible = "gpio-keys";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&key_power &key_voldown &key_volup>;
> +
> +		key-home {
> +			interrupt-parent = <&gpa1>;
> +			linux,code = <KEY_HOMEPAGE>;
> +			label = "gpio-keys: KEY_HOMEPAGE";
> +			gpios = <&gpa1 7 GPIO_ACTIVE_LOW>;
> +		};
> +
> +		key-power {
> +			interrupt-parent = <&gpa0>;
> +			linux,code = <KEY_POWER>;
> +			label = "gpio-keys: KEY_POWER";
> +			gpios = <&gpa0 0 GPIO_ACTIVE_LOW>;
> +		};
> +
> +		key-voldown {
> +			interrupt-parent = <&gpa2>;
> +			linux,code = <KEY_VOLUMEDOWN>;
> +			label = "gpio-keys: KEY_VOLUMEDOWN";
> +			gpios = <&gpa2 1 GPIO_ACTIVE_LOW>;
> +		};
> +
> +		key-volup {
> +			interrupt-parent = <&gpa2>;
> +			linux,code = <KEY_VOLUMEUP>;
> +			label = "gpio-keys: KEY_VOLUMEUP";
> +			gpios = <&gpa2 0 GPIO_ACTIVE_LOW>;
> +		};
> +	};
> +
> +	memory@40000000 {
> +		device_type = "memory";
> +		reg = <0x0 0x40000000 0x3e400000>,
> +		      <0x0 0x80000000 0x40000000>;
> +	};
> +
> +	pwrseq_mmc1: pwrseq-mmc1 {
> +		compatible = "mmc-pwrseq-simple";
> +		reset-gpios = <&gpd3 6 GPIO_ACTIVE_LOW>;
> +	};
> +
> +	vdd_fixed_mmc2: regulator-fixed-mmc2 {

And this should be regulator-1 or regulator-xvx (see bindings).

No need to resend for these.

Best regards,
Krzysztof