From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5E97CEEF30A for ; Thu, 5 Mar 2026 06:12:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=aJ65cMxmtD9hm2QF0vSs9PHPLSm4kdpoTVF35SUjEBw=; b=JYCm3Uh1ngFoFhbsRBrqVTMek9 g6KzI/A1KzTrYmw2F2x1D6PhWMfju564yPb/9KIPmsWyS+wATS7SzTO/VpMun+X0fhOJxbnDb/+6k KdwCU9Us3QZJcFcpvzemdEML5xsrbyMojGtakgfoyARokcku9GRTDkr+IS7EmqtEVR3Xw79GkmIuj eb8CamZ6GOXQpyr8DsPvNZaYcIXAT62N9qGBXG2iiSwpBFywB58EU5RQMFj3f8TltNb03Upwle8f4 AJoXUUq/HraJ9eeY5XZ/JpuJvm2VLYDpUAvnXa/yS8yMVKTPbGZKZ/dO0FW+iojl2P38jAQwGFDbj y+r8ZuzQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vy1wJ-00000000ybT-3Osr; Thu, 05 Mar 2026 06:12:03 +0000 Received: from mail-ej1-x62d.google.com ([2a00:1450:4864:20::62d]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vy1wF-00000000yXW-28Nq for linux-arm-kernel@lists.infradead.org; Thu, 05 Mar 2026 06:12:00 +0000 Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-b93698bb57aso661583566b.0 for ; Wed, 04 Mar 2026 22:11:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772691118; x=1773295918; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=aJ65cMxmtD9hm2QF0vSs9PHPLSm4kdpoTVF35SUjEBw=; b=lyI6BAUAaVcpTATXCGGRIHoXZWty1+if2SYr9ZNKimZbdcz1/Fdwoy4cV7vZtpJAhS 9r8d08g3F2LpSabancFiSKiRO05f4yeZruiry2AaTKyYuDgkRJJK3UoxMjI6djNHheZP GbdBdh0PCB1zKcbAoeiQ3W+1n9CP/mTyVXtW3nh90Ov42WsPjBvu1CkOYCGD82ZEbhhN MPZSfGnGQzBrk/1aZCQYTmGDxakYWa1eAqFbbvcXkvf2TZTGLggEPKVBX+VRGmvgzGst 2hMZ2VIjgTKiaFn2ETIhVeR5u9FqwuPzkNf5fJyZ24jqLNzdlvVJIlYhd9DSaXBAqGDA 41HQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772691118; x=1773295918; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=aJ65cMxmtD9hm2QF0vSs9PHPLSm4kdpoTVF35SUjEBw=; b=EXGfeRbFSJlfO031QtrT1UiNuHXhjprT6++I8Og5f/N55dU8IN3X4gc/446/qqLhv+ vPcLYDyV0SJSEsI+wwp00YZWmaKalzsyGljd6XRYuyY6Ty0+k7gCjndfY1O35th85qoq eKC4EmCNCE13ML2VZiu4jpGG/xa9ME82AKF82gO08FBv2zOuHx2v9158mGpiqJN7IrFU WA52JTB1qJnW4uUgJdU8TOd63BysqMoJOt6DwoTp0E8WMPqNE3STVaNFV2nQUIUwtD6Y WtaHkv7uzMdKTom1lPHzKElLnUaA4El//J5yPbuKwj1mWHbfsIH/EaSqwwz7Vm1cRWdC a7PA== X-Forwarded-Encrypted: i=1; AJvYcCUE0DKKPbxDyXM6e3eTBV6e88MVVrP3wi4RnCtTQccT+hphk/dm0ku8FwW6y0U4WOc8hszdrXFLbBetv1x1klFo@lists.infradead.org X-Gm-Message-State: AOJu0YzwDvl7+36pb5E2WpAhEORYlchdVuGSypZ2YmtaRnNGky5nGWN4 ruzWlApMnuFaarWJhv9dtJp2O0qH5swbqUv3NlQwsMJjp7imYlTxEGNu9nAzqVMmk6g= X-Gm-Gg: ATEYQzyXBHafIFPCeMhlUwfh6zMuDFAVTfGlFPS+Cf3U41YgL+w6uXE8Bn3VUIdqb9Q LcCfxiz3wqbx6XIcIeBJBrWbPMa6oHzap80rAkQIdQYwyXm3YztQ7qdVi65EiHyU0O5xni4pfcd wjECIECEOibxMvbh/FotWRE36MXp2nrKgy1AThQfA/e1ytscwAlL3rBJPSvhUkaOvHK2rLJBRgx bX6GiWH1uSIHO7PLJ0obDA5cUhKmD15Vroi9f7CMV8UyzJWI++ggQmoQIhuj0FI+UOOkdNGq7FI 6iKIEnD8kDtc1uZh/dKXcNBcZni6bO1mm99sT0WK8dFoPFc2dV3jIa3s216ClLQ0/8leunW6WZv HIU7xvE5gQCMP6vx7zZCrCuLSk1RqqnlM39qRMgRYBccZ1WBMM7977qUjY+q88r3oaXjGq+NoHC lBfVJySThcbilpv1kxla3+XfenKlz99Kd0vI356/6KvVehy4IOdY+JDbTvJQE6GWrvHPazffUGM Wpin1sJghnAAGM= X-Received: by 2002:a17:906:730a:b0:b93:80f3:b35b with SMTP id a640c23a62f3a-b9409e510c0mr64413966b.19.1772691117541; Wed, 04 Mar 2026 22:11:57 -0800 (PST) Received: from puffmais2.c.googlers.com (221.210.91.34.bc.googleusercontent.com. [34.91.210.221]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b935aec3243sm849355966b.53.2026.03.04.22.11.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 22:11:57 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Thu, 05 Mar 2026 06:11:54 +0000 Subject: [PATCH v6 05/10] pmdomain: samsung: convert to using regmap MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20260305-gs101-pd-v6-5-8cb953c1a723@linaro.org> References: <20260305-gs101-pd-v6-0-8cb953c1a723@linaro.org> In-Reply-To: <20260305-gs101-pd-v6-0-8cb953c1a723@linaro.org> To: Krzysztof Kozlowski , Alim Akhtar , Rob Herring , Conor Dooley , Krzysztof Kozlowski , Ulf Hansson , Liam Girdwood , Mark Brown Cc: Peter Griffin , Tudor Ambarus , Juan Yescas , Will McVicker , kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Draszik?= , Marek Szyprowski X-Mailer: b4 0.14.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260304_221159_584182_29E5EA80 X-CRM114-Status: GOOD ( 25.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On platforms such as Google gs101, direct mmio register access to the PMU registers doesn't necessarily work and access must happen via a regmap created by the PMU driver instead. In preparation for supporting such SoCs convert the existing mmio accesses to using a regmap wrapper. With this change in place, a follow-up patch can update the driver to optionally acquire the PMU-created regmap without having to change the rest of the code. Tested-by: Marek Szyprowski Signed-off-by: AndrĂ© Draszik --- There is one checkpatch warning, relating to the non-const regmap_config. It can not easily be made const at this stage, but a follow-up patch allows us to make it const and the warning will go away anyway. v4: - rework the loop in exynos_pd_power() slightly, to not return 0 early to allow more code to be run after pd on/off register write without changing the loop again, required for gs101. - add error message in case first regmap write in exynos_pd_power() fails --- drivers/pmdomain/samsung/exynos-pm-domains.c | 83 +++++++++++++++++++++------- 1 file changed, 62 insertions(+), 21 deletions(-) diff --git a/drivers/pmdomain/samsung/exynos-pm-domains.c b/drivers/pmdomain/samsung/exynos-pm-domains.c index 5c3aa8983087..3bcba7d38ac1 100644 --- a/drivers/pmdomain/samsung/exynos-pm-domains.c +++ b/drivers/pmdomain/samsung/exynos-pm-domains.c @@ -9,15 +9,14 @@ // conjunction with runtime-pm. Support for both device-tree and non-device-tree // based power domain support is included. -#include #include #include #include #include #include #include -#include #include +#include struct exynos_pm_domain_config { /* Value for LOCAL_PWR_CFG and STATUS fields for each domain */ @@ -28,7 +27,7 @@ struct exynos_pm_domain_config { * Exynos specific wrapper around the generic power domain */ struct exynos_pm_domain { - void __iomem *base; + struct regmap *regmap; struct generic_pm_domain pd; u32 local_pwr_cfg; }; @@ -36,31 +35,42 @@ struct exynos_pm_domain { static int exynos_pd_power(struct generic_pm_domain *domain, bool power_on) { struct exynos_pm_domain *pd; - void __iomem *base; u32 timeout, pwr; - char *op; + int err; pd = container_of(domain, struct exynos_pm_domain, pd); - base = pd->base; pwr = power_on ? pd->local_pwr_cfg : 0; - writel_relaxed(pwr, base); + err = regmap_write(pd->regmap, 0, pwr); + if (err) { + pr_err("Regmap write for power domain %s %sable failed: %d\n", + domain->name, power_on ? "en" : "dis", err); + return err; + } /* Wait max 1ms */ timeout = 10; - - while ((readl_relaxed(base + 0x4) & pd->local_pwr_cfg) != pwr) { - if (!timeout) { - op = (power_on) ? "enable" : "disable"; - pr_err("Power domain %s %s failed\n", domain->name, op); - return -ETIMEDOUT; + while (timeout-- > 0) { + unsigned int val; + + err = regmap_read(pd->regmap, 0x4, &val); + if (err || ((val & pd->local_pwr_cfg) != pwr)) { + cpu_relax(); + usleep_range(80, 100); + continue; } - timeout--; - cpu_relax(); - usleep_range(80, 100); + + break; } - return 0; + if (!timeout && !err) + /* Only return timeout if no other error also occurred. */ + err = -ETIMEDOUT; + if (err) + pr_err("Power domain %s %sable failed: %d\n", domain->name, + power_on ? "en" : "dis", err); + + return err; } static int exynos_pd_power_on(struct generic_pm_domain *domain) @@ -109,8 +119,18 @@ static int exynos_pd_probe(struct platform_device *pdev) struct device_node *np = dev->of_node; struct of_phandle_args child, parent; struct exynos_pm_domain *pd; + struct resource *res; + void __iomem *base; + unsigned int val; int on, ret; + struct regmap_config reg_config = { + .reg_bits = 32, + .val_bits = 32, + .reg_stride = 4, + .use_relaxed_mmio = true, + }; + pm_domain_cfg = of_device_get_match_data(dev); pd = devm_kzalloc(dev, sizeof(*pd), GFP_KERNEL); if (!pd) @@ -120,9 +140,26 @@ static int exynos_pd_probe(struct platform_device *pdev) if (!pd->pd.name) return -ENOMEM; - pd->base = of_iomap(np, 0); - if (!pd->base) - return -ENODEV; + /* + * The resource typically points into the address space of the PMU. + * Therefore, avoid using devm_platform_get_and_ioremap_resource() and + * instead use platform_get_resource() and devm_ioremap() to avoid + * conflicts due to address space overlap. + */ + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + if (!res) + return dev_err_probe(dev, -ENXIO, "missing IO resources"); + + base = devm_ioremap(dev, res->start, resource_size(res)); + if (!base) + return dev_err_probe(dev, -ENOMEM, + "failed to ioremap PMU registers"); + + reg_config.max_register = resource_size(res) - reg_config.reg_stride; + pd->regmap = devm_regmap_init_mmio(dev, base, ®_config); + if (IS_ERR(pd->regmap)) + return dev_err_probe(dev, PTR_ERR(base), + "failed to init regmap"); pd->pd.power_off = exynos_pd_power_off; pd->pd.power_on = exynos_pd_power_on; @@ -137,7 +174,11 @@ static int exynos_pd_probe(struct platform_device *pdev) of_device_is_compatible(np, "samsung,exynos4210-pd")) exynos_pd_power_off(&pd->pd); - on = readl_relaxed(pd->base + 0x4) & pd->local_pwr_cfg; + ret = regmap_read(pd->regmap, 0x4, &val); + if (ret) + return dev_err_probe(dev, ret, "failed to read status"); + + on = val & pd->local_pwr_cfg; pm_genpd_init(&pd->pd, NULL, !on); ret = of_genpd_add_provider_simple(np, &pd->pd); -- 2.53.0.473.g4a7958ca14-goog