[PATCH v2 1/2] dt-bindings: crypto: eip93: add clock gate and reset line

[PATCH v2 1/2] dt-bindings: crypto: eip93: add clock gate and reset line

[Aleksander Jan Bajkowski]

Add the clock gate and reset line, both of which are available
on the Airoha AN7581. Both properties are mandatory.

Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
---
v2:
- mandate clock and reset properties
- drop extra new lines in example
---
 .../crypto/inside-secure,safexcel-eip93.yaml        | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/crypto/inside-secure,safexcel-eip93.yaml b/Documentation/devicetree/bindings/crypto/inside-secure,safexcel-eip93.yaml
index 997bf9717f9e..10caa989f660 100644
--- a/Documentation/devicetree/bindings/crypto/inside-secure,safexcel-eip93.yaml
+++ b/Documentation/devicetree/bindings/crypto/inside-secure,safexcel-eip93.yaml
@@ -48,20 +48,31 @@ properties:
   interrupts:
     maxItems: 1
 
+  clocks:
+    maxItems: 1
+
+  resets:
+    maxItems: 1
+
 required:
   - compatible
   - reg
   - interrupts
+  - clocks
+  - resets
 
 additionalProperties: false
 
 examples:
   - |
+    #include <dt-bindings/clock/en7523-clk.h>
     #include <dt-bindings/interrupt-controller/arm-gic.h>
+    #include <dt-bindings/reset/airoha,en7581-reset.h>
 
     crypto@1e004000 {
       compatible = "airoha,en7581-eip93", "inside-secure,safexcel-eip93ies";
       reg = <0x1fb70000 0x1000>;
-
+      clocks = <&scuclk EN7523_CLK_CRYPTO>;
       interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>;
+      resets = <&scuclk EN7581_CRYPTO_RST>;
     };
-- 
2.47.3

[PATCH v2 2/2] arm64: dts: airoha: en7581: add crypto offload support

[Aleksander Jan Bajkowski]

Add support for the built-in cryptographic accelerator. This accelerator
supports 3DES, AES (128/192/256 bit), ARC4, MD5, SHA1, SHA224, and SHA256.
It also supports full IPSEC, SRTP and TLS offload.

Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
---
v2:
- drop extra new lines between properties
---
 arch/arm64/boot/dts/airoha/en7581.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/arch/arm64/boot/dts/airoha/en7581.dtsi b/arch/arm64/boot/dts/airoha/en7581.dtsi
index ff6908a76e8e..5621473f5155 100644
--- a/arch/arm64/boot/dts/airoha/en7581.dtsi
+++ b/arch/arm64/boot/dts/airoha/en7581.dtsi
@@ -300,6 +300,15 @@ rng@1faa1000 {
 			interrupts = <GIC_SPI 35 IRQ_TYPE_LEVEL_HIGH>;
 		};
 
+		crypto@1e004000 {
+			compatible = "airoha,en7581-eip93",
+				"inside-secure,safexcel-eip93ies";
+			reg = <0x0 0x1fb70000 0x0 0x1000>;
+			clocks = <&scuclk EN7523_CLK_CRYPTO>;
+			interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>;
+			resets = <&scuclk EN7581_CRYPTO_RST>;
+		};
+
 		system-controller@1fbf0200 {
 			compatible = "airoha,en7581-gpio-sysctl", "syscon",
 				     "simple-mfd";
-- 
2.47.3

Re: [PATCH v2 1/2] dt-bindings: crypto: eip93: add clock gate and reset line

[Krzysztof Kozlowski]

On 05/03/2026 20:53, Aleksander Jan Bajkowski wrote:
> Add the clock gate and reset line, both of which are available
> on the Airoha AN7581. Both properties are mandatory.

Why are mandatory? We see that from the diff, you must explain WHY you
are doing things.

Also, that's ABI break without that explanation.

Best regards,
Krzysztof