* [PATCH] KVM: arm64: Remove the redundant ISB in __kvm_at_s1e2()
@ 2026-03-06 7:44 Zenghui Yu
2026-03-06 10:48 ` Marc Zyngier
0 siblings, 1 reply; 2+ messages in thread
From: Zenghui Yu @ 2026-03-06 7:44 UTC (permalink / raw)
To: kvmarm, linux-arm-kernel
Cc: maz, oupton, joey.gouly, suzuki.poulose, Zenghui Yu (Huawei)
From: "Zenghui Yu (Huawei)" <zenghui.yu@linux.dev>
We already have an ISB in __kvm_at() to make the address translation result
visible to subsequent reads of PAR_EL1. Remove the redundant one right
after it.
Signed-off-by: Zenghui Yu (Huawei) <zenghui.yu@linux.dev>
---
arch/arm64/kvm/at.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm64/kvm/at.c b/arch/arm64/kvm/at.c
index 6588ea251ed7..c5c5644b1878 100644
--- a/arch/arm64/kvm/at.c
+++ b/arch/arm64/kvm/at.c
@@ -1504,8 +1504,6 @@ int __kvm_at_s1e2(struct kvm_vcpu *vcpu, u32 op, u64 vaddr)
fail = true;
}
- isb();
-
if (!fail)
par = read_sysreg_par();
--
2.53.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] KVM: arm64: Remove the redundant ISB in __kvm_at_s1e2()
2026-03-06 7:44 [PATCH] KVM: arm64: Remove the redundant ISB in __kvm_at_s1e2() Zenghui Yu
@ 2026-03-06 10:48 ` Marc Zyngier
0 siblings, 0 replies; 2+ messages in thread
From: Marc Zyngier @ 2026-03-06 10:48 UTC (permalink / raw)
To: kvmarm, linux-arm-kernel, Zenghui Yu; +Cc: oupton, joey.gouly, suzuki.poulose
On Fri, 06 Mar 2026 15:44:22 +0800, Zenghui Yu wrote:
> We already have an ISB in __kvm_at() to make the address translation result
> visible to subsequent reads of PAR_EL1. Remove the redundant one right
> after it.
>
>
Applied to fixes, thanks!
[1/1] KVM: arm64: Remove the redundant ISB in __kvm_at_s1e2()
commit: 3599c714c08c324f0fcfa392bfb857c92c575400
Cheers,
M.
--
Without deviation from the norm, progress is not possible.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-03-06 10:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-06 7:44 [PATCH] KVM: arm64: Remove the redundant ISB in __kvm_at_s1e2() Zenghui Yu
2026-03-06 10:48 ` Marc Zyngier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox