Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Yu-Chun Lin <eleanor.lin@realtek.com>
Cc: linusw@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
	 conor+dt@kernel.org, bartosz.golaszewski@oss.qualcomm.com,
	afaerber@suse.com,  james.tai@realtek.com, cy.huang@realtek.com,
	stanley_chang@realtek.com,  tychang@realtek.com,
	linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
	 linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	 linux-realtek-soc@lists.infradead.org
Subject: Re: [PATCH v2 07/14] dt-bindings: pincfg-node: Add input-voltage-microvolt property
Date: Sat, 7 Mar 2026 13:51:57 +0100	[thread overview]
Message-ID: <20260307-astonishing-helpful-grouse-b7e968@quoll> (raw)
In-Reply-To: <20260306075244.1170399-8-eleanor.lin@realtek.com>

On Fri, Mar 06, 2026 at 03:52:37PM +0800, Yu-Chun Lin wrote:
> From: Tzuyi Chang <tychang@realtek.com>
> 
> Add a generic pin configuration property "input-voltage-microvolt" to
> specify the input voltage level of a pin in microvolts.

Why?

> 
> Signed-off-by: Tzuyi Chang <tychang@realtek.com>
> Co-developed-by: Yu-Chun Lin <eleanor.lin@realtek.com>
> Signed-off-by: Yu-Chun Lin <eleanor.lin@realtek.com>
> ---
>  Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml b/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml
> index a916d0fc79a9..da182c8a1d00 100644
> --- a/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml
> @@ -162,6 +162,10 @@ properties:
>        this affects the expected delay in ps before latching a value to
>        an output pin.
>  
> +  input-voltage-microvolt:
> +    description: Specifies the input voltage level of the pin in microvolts.
> +      This defines the reference for VIH/VIL.

What is VIH/VIL? Why generic binding would define the voltage of pins
for pin control?

This patch misses actual background why you are doing it and what sort
of common/typical pinctrl setup you describe.

Best regards,
Krzysztof



  reply	other threads:[~2026-03-07 12:52 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-06  7:52 [PATCH v2 00/14] pinctrl: realtek: Core improvements and RTD1625 support Yu-Chun Lin
2026-03-06  7:52 ` [PATCH v2 01/14] pinctrl: realtek: Cleanup license string Yu-Chun Lin
2026-03-06  7:52 ` [PATCH v2 02/14] pinctrl: realtek: Fix return value and silence log for unsupported configs Yu-Chun Lin
2026-03-06  7:52 ` [PATCH v2 03/14] pinctrl: realtek: Switch to use devm functions Yu-Chun Lin
2026-03-06  7:52 ` [PATCH v2 04/14] pinctrl: realtek: Simplify error handling with dev_err_probe() Yu-Chun Lin
2026-03-06  7:52 ` [PATCH v2 05/14] pinctrl: realtek: Fix grammar in error messages Yu-Chun Lin
2026-03-06  7:52 ` [PATCH v2 06/14] pinctrl: realtek: Support system suspend and resume Yu-Chun Lin
2026-03-06  7:52 ` [PATCH v2 07/14] dt-bindings: pincfg-node: Add input-voltage-microvolt property Yu-Chun Lin
2026-03-07 12:51   ` Krzysztof Kozlowski [this message]
2026-03-09  9:12     ` Yu-Chun Lin [林祐君]
2026-03-06  7:52 ` [PATCH v2 08/14] pinctrl: pinconf-generic: Add properties 'input-voltage-microvolt' Yu-Chun Lin
2026-03-06  7:52 ` [PATCH v2 09/14] dt-bindings: pinctrl: realtek: Rename 'realtek,duty-cycle' to 'realtek,pulse-width-adjust' Yu-Chun Lin
2026-03-07 12:53   ` Krzysztof Kozlowski
2026-03-09  9:18     ` Yu-Chun Lin [林祐君]
2026-03-09 10:17       ` Krzysztof Kozlowski
2026-03-09 11:00         ` Yu-Chun Lin [林祐君]
2026-03-10  9:28           ` Linus Walleij
2026-03-06  7:52 ` [PATCH v2 10/14] " Yu-Chun Lin
2026-03-06  7:52 ` [PATCH v2 11/14] dt-bindings: pinctrl: realtek: Add RTD1625 pinctrl binding Yu-Chun Lin
2026-03-07 13:09   ` Krzysztof Kozlowski
2026-03-09  9:35     ` Yu-Chun Lin [林祐君]
2026-03-06  7:52 ` [PATCH v2 12/14] pinctrl: realtek: Add support for slew rate, input voltage and high VIL Yu-Chun Lin
2026-03-06  7:52 ` [PATCH v2 14/14] arm64: dts: realtek: Add pinctrl support for RTD1625 Yu-Chun Lin
2026-03-10  9:30 ` [PATCH v2 00/14] pinctrl: realtek: Core improvements and RTD1625 support Linus Walleij
     [not found] ` <20260306075244.1170399-14-eleanor.lin@realtek.com>
2026-03-10  9:48   ` [PATCH v2 13/14] pinctrl: realtek: Add rtd1625 pinctrl driver Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260307-astonishing-helpful-grouse-b7e968@quoll \
    --to=krzk@kernel.org \
    --cc=afaerber@suse.com \
    --cc=bartosz.golaszewski@oss.qualcomm.com \
    --cc=conor+dt@kernel.org \
    --cc=cy.huang@realtek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=eleanor.lin@realtek.com \
    --cc=james.tai@realtek.com \
    --cc=krzk+dt@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-realtek-soc@lists.infradead.org \
    --cc=robh@kernel.org \
    --cc=stanley_chang@realtek.com \
    --cc=tychang@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox