From: Rosen Penev <rosenp@gmail.com>
To: linux-gpio@vger.kernel.org
Cc: Daniel Palmer <daniel@thingy.jp>,
linux-hardening@vger.kernel.org, gustavoars@kernel.org,
Romain Perier <romain.perier@gmail.com>,
Linus Walleij <linusw@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
linux-arm-kernel@lists.infradead.org (moderated
list:ARM/MStar/Sigmastar Armv7 SoC support),
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH] gpio: msc313: remove kcalloc
Date: Sat, 7 Mar 2026 18:15:35 -0800 [thread overview]
Message-ID: <20260308021535.48098-1-rosenp@gmail.com> (raw)
Use a flexible array member to combine kzalloc and kcalloc.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
drivers/gpio/gpio-msc313.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/gpio/gpio-msc313.c b/drivers/gpio/gpio-msc313.c
index 7345afdc78de..de3e6da2a089 100644
--- a/drivers/gpio/gpio-msc313.c
+++ b/drivers/gpio/gpio-msc313.c
@@ -483,7 +483,7 @@ MSC313_GPIO_CHIPDATA(ssd20xd);
struct msc313_gpio {
void __iomem *base;
const struct msc313_gpio_data *gpio_data;
- u8 *saved;
+ u8 saved[];
};
static int msc313_gpio_set(struct gpio_chip *chip, unsigned int offset, int value)
@@ -631,16 +631,12 @@ static int msc313_gpio_probe(struct platform_device *pdev)
if (!parent_domain)
return -ENODEV;
- gpio = devm_kzalloc(dev, sizeof(*gpio), GFP_KERNEL);
+ gpio = devm_kzalloc(dev, struct_size(gpio, saved, match_data->num), GFP_KERNEL);
if (!gpio)
return -ENOMEM;
gpio->gpio_data = match_data;
- gpio->saved = devm_kcalloc(dev, gpio->gpio_data->num, sizeof(*gpio->saved), GFP_KERNEL);
- if (!gpio->saved)
- return -ENOMEM;
-
gpio->base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(gpio->base))
return PTR_ERR(gpio->base);
--
2.53.0
next reply other threads:[~2026-03-08 2:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-08 2:15 Rosen Penev [this message]
2026-03-08 5:59 ` [PATCH] gpio: msc313: remove kcalloc Daniel Palmer
2026-03-09 0:06 ` Linus Walleij
2026-03-09 1:27 ` Rosen Penev
2026-03-09 3:17 ` Gustavo A. R. Silva
2026-03-09 9:03 ` Bartosz Golaszewski
2026-03-09 22:00 ` Rosen Penev
2026-03-10 8:51 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260308021535.48098-1-rosenp@gmail.com \
--to=rosenp@gmail.com \
--cc=brgl@kernel.org \
--cc=daniel@thingy.jp \
--cc=gustavoars@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=romain.perier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox