Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Sudeep Holla <sudeep.holla@kernel.org>
To: Debbie Horsfall <debbie.horsfall@arm.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Liviu Dudau <liviu.dudau@arm.com>,
	Lorenzo Pieralisi <lpieralisi@kernel.org>,
	Linus Walleij <linusw@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/2] arm64: dts: zena: Add support for Zena CSS
Date: Mon, 9 Mar 2026 09:20:57 +0000	[thread overview]
Message-ID: <20260309-manipulative-inescapable-labradoodle-7a76e4@sudeepholla> (raw)
In-Reply-To: <c7124cf5-f20a-4d6f-8f2e-388127c4ad2a@kernel.org>

On Sun, Mar 08, 2026 at 04:41:55PM +0100, Krzysztof Kozlowski wrote:
> On 12/02/2026 12:16, Debbie Horsfall wrote:
> > Introduce the Zena CSS Fixed Virtual Platform (FVP) dts. This is
> > currently the only Zena CSS variant, however the common definitions are
> > included in a common dtsi for extensibility.
> > 
> > Signed-off-by: Debbie Horsfall <debbie.horsfall@arm.com>
> 
> ...
> 
> > +
> > +	timer {
> > +		compatible = "arm,armv8-timer";
> > +		interrupts = <GIC_PPI 13 IRQ_TYPE_LEVEL_LOW>,
> > +			     <GIC_PPI 14 IRQ_TYPE_LEVEL_LOW>,
> > +			     <GIC_PPI 11 IRQ_TYPE_LEVEL_LOW>,
> > +			     <GIC_PPI 10 IRQ_TYPE_LEVEL_LOW>,
> > +			     <GIC_PPI 12 IRQ_TYPE_LEVEL_LOW>;
> > +	};
> > +
> > +	sram: sram@104000 {
> 
> This belongs in the soc node.
> 
> > +		compatible = "mmio-sram";
> > +		reg = <0x0 0x00104000 0x0 0x00001000>;
> > +		#address-cells = <1>;
> > +		#size-cells = <1>;
> > +		ranges = <0 0x0 0x00104000 0x00001000>;
> > +
> > +		scmi_shmem_tx: scpshmem-sram-section@0 {
> > +			compatible = "arm,scmi-shmem";
> > +			reg = <0x0 0x100>;
> > +		};
> > +
> > +		scmi_shmem_rx: scpshmem-sram-section@100 {
> > +			compatible = "arm,scmi-shmem";
> > +			reg = <0x100 0x100>;
> > +		};
> > +	};
> > +
> > +	memory@80000000 {
> 
> And placing this in DTSI means that zena-css comes with this memory
> mounted and it is not customizable in final FVP board.
> 

Both valid points, please post a patch addressing this based on my
for-next/juno/updates as I just applied these last night.

-- 
Regards,
Sudeep


  reply	other threads:[~2026-03-09  9:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-12 11:16 [PATCH v2 0/2] Add Arm Zena CSS support Debbie Horsfall
2026-02-12 11:16 ` [PATCH v2 1/2] dt-bindings: arm: Add Zena CSS compatibility Debbie Horsfall
2026-02-12 11:16 ` [PATCH v2 2/2] arm64: dts: zena: Add support for Zena CSS Debbie Horsfall
2026-03-02 16:40   ` Andre Przywara
2026-03-08 15:41   ` Krzysztof Kozlowski
2026-03-09  9:20     ` Sudeep Holla [this message]
2026-03-08 12:45 ` [PATCH v2 0/2] Add Arm Zena CSS support Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260309-manipulative-inescapable-labradoodle-7a76e4@sudeepholla \
    --to=sudeep.holla@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=debbie.horsfall@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liviu.dudau@arm.com \
    --cc=lpieralisi@kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox