* [PATCH] arm64: dts: imx8mp-dhcom-pdk3: Use symbolic macro for IOMUXC_SAI2_TXC__GPIO4_IO25
@ 2026-03-09 18:15 Eduard Bostina
2026-03-11 8:00 ` Daniel Baluta
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Eduard Bostina @ 2026-03-09 18:15 UTC (permalink / raw)
To: daniel.baluta, simona.toaca, egbostina, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Christoph Niedermaier,
Marek Vasut, Frank Li, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, devicetree, kernel, imx, linux-arm-kernel,
linux-kernel
Currently, in order to configure IOMUXC_SAI2_TXC__GPIO4_IO25 a magic
raw value is written in this register. This makes the code not obvious
to read and modify.
Use the MX8MP_SION symbolic macro instead of the magic value to improve
code readability.
Signed-off-by: Eduard Bostina <egbostina@gmail.com>
---
arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk3.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk3.dts b/arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk3.dts
index ef012e8365b1f..6ad824a7e07e0 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk3.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk3.dts
@@ -345,7 +345,7 @@ &pinctrl_dhcom_l
pinctrl_ptn5150: ptn5150grp {
fsl,pins = <
- MX8MP_IOMUXC_SAI2_TXC__GPIO4_IO25 0x40000000
+ MX8MP_IOMUXC_SAI2_TXC__GPIO4_IO25 MX8MP_SION
>;
};
};
--
2.43.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: imx8mp-dhcom-pdk3: Use symbolic macro for IOMUXC_SAI2_TXC__GPIO4_IO25
2026-03-09 18:15 [PATCH] arm64: dts: imx8mp-dhcom-pdk3: Use symbolic macro for IOMUXC_SAI2_TXC__GPIO4_IO25 Eduard Bostina
@ 2026-03-11 8:00 ` Daniel Baluta
2026-03-13 16:26 ` Frank Li
2026-03-13 16:44 ` Marek Vasut
2 siblings, 0 replies; 5+ messages in thread
From: Daniel Baluta @ 2026-03-11 8:00 UTC (permalink / raw)
To: Eduard Bostina
Cc: daniel.baluta, simona.toaca, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Christoph Niedermaier, Marek Vasut, Frank Li,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, devicetree,
kernel, imx, linux-arm-kernel, linux-kernel
On Mon, Mar 9, 2026 at 8:20 PM Eduard Bostina <egbostina@gmail.com> wrote:
>
> Currently, in order to configure IOMUXC_SAI2_TXC__GPIO4_IO25 a magic
> raw value is written in this register. This makes the code not obvious
> to read and modify.
>
> Use the MX8MP_SION symbolic macro instead of the magic value to improve
> code readability.
>
> Signed-off-by: Eduard Bostina <egbostina@gmail.com>
Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: imx8mp-dhcom-pdk3: Use symbolic macro for IOMUXC_SAI2_TXC__GPIO4_IO25
2026-03-09 18:15 [PATCH] arm64: dts: imx8mp-dhcom-pdk3: Use symbolic macro for IOMUXC_SAI2_TXC__GPIO4_IO25 Eduard Bostina
2026-03-11 8:00 ` Daniel Baluta
@ 2026-03-13 16:26 ` Frank Li
2026-03-13 16:44 ` Marek Vasut
2 siblings, 0 replies; 5+ messages in thread
From: Frank Li @ 2026-03-13 16:26 UTC (permalink / raw)
To: daniel.baluta, simona.toaca, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Christoph Niedermaier, Marek Vasut, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, devicetree, kernel, imx,
linux-arm-kernel, linux-kernel, Eduard Bostina
On Mon, 09 Mar 2026 20:15:23 +0200, Eduard Bostina wrote:
> Currently, in order to configure IOMUXC_SAI2_TXC__GPIO4_IO25 a magic
> raw value is written in this register. This makes the code not obvious
> to read and modify.
>
> Use the MX8MP_SION symbolic macro instead of the magic value to improve
> code readability.
>
> [...]
Applied, thanks!
[1/1] arm64: dts: imx8mp-dhcom-pdk3: Use symbolic macro for IOMUXC_SAI2_TXC__GPIO4_IO25
commit: 79ab6e297167b6eee7540af315bc5569e42182ee
Best regards,
--
Frank Li <Frank.Li@nxp.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: imx8mp-dhcom-pdk3: Use symbolic macro for IOMUXC_SAI2_TXC__GPIO4_IO25
2026-03-09 18:15 [PATCH] arm64: dts: imx8mp-dhcom-pdk3: Use symbolic macro for IOMUXC_SAI2_TXC__GPIO4_IO25 Eduard Bostina
2026-03-11 8:00 ` Daniel Baluta
2026-03-13 16:26 ` Frank Li
@ 2026-03-13 16:44 ` Marek Vasut
2026-03-17 7:36 ` Daniel Baluta
2 siblings, 1 reply; 5+ messages in thread
From: Marek Vasut @ 2026-03-13 16:44 UTC (permalink / raw)
To: Eduard Bostina, daniel.baluta, simona.toaca, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Christoph Niedermaier,
Marek Vasut, Frank Li, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, devicetree, kernel, imx, linux-arm-kernel,
linux-kernel
On 3/9/26 7:15 PM, Eduard Bostina wrote:
> Currently, in order to configure IOMUXC_SAI2_TXC__GPIO4_IO25 a magic
> raw value is written in this register. This makes the code not obvious
> to read and modify.
>
> Use the MX8MP_SION symbolic macro instead of the magic value to improve
> code readability.
>
> Signed-off-by: Eduard Bostina <egbostina@gmail.com>
> ---
> arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk3.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk3.dts b/arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk3.dts
> index ef012e8365b1f..6ad824a7e07e0 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk3.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-dhcom-pdk3.dts
> @@ -345,7 +345,7 @@ &pinctrl_dhcom_l
>
> pinctrl_ptn5150: ptn5150grp {
> fsl,pins = <
> - MX8MP_IOMUXC_SAI2_TXC__GPIO4_IO25 0x40000000
> + MX8MP_IOMUXC_SAI2_TXC__GPIO4_IO25 MX8MP_SION
Isn't the SION bit at the same bit offset at least since iMX5x ? Maybe
the MX8MP_* prefix isn't necessary ?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: imx8mp-dhcom-pdk3: Use symbolic macro for IOMUXC_SAI2_TXC__GPIO4_IO25
2026-03-13 16:44 ` Marek Vasut
@ 2026-03-17 7:36 ` Daniel Baluta
0 siblings, 0 replies; 5+ messages in thread
From: Daniel Baluta @ 2026-03-17 7:36 UTC (permalink / raw)
To: Marek Vasut, Eduard Bostina, daniel.baluta, simona.toaca,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Christoph Niedermaier, Marek Vasut, Frank Li, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, devicetree, kernel, imx,
linux-arm-kernel, linux-kernel
On 3/13/26 18:44, Marek Vasut wrote:
> On 3/9/26 7:15 PM, Eduard Bostina wrote:
>> Currently, in order to configure IOMUXC_SAI2_TXC__GPIO4_IO25 a magic
>> raw value is written in this register. This makes the code not obvious
>> to read and modify.
[..]
>> pinctrl_ptn5150: ptn5150grp {
>> fsl,pins = <
>> - MX8MP_IOMUXC_SAI2_TXC__GPIO4_IO25 0x40000000
>> + MX8MP_IOMUXC_SAI2_TXC__GPIO4_IO25 MX8MP_SION
> Isn't the SION bit at the same bit offset at least since iMX5x ? Maybe
> the MX8MP_* prefix isn't necessary ?
>
Hi Marek,
I think this can be factored out once we finish moving all the configs to symbolic macros.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-03-17 7:34 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-09 18:15 [PATCH] arm64: dts: imx8mp-dhcom-pdk3: Use symbolic macro for IOMUXC_SAI2_TXC__GPIO4_IO25 Eduard Bostina
2026-03-11 8:00 ` Daniel Baluta
2026-03-13 16:26 ` Frank Li
2026-03-13 16:44 ` Marek Vasut
2026-03-17 7:36 ` Daniel Baluta
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox