From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 072B6FCA19D for ; Mon, 9 Mar 2026 22:44:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TkKdSrv2OflJh9hkbLfx/qYD7AsFrnz98TxQpQIkubI=; b=Dky/joXWXBVYGCg9BFzAZE5LLr kPQZtoNo4yAtTppXo9poydP2I9PUBYYCoWGk/e10I9VbZq35SDRhZ4Oot0Byf8I3E+B+MoBTRKFMC onWEC01A+7rHaG3yyMuGCcFOFKr7TuKUdLNH71mpdHtyjpqN8pKCNp+Lsl477WGoDTyU2AAUfa8d/ SkgEdvNAk9NLc03H+qkp/94gzQVJQ39Ed9Gxmrsz2grchCgQ/8xHCKR1dMqKK+1i8S/fx66SdKXGe PL50CDDOGQUojmpS2wavqZp6y/C6KSYLkcDpA8gIHXC+b3phjCuVSZkgLuPj0QNWcV0zYIuOdWZD4 ap4DsiPg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vzjL8-00000008F1y-3t0i; Mon, 09 Mar 2026 22:44:42 +0000 Received: from bali.collaboradmins.com ([148.251.105.195]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vzjL5-00000008Ez3-3d9p; Mon, 09 Mar 2026 22:44:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1773096277; bh=hOzfYzjHemquzVHS6LN19cOYz515Qjqf1oSNrVOyMIc=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=JX1kf8QXj19XAJD1NqoXFv+ekqZhcXk0EMTNQYIZN1BawzQEYmzl7IZNqRYYSzciu Jx8TMGbmZXKxy46Ww/mb4yO6O2rGrjOrsAGffAdB4ZzDJPb80WqfVDQxUIJUTQmri0 9HZt5NTNa1h+DnUmLcvJ+JoyvUjhmabNWxHWBRD+vn3JXSz+Dg0pbXl29gQk3177fC BUbUXvqNnkRzSykHeatLgGbcVoHs4aaKKVGX9y847/f7mE9AZfa1kZOfPhocUGxY3E lEpjhWrGKYC0+gRSdCb1fGktig4nuzlmyyTett09JbDlylDSUUzS6P75/OCnL8gAVr U23LwIRGq3vIQ== Received: from localhost (unknown [86.123.23.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id A7CFE17E0EFE; Mon, 9 Mar 2026 23:44:37 +0100 (CET) From: Cristian Ciocaltea Date: Tue, 10 Mar 2026 00:44:31 +0200 Subject: [PATCH v2 3/8] drm/rockchip: dw_dp: Fix null-ptr-deref in dw_dp_remove() MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260310-drm-rk-fixes-v2-3-645ecfb43f49@collabora.com> References: <20260310-drm-rk-fixes-v2-0-645ecfb43f49@collabora.com> In-Reply-To: <20260310-drm-rk-fixes-v2-0-645ecfb43f49@collabora.com> To: Sandy Huang , =?utf-8?q?Heiko_St=C3=BCbner?= , Andy Yan , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Dmitry Baryshkov , Dmitry Baryshkov , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec Cc: kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260309_154440_056251_AB38E25B X-CRM114-Status: GOOD ( 12.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Attempting to access driver data in the platform driver ->remove() callback may lead to a null pointer dereference since there is no guaranty that the component ->bind() callback invoking platform_set_drvdata() was executed. A common scenario is when Rockchip DRM driver didn't manage to run component_bind_all() because of an (unrelated) error causing early return from rockchip_drm_bind(). Drop the unnecessary call to platform_get_drvdata() and, instead, reference the target device structure via platform_device. Fixes: d68ba7bac955 ("drm/rockchip: Add RK3588 DPTX output support") Signed-off-by: Cristian Ciocaltea --- drivers/gpu/drm/rockchip/dw_dp-rockchip.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/rockchip/dw_dp-rockchip.c b/drivers/gpu/drm/rockchip/dw_dp-rockchip.c index 532af476d250..8945a245398c 100644 --- a/drivers/gpu/drm/rockchip/dw_dp-rockchip.c +++ b/drivers/gpu/drm/rockchip/dw_dp-rockchip.c @@ -133,9 +133,7 @@ static int dw_dp_probe(struct platform_device *pdev) static void dw_dp_remove(struct platform_device *pdev) { - struct rockchip_dw_dp *dp = platform_get_drvdata(pdev); - - component_del(dp->dev, &dw_dp_rockchip_component_ops); + component_del(&pdev->dev, &dw_dp_rockchip_component_ops); } static const struct dw_dp_plat_data rk3588_dp_plat_data = { -- 2.52.0