From: Wilken Gottwalt <wilken.gottwalt@posteo.net>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: Chen-Yu Tsai <wens@kernel.org>,
linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
Bjorn Andersson <andersson@kernel.org>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
linux-remoteproc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev
Subject: Re: [PATCH v4 09/15] hwspinlock: sun6i: use new callback to initialize hwspinlock priv
Date: Tue, 10 Mar 2026 10:22:23 +0000 [thread overview]
Message-ID: <20260310112220.771011e0@posteo.net> (raw)
In-Reply-To: <aa_sckE7C3kwqYxb@shikoro>
On Tue, 10 Mar 2026 11:03:30 +0100
Wolfram Sang <wsa+renesas@sang-engineering.com> wrote:
> Hi ChenYu,
>
> > > bank_fail:
> > > clk_disable_unprepare(priv->ahb_clk);
> >
> > Just a note, I see further code savings in using the clk and reset devm_
> > helpers. I'll do this after this series is merged, as the context overlaps.
>
> Yes, I saw this, too, but thought that this needs HW for proper testing.
> Great that you are up for it!
Not only that. You may also need to run the CRUST firmware on the OpenRISC
companion core. Getting that hwspinlock driver done and tested was some real
pain in the past. I still have everything on github for this
(https://github.com/wgottwalt/sunxi_hwspinlock). But I may not be able to test
that in time. I moved a while ago and, uhm, quite some hardware disappeared.
greetings
next prev parent reply other threads:[~2026-03-10 10:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 7:55 [PATCH v4 00/15] hwspinlock: move device alloc into core and refactor includes Wolfram Sang
2026-03-10 7:55 ` [PATCH v4 03/15] hwspinlock: add helpers to retrieve core data Wolfram Sang
2026-03-10 9:32 ` Chen-Yu Tsai
2026-03-10 7:55 ` [PATCH v4 04/15] hwspinlock: add callback to fill private data of a hwspinlock Wolfram Sang
2026-03-17 13:54 ` Antonio Borneo
2026-03-18 10:31 ` Wolfram Sang
2026-03-10 7:55 ` [PATCH v4 08/15] hwspinlock: stm32: use new callback to initialize hwspinlock priv Wolfram Sang
2026-03-10 7:55 ` [PATCH v4 09/15] hwspinlock: sun6i: " Wolfram Sang
2026-03-10 9:39 ` Chen-Yu Tsai
2026-03-10 10:03 ` Wolfram Sang
2026-03-10 10:22 ` Wilken Gottwalt [this message]
2026-03-10 7:55 ` [PATCH v4 10/15] hwspinlock: handle hwspinlock device allocation in the core Wolfram Sang
2026-03-10 7:55 ` [PATCH v4 11/15] hwspinlock: move entries from internal to public header Wolfram Sang
2026-03-10 7:55 ` [PATCH v4 14/15] hwspinlock: refactor provider.h from " Wolfram Sang
2026-03-10 7:55 ` [PATCH v4 15/15] hwspinlock/treewide: refactor consumer.h " Wolfram Sang
2026-03-11 9:24 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260310112220.771011e0@posteo.net \
--to=wilken.gottwalt@posteo.net \
--cc=andersson@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=jernej.skrabec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=samuel@sholland.org \
--cc=wens@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox