public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
* [GIT PULL] KVM/arm64 fixes for 7.0, take #3
@ 2026-03-11 17:39 Marc Zyngier
  2026-03-11 17:42 ` Paolo Bonzini
  0 siblings, 1 reply; 2+ messages in thread
From: Marc Zyngier @ 2026-03-11 17:39 UTC (permalink / raw)
  To: Paolo Bonzini
  Cc: Suzuki K Poulose, Valentine Burley, Vincent Donnefort, Joey Gouly,
	Oliver Upton, Zenghui Yu, linux-arm-kernel, kvmarm, kvm

Paolo,

Here's the third set of fixes for 7.0. Two fixes, both related to the
pretty large vgic rewrite that went into 6.19. One is affecting
interrupt deactivation, and therefore leading to guests locking
up. The other is affecting CPU hotplug with pKVM, leading to the
onlined CPU not booting at all.

Please pull,

	M.

Marc Zyngier (2):
  KVM: arm64: vgic: Pick EOIcount deactivations from AP-list tail
  KVM: arm64: pkvm: Don't reprobe for ICH_VTR_EL2.TDS on CPU hotplug

 arch/arm64/include/asm/kvm_host.h |  3 +++
 arch/arm64/kernel/cpufeature.c    |  9 +++++++++
 arch/arm64/kvm/vgic/vgic-v2.c     |  4 ++--
 arch/arm64/kvm/vgic/vgic-v3.c     | 12 ++++++------
 arch/arm64/kvm/vgic/vgic.c        |  6 ++++++
 5 files changed, 26 insertions(+), 8 deletions(-)

-- 
2.47.3

The following changes since commit 3599c714c08c324f0fcfa392bfb857c92c575400:

  KVM: arm64: Remove the redundant ISB in __kvm_at_s1e2() (2026-03-06 10:42:21 +0000)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/kvmarm/kvmarm.git tags/kvmarm-fixes-7.0-3

for you to fetch changes up to a79f7b4aeb8e7562cd6dbf9c223e2c2a04b1a85f:

  KVM: arm64: pkvm: Don't reprobe for ICH_VTR_EL2.TDS on CPU hotplug (2026-03-10 09:48:45 +0000)

----------------------------------------------------------------
KVM/arm64 fixes for 7.0, take #3

- Correctly handle deeactivation of out-of-LRs interrupts by
  starting the EOIcount deactivation walk *after* the last irq
  that made it into an LR. This avoids deactivating irqs that
  are in the LRs and that the vcpu hasn't deactivated yet.

- Avoid calling into the stubs to probe for ICH_VTR_EL2.TDS when
  pKVM is already enabled -- not only thhis isn't possible (pKVM
  will reject the call), but it is also useless: this can only
  happen for a CPU that has already booted once, and the capability
  will not change.

----------------------------------------------------------------
Marc Zyngier (2):
      KVM: arm64: vgic: Pick EOIcount deactivations from AP-list tail
      KVM: arm64: pkvm: Don't reprobe for ICH_VTR_EL2.TDS on CPU hotplug

 arch/arm64/include/asm/kvm_host.h |  3 +++
 arch/arm64/kernel/cpufeature.c    |  9 +++++++++
 arch/arm64/kvm/vgic/vgic-v2.c     |  4 ++--
 arch/arm64/kvm/vgic/vgic-v3.c     | 12 ++++++------
 arch/arm64/kvm/vgic/vgic.c        |  6 ++++++
 5 files changed, 26 insertions(+), 8 deletions(-)


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [GIT PULL] KVM/arm64 fixes for 7.0, take #3
  2026-03-11 17:39 [GIT PULL] KVM/arm64 fixes for 7.0, take #3 Marc Zyngier
@ 2026-03-11 17:42 ` Paolo Bonzini
  0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2026-03-11 17:42 UTC (permalink / raw)
  To: Marc Zyngier
  Cc: Suzuki K Poulose, Valentine Burley, Vincent Donnefort, Joey Gouly,
	Oliver Upton, Zenghui Yu, linux-arm-kernel, kvmarm, kvm

On Wed, Mar 11, 2026 at 6:39 PM Marc Zyngier <maz@kernel.org> wrote:
>
> Paolo,
>
> Here's the third set of fixes for 7.0. Two fixes, both related to the
> pretty large vgic rewrite that went into 6.19. One is affecting
> interrupt deactivation, and therefore leading to guests locking
> up. The other is affecting CPU hotplug with pKVM, leading to the
> onlined CPU not booting at all.
>
> Please pull,

Done, thanks.

Paolo

>
>         M.
>
> Marc Zyngier (2):
>   KVM: arm64: vgic: Pick EOIcount deactivations from AP-list tail
>   KVM: arm64: pkvm: Don't reprobe for ICH_VTR_EL2.TDS on CPU hotplug
>
>  arch/arm64/include/asm/kvm_host.h |  3 +++
>  arch/arm64/kernel/cpufeature.c    |  9 +++++++++
>  arch/arm64/kvm/vgic/vgic-v2.c     |  4 ++--
>  arch/arm64/kvm/vgic/vgic-v3.c     | 12 ++++++------
>  arch/arm64/kvm/vgic/vgic.c        |  6 ++++++
>  5 files changed, 26 insertions(+), 8 deletions(-)
>
> --
> 2.47.3
>
> The following changes since commit 3599c714c08c324f0fcfa392bfb857c92c575400:
>
>   KVM: arm64: Remove the redundant ISB in __kvm_at_s1e2() (2026-03-06 10:42:21 +0000)
>
> are available in the Git repository at:
>
>   git://git.kernel.org/pub/scm/linux/kernel/git/kvmarm/kvmarm.git tags/kvmarm-fixes-7.0-3
>
> for you to fetch changes up to a79f7b4aeb8e7562cd6dbf9c223e2c2a04b1a85f:
>
>   KVM: arm64: pkvm: Don't reprobe for ICH_VTR_EL2.TDS on CPU hotplug (2026-03-10 09:48:45 +0000)
>
> ----------------------------------------------------------------
> KVM/arm64 fixes for 7.0, take #3
>
> - Correctly handle deeactivation of out-of-LRs interrupts by
>   starting the EOIcount deactivation walk *after* the last irq
>   that made it into an LR. This avoids deactivating irqs that
>   are in the LRs and that the vcpu hasn't deactivated yet.
>
> - Avoid calling into the stubs to probe for ICH_VTR_EL2.TDS when
>   pKVM is already enabled -- not only thhis isn't possible (pKVM
>   will reject the call), but it is also useless: this can only
>   happen for a CPU that has already booted once, and the capability
>   will not change.
>
> ----------------------------------------------------------------
> Marc Zyngier (2):
>       KVM: arm64: vgic: Pick EOIcount deactivations from AP-list tail
>       KVM: arm64: pkvm: Don't reprobe for ICH_VTR_EL2.TDS on CPU hotplug
>
>  arch/arm64/include/asm/kvm_host.h |  3 +++
>  arch/arm64/kernel/cpufeature.c    |  9 +++++++++
>  arch/arm64/kvm/vgic/vgic-v2.c     |  4 ++--
>  arch/arm64/kvm/vgic/vgic-v3.c     | 12 ++++++------
>  arch/arm64/kvm/vgic/vgic.c        |  6 ++++++
>  5 files changed, 26 insertions(+), 8 deletions(-)
>



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-03-11 17:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-11 17:39 [GIT PULL] KVM/arm64 fixes for 7.0, take #3 Marc Zyngier
2026-03-11 17:42 ` Paolo Bonzini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox