From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 52F1AFED2E4 for ; Thu, 12 Mar 2026 08:06:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=H3wMZf2HmhP9NdVTfw/i6G0buMeR3JnI3HCvLw48Luw=; b=ywD1nmxafNaAJxmF8HusZ8gLwy w7vtf6SAGkstxoom2/C4fTi/aMIUE0kz+E/R7Ckqr5clpDXhH3stQq2WLwMS6lmjM38+7XEA+oAam x0XtfO7BWOVLdRQOCKEReKf+mGq9qU0Ihru+/gzZHBYXweZJVdqk2gVqqr3ibIhUS15vCiDMOXBd4 1zO9485xIoKGlBFA4Z0JD58yIcF5mQs8ctaHh6Yun5i/OqEJoaCEp04LtmenQrTgxLIFu8eJ1K7NC m0Rj7W1difLd4Yc8Hjgkp3y+IyR1VY4rHLFxlliLxnVIC2pUI9l3testQZ4qzuOlmfaNvn9/u6O0p ciHu0zqA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1w0b3U-0000000Daqq-459r; Thu, 12 Mar 2026 08:06:04 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1w0b3R-0000000DaoC-3BNA for linux-arm-kernel@lists.infradead.org; Thu, 12 Mar 2026 08:06:03 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 020336014B; Thu, 12 Mar 2026 08:06:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A7F92C4CEF7; Thu, 12 Mar 2026 08:05:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773302760; bh=GrsKvOZ6VufbBgYbhrd6xHH3pkcwgPsCkJfdzsv8h80=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=L+xYzgEzmUqSoms73n0IBLxp2/AjrTR5NE6GxICk3JjchloFho4SdZODXCqLkLDt2 V/8ra8nSHv2A7KbfblknEAe8f0/tWRV9PjcGfLU6FZwZ7RfI+1M59Qvszk7qh8bv5+ RsvqPRmp+AWYmCe2BM/8G2vNbZghAF5QPRFKM2TCW/MaY4AbB6KcfDO3/GUQIcRXoV 7HzAmy+zsSBWAH3cBIOQVRfxGwBU9b3qCUt7SU944LyB1pVM7aQySy4uKxq+tr6z3k QUoTN/QeLHDxPK+w855b770kNjB8P0x1uJxsSx7rrn74HwIzTn/UwgF4GIWH8HgKTH rWL49xyQTaHww== From: "Aneesh Kumar K.V (Arm)" To: linux-coco@lists.linux.dev, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org, "Aneesh Kumar K.V (Arm)" , Marc Zyngier , Catalin Marinas , Will Deacon , Jonathan Cameron , Jason Gunthorpe , Dan Williams , Alexey Kardashevskiy , Samuel Ortiz , Xu Yilun , Suzuki K Poulose , Steven Price , Jonathan Cameron Subject: [RFC PATCH v3 11/11] coco: guest: arm64: Enable vdev DMA after attestation Date: Thu, 12 Mar 2026 13:34:42 +0530 Message-ID: <20260312080442.3485633-12-aneesh.kumar@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260312080442.3485633-1-aneesh.kumar@kernel.org> References: <20260312080442.3485633-1-aneesh.kumar@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org - define SMC_RSI_VDEV_DMA_ENABLE and add wrapper in rsi_cmds.h - invoke the new helper from the guest accept path once the device passes attestation, rolling back to TDI_LOCKED on failure Cc: Marc Zyngier Cc: Catalin Marinas Cc: Will Deacon Cc: Jonathan Cameron Cc: Jason Gunthorpe Cc: Dan Williams Cc: Alexey Kardashevskiy Cc: Samuel Ortiz Cc: Xu Yilun Cc: Suzuki K Poulose Cc: Steven Price Reviewed-by: Jonathan Cameron Signed-off-by: Aneesh Kumar K.V (Arm) --- arch/arm64/include/asm/rsi_cmds.h | 16 ++++++++++++++++ arch/arm64/include/asm/rsi_smc.h | 2 ++ drivers/virt/coco/arm-cca-guest/rsi-da.c | 14 ++++++++++++++ 3 files changed, 32 insertions(+) diff --git a/arch/arm64/include/asm/rsi_cmds.h b/arch/arm64/include/asm/rsi_cmds.h index f72d8e0cd422..1e0d1cd8841a 100644 --- a/arch/arm64/include/asm/rsi_cmds.h +++ b/arch/arm64/include/asm/rsi_cmds.h @@ -226,4 +226,20 @@ static inline unsigned long rsi_vdev_get_info(unsigned long vdev_id, return res.a0; } +static inline unsigned long __rsi_vdev_dma_enable(unsigned long vdev_id, + unsigned long flags, + unsigned long non_ats_plane, + unsigned long lock_nonce, + unsigned long meas_nonce, + unsigned long report_nonce) +{ + struct arm_smccc_res res; + + arm_smccc_1_1_invoke(SMC_RSI_VDEV_DMA_ENABLE, vdev_id, flags, + non_ats_plane, lock_nonce, + meas_nonce, report_nonce, &res); + + return res.a0; +} + #endif /* __ASM_RSI_CMDS_H */ diff --git a/arch/arm64/include/asm/rsi_smc.h b/arch/arm64/include/asm/rsi_smc.h index 5f1837282237..d2ea3656ea8f 100644 --- a/arch/arm64/include/asm/rsi_smc.h +++ b/arch/arm64/include/asm/rsi_smc.h @@ -186,6 +186,8 @@ struct realm_config { */ #define SMC_RSI_IPA_STATE_GET SMC_RSI_FID(0x198) +#define SMC_RSI_VDEV_DMA_ENABLE SMC_RSI_FID(0x19C) + struct rsi_vdevice_info { union { struct { diff --git a/drivers/virt/coco/arm-cca-guest/rsi-da.c b/drivers/virt/coco/arm-cca-guest/rsi-da.c index 4030fa213ff4..74594066f46c 100644 --- a/drivers/virt/coco/arm-cca-guest/rsi-da.c +++ b/drivers/virt/coco/arm-cca-guest/rsi-da.c @@ -231,9 +231,17 @@ int cca_verify_digests(u64 hash_algo, return 0; } +static inline int rsi_vdev_enable_dma(int vdev_id, struct dsm_device_info *dev_info) +{ + /* No ATS support */ + return __rsi_vdev_dma_enable(vdev_id, 0, 0, dev_info->lock_nonce, + dev_info->meas_nonce, dev_info->report_nonce); +} + int cca_device_accept(struct pci_dev *pdev, unsigned long lock_nonce) { int ret; + int vdev_id = rsi_vdev_id(pdev); struct cca_guest_dsc *dsc = to_cca_guest_dsc(pdev); if (lock_nonce != dsc->dev_info.lock_nonce) { @@ -270,6 +278,12 @@ int cca_device_accept(struct pci_dev *pdev, unsigned long lock_nonce) return ret; } + if (rsi_vdev_enable_dma(vdev_id, &dsc->dev_info)) { + rhi_vdev_set_tdi_state(pdev, RHI_DA_TDI_CONFIG_LOCKED); + pci_err(pdev, "failed to enable DMA from the device\n"); + return -EIO; + } + dsc->pci.mmio = no_free_ptr(tsm_mmio); return 0; } -- 2.43.0