From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C5A3E106ACEA for ; Thu, 12 Mar 2026 21:14:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:Mime-Version:References:In-Reply-To:Message-Id:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JyaGHRZ3ZkkbnQmXol9kjS74w6GitWq98nUjpBQHQFI=; b=CQkzOmnal5v+tttaGpVFvEIl6E TnWG8x0OdVi8QaIyunOSutkz1yoiMb4hHdJ3pxu0H1NEBtwNMxA+mVpuGjzvUJO4lMEj0lZnfSHFm T/DYK1gqwyQy10qETws4q/gz3ULA3OI97OYjVUdl77v4mGgLcKb0HUbl0xd3vY/F2339Rj0QUAIfY 3k0uqSfu1DfSY//mrVmFdRfpiCb7MylK4LIWti1Io5os7tiV8y8us/xYMvWg0EVdqFo70a4K5aZFf qzG69XXBAh3NfbH6S/9YU4fASZNxFdUQIrLlxXlDWQ46zObPViA4zxEPyIo7vjKLgHyckeySDBojW mdpLmYNA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1w0nMW-0000000FQFz-3KWV; Thu, 12 Mar 2026 21:14:32 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1w0nMU-0000000FQEz-0tFd; Thu, 12 Mar 2026 21:14:31 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 03C6B44398; Thu, 12 Mar 2026 21:14:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B3794C4CEF7; Thu, 12 Mar 2026 21:14:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1773350068; bh=BHIeqMCeZ08yvAl5YqqjtddRClVSOvGwSHug5GXzEz8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Duh+dhDjn9i3oyIucNjLcpV7CKSwWMDBwP1nrAeCAWcyGXtDakHpRp+pm3kMEvL8y SEaAaWk5jP3gQGaz8kV5kaoD1HdJgTdnHuWBZE8KvOuDSG+7q7krHiTC3YYNdfGDfn Xpz6tLlo5tMrkq0Sz1LyxlbqOsozNn9yfZFUkN8M= Date: Thu, 12 Mar 2026 14:14:25 -0700 From: Andrew Morton To: "Lorenzo Stoakes (Oracle)" Cc: Jonathan Corbet , Clemens Ladisch , Arnd Bergmann , Greg Kroah-Hartman , "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Alexander Shishkin , Maxime Coquelin , Alexandre Torgue , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Bodo Stroesser , "Martin K . Petersen" , David Howells , Marc Dionne , Alexander Viro , Christian Brauner , Jan Kara , David Hildenbrand , "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Pedro Falcato , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-mtd@lists.infradead.org, linux-staging@lists.linux.dev, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-afs@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Ryan Roberts Subject: Re: [PATCH 01/15] mm: various small mmap_prepare cleanups Message-Id: <20260312141425.1837736829210f2d0b00cac6@linux-foundation.org> In-Reply-To: <56372fe273f775b26675a04652c1229e14680741.1773346620.git.ljs@kernel.org> References: <56372fe273f775b26675a04652c1229e14680741.1773346620.git.ljs@kernel.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260312_141430_296959_5096EC13 X-CRM114-Status: GOOD ( 11.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 12 Mar 2026 20:27:16 +0000 "Lorenzo Stoakes (Oracle)" wrote: > +int mmap_action_prepare(struct vm_area_desc *desc, > + struct mmap_action *action) > + > { > switch (action->type) { > case MMAP_NOTHING: > - break; > + return 0; > case MMAP_REMAP_PFN: > - remap_pfn_range_prepare(desc, action->remap.start_pfn); > - break; > + return remap_pfn_range_prepare(desc, action); > case MMAP_IO_REMAP_PFN: > - io_remap_pfn_range_prepare(desc, action->remap.start_pfn, > - action->remap.size); > - break; > + return io_remap_pfn_range_prepare(desc, action); > } > } > EXPORT_SYMBOL(mmap_action_prepare); hm, was this the correct version? mm/util.c: In function 'mmap_action_prepare': mm/util.c:1451:1: error: control reaches end of non-void function [-Werror=return-type] 1451 | } --- a/mm/util.c~mm-various-small-mmap_prepare-cleanups-fix +++ a/mm/util.c @@ -1356,6 +1356,8 @@ int mmap_action_prepare(struct vm_area_d return remap_pfn_range_prepare(desc, action); case MMAP_IO_REMAP_PFN: return io_remap_pfn_range_prepare(desc, action); + default: + BUG(); } } EXPORT_SYMBOL(mmap_action_prepare); _