[PATCH v2 1/2] dt-bindings: PCI: fsl,imx6q-pcie: Explicitly deprecate reset-gpio

[PATCH v2 1/2] dt-bindings: PCI: fsl,imx6q-pcie: Explicitly deprecate reset-gpio

[Krzysztof Kozlowski]

The binding references snps,dw-pcie-common.yaml which already deprecates
"reset-gpio", however mentioning this property here lacks this mark thus
code is confusing and suggests property is not deprecated.

OTOH, the property cannot be removed from this schema, because it is an
ABI implemented by Linux kernel in gpiolib-of.c in backwards-compatible
map between compatibles, "reset-gpio" and "reset-gpio-active-high"
properties.

This creates code and binding which is not obvious to follow, so rewrite
it and be more explicit about:
1. Deprecation of "reset-gpio",
2. Relation that "reset-gpio-active-high" is used only for that property
   and not proper "reset-gpios".

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

---

Cc: Sherry Sun <sherry.sun@nxp.com>

Changes in v2:
1. Rewrite the commit completely after Sherry Sun comments - keep the
   property, but add "not" clause to forbid usavge of
   "reset-gpio-active-high" and "reset-gpios".
2. Because of above not adding Richard's ack.

v1:
https://lore.kernel.org/r/20260311154955.145120-3-krzysztof.kozlowski@oss.qualcomm.com
---
 Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
index 12a01f7a5744..12cd1b9f78d0 100644
--- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
@@ -62,6 +62,9 @@ properties:
     description: Should specify the GPIO for controlling the PCI bus device
       reset signal. It's not polarity aware and defaults to active-low reset
       sequence (L=reset state, H=operation state) (optional required).
+      Deprecated, use reset-gpios which respects the polarity expressed in
+      phandle argument.
+    deprecated: true
 
   reset-gpio-active-high:
     description: If present then the reset sequence using the GPIO
@@ -224,6 +227,11 @@ allOf:
             - const: ref
             - const: extref  # Optional
 
+  - not:
+      required:
+        - reset-gpios
+        - reset-gpio-active-high
+
 unevaluatedProperties: false
 
 examples:
-- 
2.51.0

[PATCH v2 2/2] dt-bindings: PCI: snps,dw-pcie: Drop deprecated reset-gpio

[Krzysztof Kozlowski]

GPIOs with "gpio" suffix were long time ago deprecated in favor of
"gpios" and this particular property was documented explicitly as
deprecated since commit 42694f9f6407 ("dt-bindings: PCI: add
snps,dw-pcie.yaml") in 2021.

Linux kernel supports both variants for a long time, thus listing the
deprecated one is redundant and instead legacy DTS should be updated.

Acked-by: Richard Zhu <hongxing.zhu@nxp.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

---

I will fix DTS separately, so after applying this patch there will be
bunch of dtbs_check warnings. That's expected and fine.

Changes in v2:
1. Ack
---
 .../devicetree/bindings/pci/snps,dw-pcie-common.yaml       | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/Documentation/devicetree/bindings/pci/snps,dw-pcie-common.yaml b/Documentation/devicetree/bindings/pci/snps,dw-pcie-common.yaml
index 2c4dc04f9984..deba46d7a924 100644
--- a/Documentation/devicetree/bindings/pci/snps,dw-pcie-common.yaml
+++ b/Documentation/devicetree/bindings/pci/snps,dw-pcie-common.yaml
@@ -209,13 +209,6 @@ properties:
             - pattern: '^p2u-[0-7]$'
             - pattern: '^cp[01]-pcie[0-2]-x[124](-lane[0-3])?-phy$'  # marvell,armada8k-pcie
 
-  reset-gpio:
-    deprecated: true
-    description:
-      Reference to the GPIO-controlled PERST# signal. It is used to reset all
-      the peripheral devices available on the PCIe bus.
-    maxItems: 1
-
   reset-gpios:
     description:
       Reference to the GPIO-controlled PERST# signal. It is used to reset all
-- 
2.51.0

Re: [PATCH v2 2/2] dt-bindings: PCI: snps,dw-pcie: Drop deprecated reset-gpio

[Rob Herring]

On Thu, Mar 12, 2026 at 07:43:46PM +0100, Krzysztof Kozlowski wrote:
> GPIOs with "gpio" suffix were long time ago deprecated in favor of
> "gpios" and this particular property was documented explicitly as
> deprecated since commit 42694f9f6407 ("dt-bindings: PCI: add
> snps,dw-pcie.yaml") in 2021.
> 
> Linux kernel supports both variants for a long time, thus listing the
> deprecated one is redundant and instead legacy DTS should be updated.
> 
> Acked-by: Richard Zhu <hongxing.zhu@nxp.com>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> 
> ---
> 
> I will fix DTS separately, so after applying this patch there will be
> bunch of dtbs_check warnings. That's expected and fine.

Not fine. I only want to see warnings decreasing.

The justification for dropping deprecated properties should be "there 
aren't any more known users (for some amount of time)".

Rob

RE: [PATCH v2 1/2] dt-bindings: PCI: fsl,imx6q-pcie: Explicitly deprecate reset-gpio

[Sherry Sun]

> Subject: [PATCH v2 1/2] dt-bindings: PCI: fsl,imx6q-pcie: Explicitly deprecate
> reset-gpio
>
> The binding references snps,dw-pcie-common.yaml which already deprecates
> "reset-gpio", however mentioning this property here lacks this mark thus
> code is confusing and suggests property is not deprecated.
>
> OTOH, the property cannot be removed from this schema, because it is an
> ABI implemented by Linux kernel in gpiolib-of.c in backwards-compatible map
> between compatibles, "reset-gpio" and "reset-gpio-active-high"
> properties.
>
> This creates code and binding which is not obvious to follow, so rewrite it and
> be more explicit about:
> 1. Deprecation of "reset-gpio",
> 2. Relation that "reset-gpio-active-high" is used only for that property
>    and not proper "reset-gpios".
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
>
> ---
>
> Cc: Sherry Sun <sherry.sun@nxp.com>
>
> Changes in v2:
> 1. Rewrite the commit completely after Sherry Sun comments - keep the
>    property, but add "not" clause to forbid usavge of
>    "reset-gpio-active-high" and "reset-gpios".
> 2. Because of above not adding Richard's ack.
>
> v1:
> https://lore.ke/
> rnel.org%2Fr%2F20260311154955.145120-3-
> krzysztof.kozlowski%40oss.qualcomm.com&data=05%7C02%7Csherry.sun%4
> 0nxp.com%7Cc630bed6bc4f46715b4408de80675002%7C686ea1d3bc2b4c6fa
> 92cd99c5c301635%7C0%7C0%7C639089378371805072%7CUnknown%7CTWF
> pbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4
> zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=A%2BiFa
> kDVdjPn0JJxUDlTDt1ej4iqnBivDktjwbcpFK4%3D&reserved=0
> ---
>  Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> index 12a01f7a5744..12cd1b9f78d0 100644
> --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> @@ -62,6 +62,9 @@ properties:
>      description: Should specify the GPIO for controlling the PCI bus device
>        reset signal. It's not polarity aware and defaults to active-low reset
>        sequence (L=reset state, H=operation state) (optional required).
> +      Deprecated, use reset-gpios which respects the polarity expressed in
> +      phandle argument.
> +    deprecated: true
>
>    reset-gpio-active-high:
>      description: If present then the reset sequence using the GPIO

Hi Krzysztof,
This property also needs to be deprecated as Rob suggested in my previous patch :)
https://lore.kernel.org/all/20260121164002.GA3427694-robh@kernel.org/

Best Regards
Sherry

 @@ -224,6
> +227,11 @@ allOf:
>              - const: ref
>              - const: extref  # Optional
>
> +  - not:
> +      required:
> +        - reset-gpios
> +        - reset-gpio-active-high
> +
>  unevaluatedProperties: false
>
>  examples:
> --
> 2.51.0

Re: [PATCH v2 1/2] dt-bindings: PCI: fsl,imx6q-pcie: Explicitly deprecate reset-gpio

[Krzysztof Kozlowski]

On 13/03/2026 03:27, Sherry Sun wrote:
>> Subject: [PATCH v2 1/2] dt-bindings: PCI: fsl,imx6q-pcie: Explicitly deprecate
>> reset-gpio
>>
>> The binding references snps,dw-pcie-common.yaml which already deprecates
>> "reset-gpio", however mentioning this property here lacks this mark thus
>> code is confusing and suggests property is not deprecated.
>>
>> OTOH, the property cannot be removed from this schema, because it is an
>> ABI implemented by Linux kernel in gpiolib-of.c in backwards-compatible map
>> between compatibles, "reset-gpio" and "reset-gpio-active-high"
>> properties.
>>
>> This creates code and binding which is not obvious to follow, so rewrite it and
>> be more explicit about:
>> 1. Deprecation of "reset-gpio",
>> 2. Relation that "reset-gpio-active-high" is used only for that property
>>    and not proper "reset-gpios".
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
>>
>> ---
>>
>> Cc: Sherry Sun <sherry.sun@nxp.com>
>>
>> Changes in v2:
>> 1. Rewrite the commit completely after Sherry Sun comments - keep the
>>    property, but add "not" clause to forbid usavge of
>>    "reset-gpio-active-high" and "reset-gpios".
>> 2. Because of above not adding Richard's ack.
>>
>> v1:
>> https://lore.ke/
>> rnel.org%2Fr%2F20260311154955.145120-3-
>> krzysztof.kozlowski%40oss.qualcomm.com&data=05%7C02%7Csherry.sun%4
>> 0nxp.com%7Cc630bed6bc4f46715b4408de80675002%7C686ea1d3bc2b4c6fa
>> 92cd99c5c301635%7C0%7C0%7C639089378371805072%7CUnknown%7CTWF
>> pbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4
>> zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=A%2BiFa
>> kDVdjPn0JJxUDlTDt1ej4iqnBivDktjwbcpFK4%3D&reserved=0
>> ---
>>  Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
>> b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
>> index 12a01f7a5744..12cd1b9f78d0 100644
>> --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
>> +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
>> @@ -62,6 +62,9 @@ properties:
>>      description: Should specify the GPIO for controlling the PCI bus device
>>        reset signal. It's not polarity aware and defaults to active-low reset
>>        sequence (L=reset state, H=operation state) (optional required).
>> +      Deprecated, use reset-gpios which respects the polarity expressed in
>> +      phandle argument.
>> +    deprecated: true
>>
>>    reset-gpio-active-high:
>>      description: If present then the reset sequence using the GPIO
> 
> Hi Krzysztof,
> This property also needs to be deprecated as Rob suggested in my previous patch :)
> https://lore.kernel.org/all/20260121164002.GA3427694-robh@kernel.org/

Heh, why that patchset isn't merged already?

Best regards,
Krzysztof

RE: [PATCH v2 1/2] dt-bindings: PCI: fsl,imx6q-pcie: Explicitly deprecate reset-gpio

[Sherry Sun]

> Subject: Re: [PATCH v2 1/2] dt-bindings: PCI: fsl,imx6q-pcie: Explicitly
> deprecate reset-gpio
> 
> On 13/03/2026 03:27, Sherry Sun wrote:
> >> Subject: [PATCH v2 1/2] dt-bindings: PCI: fsl,imx6q-pcie: Explicitly
> >> deprecate reset-gpio
> >>
> >> The binding references snps,dw-pcie-common.yaml which already
> >> deprecates "reset-gpio", however mentioning this property here lacks
> >> this mark thus code is confusing and suggests property is not deprecated.
> >>
> >> OTOH, the property cannot be removed from this schema, because it is
> >> an ABI implemented by Linux kernel in gpiolib-of.c in
> >> backwards-compatible map between compatibles, "reset-gpio" and "reset-
> gpio-active-high"
> >> properties.
> >>
> >> This creates code and binding which is not obvious to follow, so
> >> rewrite it and be more explicit about:
> >> 1. Deprecation of "reset-gpio",
> >> 2. Relation that "reset-gpio-active-high" is used only for that property
> >>    and not proper "reset-gpios".
> >>
> >> Signed-off-by: Krzysztof Kozlowski
> >> <krzysztof.kozlowski@oss.qualcomm.com>
> >>
> >> ---
> >>
> >> Cc: Sherry Sun <sherry.sun@nxp.com>
> >>
> >> Changes in v2:
> >> 1. Rewrite the commit completely after Sherry Sun comments - keep the
> >>    property, but add "not" clause to forbid usavge of
> >>    "reset-gpio-active-high" and "reset-gpios".
> >> 2. Because of above not adding Richard's ack.
> >>
> >> v1:
> >> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flor
> >>
> e.ke%2F&data=05%7C02%7Csherry.sun%40nxp.com%7C6967142eb77047384
> 81e08d
> >>
> e80d303e5%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6390898
> 4094660
> >>
> 3723%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwL
> jAuMDAw
> >>
> MCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C
> &sda
> >> ta=4JQjEBcOsTdGVZZxRf2ov1IkD4DizXpsfNhMBZQVnIs%3D&reserved=0
> >> rnel.org%2Fr%2F20260311154955.145120-3-
> >>
> krzysztof.kozlowski%40oss.qualcomm.com&data=05%7C02%7Csherry.sun%4
> >>
> 0nxp.com%7Cc630bed6bc4f46715b4408de80675002%7C686ea1d3bc2b4c6fa
> >>
> 92cd99c5c301635%7C0%7C0%7C639089378371805072%7CUnknown%7CTWF
> >>
> pbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4
> >>
> zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=A%2BiFa
> >> kDVdjPn0JJxUDlTDt1ej4iqnBivDktjwbcpFK4%3D&reserved=0
> >> ---
> >>  Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 8
> >> ++++++++
> >>  1 file changed, 8 insertions(+)
> >>
> >> diff --git
> >> a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> >> b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> >> index 12a01f7a5744..12cd1b9f78d0 100644
> >> --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> >> +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> >> @@ -62,6 +62,9 @@ properties:
> >>      description: Should specify the GPIO for controlling the PCI bus device
> >>        reset signal. It's not polarity aware and defaults to active-low reset
> >>        sequence (L=reset state, H=operation state) (optional required).
> >> +      Deprecated, use reset-gpios which respects the polarity expressed in
> >> +      phandle argument.
> >> +    deprecated: true
> >>
> >>    reset-gpio-active-high:
> >>      description: If present then the reset sequence using the GPIO
> >
> > Hi Krzysztof,
> > This property also needs to be deprecated as Rob suggested in my
> > previous patch :)
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore
> > .kernel.org%2Fall%2F20260121164002.GA3427694-
> robh%40kernel.org%2F&data
> >
> =05%7C02%7Csherry.sun%40nxp.com%7C6967142eb7704738481e08de80d3
> 03e5%7C6
> >
> 86ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C639089840946618268%7
> CUnknown
> > %7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIl
> AiOiJXaW4
> >
> zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=duSx4R
> MO9WjKX
> > 0aUSEM49tQpEpUEc%2B7aVATwASdFSGE%3D&reserved=0
> 
> Heh, why that patchset isn't merged already?

The V8 patch set is still under reviewing due to some pcie driver part changes ;)
https://lore.kernel.org/linux-devicetree/20260313020823.1592389-1-sherry.sun@nxp.com/

Best Regards
Sherry

Re: [PATCH v2 1/2] dt-bindings: PCI: fsl,imx6q-pcie: Explicitly deprecate reset-gpio

[Rob Herring (Arm)]

On Thu, 12 Mar 2026 19:43:45 +0100, Krzysztof Kozlowski wrote:
> The binding references snps,dw-pcie-common.yaml which already deprecates
> "reset-gpio", however mentioning this property here lacks this mark thus
> code is confusing and suggests property is not deprecated.
> 
> OTOH, the property cannot be removed from this schema, because it is an
> ABI implemented by Linux kernel in gpiolib-of.c in backwards-compatible
> map between compatibles, "reset-gpio" and "reset-gpio-active-high"
> properties.
> 
> This creates code and binding which is not obvious to follow, so rewrite
> it and be more explicit about:
> 1. Deprecation of "reset-gpio",
> 2. Relation that "reset-gpio-active-high" is used only for that property
>    and not proper "reset-gpios".
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> 
> ---
> 
> Cc: Sherry Sun <sherry.sun@nxp.com>
> 
> Changes in v2:
> 1. Rewrite the commit completely after Sherry Sun comments - keep the
>    property, but add "not" clause to forbid usavge of
>    "reset-gpio-active-high" and "reset-gpios".
> 2. Because of above not adding Richard's ack.
> 
> v1:
> https://lore.kernel.org/r/20260311154955.145120-3-krzysztof.kozlowski@oss.qualcomm.com
> ---
>  Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 

Acked-by: Rob Herring (Arm) <robh@kernel.org>