From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B072DF53D85 for ; Mon, 16 Mar 2026 17:55:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IFaLih1p4O+9IdcsECZEgKYyxNCnAtzC7vX9NMjLPJ0=; b=MD4/X9VDoEToVgysVxNVXsu9r3 mAjldVFxrajczHIk8uZEUji0qelLLsgDNMCiKPsQYWaxxDfOmzSeVCVAIP189nnnpoVnLqgmTF83X AYl+xIbgOAG9/DUen41pLEy/M2Lsc4C4UKY7JyjIBHOe4rgzyui7XTtjcyq2hVmJXuGO9i4F8TjUf o9OUdUxV1SdERYgKfzUtQlb+JJyfJeCYvX4ZDzqt85tt9y9/YGrSVhY2yp1FLwlbG/l4UsKoyxoY0 9Gglam2dY0RdQC199o9xrpWQPOEnB27DnHsTD3qjgbTbZN1Rm5DO9dmaKOasblReVaCzIobsW8quN pdTktBPg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1w2CAG-00000004dKu-1EWr; Mon, 16 Mar 2026 17:55:40 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1w2C9o-00000004cpr-0vN1 for linux-arm-kernel@bombadil.infradead.org; Mon, 16 Mar 2026 17:55:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:MIME-Version :References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=IFaLih1p4O+9IdcsECZEgKYyxNCnAtzC7vX9NMjLPJ0=; b=Sub114YOK8QcFpJkhtFSA2elIW +IZEHGMvCrCi69ZwKAZ62h7wVJgeWxfs6ym//kxwNB/bl1E1Wuofte01xrfDZ7pF/8m2rfIIB+31M 35JOIf2vzVfr5bez/3AweMdGnFPWOjeT8v8dFTEUA3DSx63jdPFJApkBfKnsXbwXUkcoFy6/58fAy sVGeCYdhQIjtQaD7Fs2hmsjbI6/2unPB5L5jR3Cv4vfN6GELGIewkBpng43MJY6xPXA/j8bk0/KmF dRHS57sHN+++wnUJ2an2TXSDuvwvKrnehSAbcDYArJ+f6oZ8VpPaZdXarx7Rdd0ffJGSSpvH09Wvo OVTnKl1A==; Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by desiato.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1w2C9k-00000007OVq-3XtF for linux-arm-kernel@lists.infradead.org; Mon, 16 Mar 2026 17:55:10 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 23A8344589; Mon, 16 Mar 2026 17:55:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 09705C2BC87; Mon, 16 Mar 2026 17:55:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773683704; bh=OmbUlU61vJq74z4PFbIuXavskMoKCq6TKw93G2ZPuD4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=j5DEc7ExC1XOH0f28aQPZjzgD/Aj4ce5a2yuw9jcA74HveyUKeMSk8tWLkq2F5LM4 r6Arv98GM9j6sW5Gfv7eR86Q4nV0RxMQlXewlAzTV9R5SFV7ZC3Z8767MD31S9H3dY h3NCTUt7ewnGl8lVJaz2qzIARrx4Zw63X316kedTgdGjf2+PicThdfyDRnjBkcen5D iSV7gDK42xPlDtTefYQ68gNMLfCCoh53snF3/ilHgkgi+qLD7t39G4QaLV12YuYe9b LiLiVYuLas2hhkPbN6gByHSr4381lMe7PxUZo5oJoKBAMf2stQhhvI1xqPKjX7ueS5 FVMx1nBGzvdAw== Received: from sofa.misterjones.org ([185.219.108.64] helo=valley-girl.lan) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1w2C9e-00000002XDx-12eA; Mon, 16 Mar 2026 17:55:02 +0000 From: Marc Zyngier To: kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org Cc: Joey Gouly , Suzuki K Poulose , Oliver Upton , Zenghui Yu , Fuad Tabba , Will Deacon , Quentin Perret Subject: [PATCH 13/17] KVM: arm64: Replace force_pte with a max_map_size attribute Date: Mon, 16 Mar 2026 17:54:46 +0000 Message-ID: <20260316175451.1866175-14-maz@kernel.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260316175451.1866175-1-maz@kernel.org> References: <20260316175451.1866175-1-maz@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, joey.gouly@arm.com, suzuki.poulose@arm.com, oupton@kernel.org, yuzenghui@huawei.com, tabba@google.com, will@kernel.org, qperret@google.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260316_175509_270121_2B26C457 X-CRM114-Status: GOOD ( 15.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org force_pte is annoyingly limited in what it expresses, and we'd be better off with a more generic primitive. Introduce max_map_size instead, which does the trick and can be moved into the vma_info structure. This firther allows it to reduce the scopes in which it is mutable. Signed-off-by: Marc Zyngier --- arch/arm64/kvm/mmu.c | 47 +++++++++++++++++++++++--------------------- 1 file changed, 25 insertions(+), 22 deletions(-) diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c index ccdc9398e4ce2..ac4bfcc33aeb1 100644 --- a/arch/arm64/kvm/mmu.c +++ b/arch/arm64/kvm/mmu.c @@ -1648,15 +1648,32 @@ struct kvm_s2_fault_desc { unsigned long hva; }; +struct kvm_s2_fault_vma_info { + unsigned long mmu_seq; + long vma_pagesize; + vm_flags_t vm_flags; + unsigned long max_map_size; + struct page *page; + kvm_pfn_t pfn; + gfn_t gfn; + bool mte_allowed; + bool is_vma_cacheable; + bool map_writable; +}; + static short kvm_s2_resolve_vma_size(const struct kvm_s2_fault_desc *s2fd, - struct vm_area_struct *vma, bool *force_pte) + struct kvm_s2_fault_vma_info *s2vi, + struct vm_area_struct *vma) { short vma_shift; - if (*force_pte) + if (memslot_is_logging(s2fd->memslot)) { + s2vi->max_map_size = PAGE_SIZE; vma_shift = PAGE_SHIFT; - else + } else { + s2vi->max_map_size = PUD_SIZE; vma_shift = get_vma_page_shift(vma, s2fd->hva); + } switch (vma_shift) { #ifndef __PAGETABLE_PMD_FOLDED @@ -1674,7 +1691,7 @@ static short kvm_s2_resolve_vma_size(const struct kvm_s2_fault_desc *s2fd, fallthrough; case CONT_PTE_SHIFT: vma_shift = PAGE_SHIFT; - *force_pte = true; + s2vi->max_map_size = PAGE_SIZE; fallthrough; case PAGE_SHIFT: break; @@ -1685,7 +1702,7 @@ static short kvm_s2_resolve_vma_size(const struct kvm_s2_fault_desc *s2fd, if (s2fd->nested) { unsigned long max_map_size; - max_map_size = *force_pte ? PAGE_SIZE : PUD_SIZE; + max_map_size = min(s2vi->max_map_size, PUD_SIZE); /* * If we're about to create a shadow stage 2 entry, then we @@ -1703,28 +1720,15 @@ static short kvm_s2_resolve_vma_size(const struct kvm_s2_fault_desc *s2fd, else if (max_map_size >= PAGE_SIZE && max_map_size < PMD_SIZE) max_map_size = PAGE_SIZE; - *force_pte = (max_map_size == PAGE_SIZE); + s2vi->max_map_size = max_map_size; vma_shift = min_t(short, vma_shift, __ffs(max_map_size)); } return vma_shift; } -struct kvm_s2_fault_vma_info { - unsigned long mmu_seq; - long vma_pagesize; - vm_flags_t vm_flags; - struct page *page; - kvm_pfn_t pfn; - gfn_t gfn; - bool mte_allowed; - bool is_vma_cacheable; - bool map_writable; -}; - struct kvm_s2_fault { bool s2_force_noncacheable; - bool force_pte; enum kvm_pgtable_prot prot; }; @@ -1748,7 +1752,7 @@ static int kvm_s2_fault_get_vma_info(const struct kvm_s2_fault_desc *s2fd, return -EFAULT; } - s2vi->vma_pagesize = BIT(kvm_s2_resolve_vma_size(s2fd, vma, &fault->force_pte)); + s2vi->vma_pagesize = BIT(kvm_s2_resolve_vma_size(s2fd, s2vi, vma)); /* * Both the canonical IPA and fault IPA must be aligned to the @@ -1933,7 +1937,7 @@ static int kvm_s2_fault_map(const struct kvm_s2_fault_desc *s2fd, * backed by a THP and thus use block mapping if possible. */ if (mapping_size == PAGE_SIZE && - !(fault->force_pte || fault->s2_force_noncacheable)) { + !(s2vi->max_map_size == PAGE_SIZE || fault->s2_force_noncacheable)) { if (perm_fault_granule > PAGE_SIZE) { mapping_size = perm_fault_granule; } else { @@ -1990,7 +1994,6 @@ static int user_mem_abort(const struct kvm_s2_fault_desc *s2fd) bool perm_fault = kvm_vcpu_trap_is_permission_fault(s2fd->vcpu); struct kvm_s2_fault_vma_info s2vi = {}; struct kvm_s2_fault fault = { - .force_pte = memslot_is_logging(s2fd->memslot), .prot = KVM_PGTABLE_PROT_R, }; void *memcache; -- 2.47.3