From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DB248103E198 for ; Wed, 18 Mar 2026 15:56:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8hJfNAyJkNUa+APSlrbAjV1w1m8rHhpRUB6zp9xiKrQ=; b=k36fX1tZXIlSCYZ6Ng31/CZVF2 0ZTxOdwqcOki/Es3z71W5+YbwRgBPZ2pzGs4+YroFj87iRG8PnYHpkDspUbjV2Pg1vIlfLbjdhbti bjQsVmD+QU/Ou4TXitFjlKODUcWdhLvTHKBNe9lwmU7QkhLnhbG9GEwVqPjXfj57fjUNzUYMIRyAf OQK9WMlRULG6whsmj6oQQWhFW3ppbHINrJuyhk9PzQnlZ4PWI1X8/krCPgoMA19N9Q2taVGZDwMhE OuxJCqaDyttNSBpRHVzOWX+tLqemWUnXSzg/bLSMYcKr3GAm6FLmFZOVUr0kZuBds5hkPYN1iqEIV 9j/508uQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1w2tFr-00000008pdN-2Azv; Wed, 18 Mar 2026 15:56:19 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1w2tFZ-00000008pJb-2v4N for linux-arm-kernel@lists.infradead.org; Wed, 18 Mar 2026 15:56:04 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3C41C2008; Wed, 18 Mar 2026 08:55:54 -0700 (PDT) Received: from e122027.arm.com (unknown [10.57.61.122]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 282033F73B; Wed, 18 Mar 2026 08:55:57 -0700 (PDT) From: Steven Price To: kvm@vger.kernel.org, kvmarm@lists.linux.dev Cc: Steven Price , Catalin Marinas , Marc Zyngier , Will Deacon , James Morse , Oliver Upton , Suzuki K Poulose , Zenghui Yu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Joey Gouly , Alexandru Elisei , Christoffer Dall , Fuad Tabba , linux-coco@lists.linux.dev, Ganapatrao Kulkarni , Gavin Shan , Shanker Donthineni , Alper Gun , "Aneesh Kumar K . V" , Emi Kisanuki , Vishal Annapurve Subject: [PATCH v13 26/48] arm64: RMI: Create the realm descriptor Date: Wed, 18 Mar 2026 15:53:50 +0000 Message-ID: <20260318155413.793430-27-steven.price@arm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260318155413.793430-1-steven.price@arm.com> References: <20260318155413.793430-1-steven.price@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260318_085602_982989_014A622B X-CRM114-Status: GOOD ( 15.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Creating a realm involves first creating a realm descriptor (RD). This involves passing the configuration information to the RMM. Do this as part of realm_ensure_created() so that the realm is created when it is first needed. Signed-off-by: Steven Price --- Changes since v12: * Since RMM page size is now equal to the host's page size various calculations are simplified. * Switch to using range based APIs to delegate/undelegate. * VMID handling is now handled entirely by the RMM. --- arch/arm64/kvm/rmi.c | 94 +++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 92 insertions(+), 2 deletions(-) diff --git a/arch/arm64/kvm/rmi.c b/arch/arm64/kvm/rmi.c index 38349c7b34f4..d5fee203824b 100644 --- a/arch/arm64/kvm/rmi.c +++ b/arch/arm64/kvm/rmi.c @@ -649,6 +649,83 @@ static void realm_unmap_shared_range(struct kvm *kvm, start, end); } +static int realm_create_rd(struct kvm *kvm) +{ + struct realm *realm = &kvm->arch.realm; + struct realm_params *params = realm->params; + void *rd = NULL; + phys_addr_t rd_phys, params_phys; + size_t pgd_size = kvm_pgtable_stage2_pgd_size(kvm->arch.mmu.vtcr); + int i, r; + + realm->ia_bits = VTCR_EL2_IPA(kvm->arch.mmu.vtcr); + + if (WARN_ON(realm->rd || !realm->params)) + return -EEXIST; + + rd = (void *)__get_free_page(GFP_KERNEL); + if (!rd) + return -ENOMEM; + + rd_phys = virt_to_phys(rd); + if (delegate_page(rd_phys)) { + r = -ENXIO; + goto free_rd; + } + + if (delegate_range(kvm->arch.mmu.pgd_phys, pgd_size)) { + r = -ENXIO; + goto out_undelegate_tables; + } + + params->s2sz = VTCR_EL2_IPA(kvm->arch.mmu.vtcr); + params->rtt_level_start = get_start_level(realm); + params->rtt_num_start = pgd_size / PAGE_SIZE; + params->rtt_base = kvm->arch.mmu.pgd_phys; + + if (kvm->arch.arm_pmu) { + params->pmu_num_ctrs = kvm->arch.nr_pmu_counters; + params->flags |= RMI_REALM_PARAM_FLAG_PMU; + } + + if (kvm_lpa2_is_enabled()) + params->flags |= RMI_REALM_PARAM_FLAG_LPA2; + + params_phys = virt_to_phys(params); + + if (rmi_realm_create(rd_phys, params_phys)) { + r = -ENXIO; + goto out_undelegate_tables; + } + + if (WARN_ON(rmi_rec_aux_count(rd_phys, &realm->num_aux))) { + WARN_ON(rmi_realm_destroy(rd_phys)); + r = -ENXIO; + goto out_undelegate_tables; + } + + realm->rd = rd; + WRITE_ONCE(realm->state, REALM_STATE_NEW); + /* The realm is up, free the parameters. */ + free_page((unsigned long)realm->params); + realm->params = NULL; + + return 0; + +out_undelegate_tables: + if (WARN_ON(undelegate_range(kvm->arch.mmu.pgd_phys, i))) { + /* Leak the pages if they cannot be returned */ + kvm->arch.mmu.pgt = NULL; + } + if (WARN_ON(undelegate_page(rd_phys))) { + /* Leak the page if it isn't returned */ + return r; + } +free_rd: + free_page((unsigned long)rd); + return r; +} + static void realm_unmap_private_range(struct kvm *kvm, unsigned long start, unsigned long end, @@ -893,8 +970,21 @@ static int realm_init_ipa_state(struct kvm *kvm, static int realm_ensure_created(struct kvm *kvm) { - /* Provided in later patch */ - return -ENXIO; + int ret; + + switch (kvm_realm_state(kvm)) { + case REALM_STATE_NONE: + break; + case REALM_STATE_NEW: + return 0; + case REALM_STATE_DEAD: + return -ENXIO; + default: + return -EBUSY; + } + + ret = realm_create_rd(kvm); + return ret; } static int set_ripas_of_protected_regions(struct kvm *kvm) -- 2.43.0