From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 10B62FC72AF for ; Sun, 22 Mar 2026 07:17:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xkJS7XHirsp0vEiCwEwBAUNV80Nd9FD+AW58LPoQNAI=; b=JBvdkoRieDrMLkmjTGl21FJRuj pClmhZm1+JFaLk3yBzLjAryvbcdD80UvffPjJTvKcsk3yu/U1BMfGOebXbS1lJlwosWiQTgNlmv2x Kuh+bw9VqIrgh9Xw1oL6cFq0oy7fmvukHSPTHtG7+X2yALLFawlZElvqlMmm6gvBjO8JvsT/tXsIR En/2ekvd2GDNROA+lOE5sMKsbUZ6t5Tl0veE1As0q+sASl2yxcCa+K4/y/BnPmcSkwxSg5pvo8AEe znPOii9grFUlsN4hZuO1xJWuT5Y0b23zR2vWVz2U/Fy9OBpNXyivlDJB2hsAgkqK+ocb742L2FcSP T2dae++g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1w4D3Q-0000000F98D-2rys; Sun, 22 Mar 2026 07:16:56 +0000 Received: from mgamail.intel.com ([192.198.163.8]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1w4D3N-0000000F97p-2WcH; Sun, 22 Mar 2026 07:16:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1774163814; x=1805699814; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=kwBSm/78IDtukhguYZn5xQ9aaT99mUU83kPFSMybg3s=; b=DMADZ+JJJouY/8tc75zqiZ4paetx7kiZYmMh0cUnMRLBKUeftByHb8ta tnAmukhqJYoMr5ANmWskv4zT9ngodQBG13t3tzaOmM5fKVxWPxixhHsTN chVVKlcCYF+a2TnbDCCrHxHXhULHvvMfpggzZVD4tPsEfUiFHT5swKtBt c3S7keIgdy+3HsVa6/0pUrwx41htK5aVCmlB8+qn8Gwwu4C5rYe1rc84q dXSel9L1Z//Tlrf+eooBvQRFyooyrFmnPNbtla6kAGP2ofMIsZKwSDTJD AG6kFTF1xfAPpnHQDcovscTsQxDi3rWiylwl1tgHa3zpWrLfkK6qkOL2S w==; X-CSE-ConnectionGUID: UdbJ1DBVTTGuIMhXlqn7vQ== X-CSE-MsgGUID: TthsNo2QTIK5VaE7kKeoVA== X-IronPort-AV: E=McAfee;i="6800,10657,11736"; a="92769967" X-IronPort-AV: E=Sophos;i="6.23,134,1770624000"; d="scan'208";a="92769967" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2026 00:16:49 -0700 X-CSE-ConnectionGUID: bvV48Al9Sd+6ASElmZwosw== X-CSE-MsgGUID: I85SOgUtQRW7YzRINARN3A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,134,1770624000"; d="scan'208";a="219411890" Received: from igk-lkp-server01.igk.intel.com (HELO 9958d990ccf2) ([10.211.93.152]) by fmviesa010.fm.intel.com with ESMTP; 22 Mar 2026 00:16:46 -0700 Received: from kbuild by 9958d990ccf2 with local (Exim 4.98.2) (envelope-from ) id 1w4D3D-000000006Jp-2F9v; Sun, 22 Mar 2026 07:16:43 +0000 Date: Sun, 22 Mar 2026 08:16:39 +0100 From: kernel test robot To: =?utf-8?B?7KCE66+87Iud?= , "kbusch@kernel.org" , "axboe@kernel.dk" Cc: oe-kbuild-all@lists.linux.dev, "sven@kernel.org" , "j@jannau.net" , "neal@gompa.dev" , "hch@lst.de" , "sagi@grimberg.me" , "justin.tee@broadcom.com" , "nareshgottumukkala83@gmail.com" , "paul.ely@broadcom.com" , "kch@nvidia.com" , "linux-arm-kernel@lists.infradead.org" , "linux-nvme@lists.infradead.org" , "asahi@lists.linux.dev" , "linux-kernel@vger.kernel.org" , =?utf-8?B?7KCE66+87Iud?= Subject: Re: [PATCH] nvme: Move nvme_setup_cmd before hot_pathing Message-ID: <202603220813.hgb3EFi2-lkp@intel.com> References: <20260320052101epcms2p42ae135da60b36685e9b7fca6849b57a6@epcms2p4> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260320052101epcms2p42ae135da60b36685e9b7fca6849b57a6@epcms2p4> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260322_001653_680111_46361ADC X-CRM114-Status: GOOD ( 10.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi 전민식, kernel test robot noticed the following build warnings: [auto build test WARNING on axboe/for-next] [also build test WARNING on linux-nvme/for-next linus/master v6.16-rc1 next-20260320] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/nvme-Move-nvme_setup_cmd-before-hot_pathing/20260322-080947 base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux.git for-next patch link: https://lore.kernel.org/r/20260320052101epcms2p42ae135da60b36685e9b7fca6849b57a6%40epcms2p4 patch subject: [PATCH] nvme: Move nvme_setup_cmd before hot_pathing config: x86_64-rhel-9.4 (https://download.01.org/0day-ci/archive/20260322/202603220813.hgb3EFi2-lkp@intel.com/config) compiler: gcc-14 (Debian 14.2.0-19) 14.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260322/202603220813.hgb3EFi2-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202603220813.hgb3EFi2-lkp@intel.com/ All warnings (new ones prefixed by >>): drivers/nvme/host/rdma.c: In function 'nvme_rdma_queue_rq': >> drivers/nvme/host/rdma.c:2067:1: warning: label 'unmap_qe' defined but not used [-Wunused-label] 2067 | unmap_qe: | ^~~~~~~~ vim +/unmap_qe +2067 drivers/nvme/host/rdma.c 71102307196028 Christoph Hellwig 2016-07-06 1991 fc17b6534eb839 Christoph Hellwig 2017-06-03 1992 static blk_status_t nvme_rdma_queue_rq(struct blk_mq_hw_ctx *hctx, 71102307196028 Christoph Hellwig 2016-07-06 1993 const struct blk_mq_queue_data *bd) 71102307196028 Christoph Hellwig 2016-07-06 1994 { 71102307196028 Christoph Hellwig 2016-07-06 1995 struct nvme_ns *ns = hctx->queue->queuedata; 71102307196028 Christoph Hellwig 2016-07-06 1996 struct nvme_rdma_queue *queue = hctx->driver_data; 71102307196028 Christoph Hellwig 2016-07-06 1997 struct request *rq = bd->rq; 71102307196028 Christoph Hellwig 2016-07-06 1998 struct nvme_rdma_request *req = blk_mq_rq_to_pdu(rq); 71102307196028 Christoph Hellwig 2016-07-06 1999 struct nvme_rdma_qe *sqe = &req->sqe; f4b9e6c90c5725 Keith Busch 2021-03-17 2000 struct nvme_command *c = nvme_req(rq)->cmd; 71102307196028 Christoph Hellwig 2016-07-06 2001 struct ib_device *dev; 3bc32bb1186cca Christoph Hellwig 2018-06-11 2002 bool queue_ready = test_bit(NVME_RDMA_Q_LIVE, &queue->flags); fc17b6534eb839 Christoph Hellwig 2017-06-03 2003 blk_status_t ret; fc17b6534eb839 Christoph Hellwig 2017-06-03 2004 int err; 71102307196028 Christoph Hellwig 2016-07-06 2005 71102307196028 Christoph Hellwig 2016-07-06 2006 WARN_ON_ONCE(rq->tag < 0); 71102307196028 Christoph Hellwig 2016-07-06 2007 ae1c609d185960 전민식 2026-03-20 2008 ret = nvme_setup_cmd(ns, rq); ae1c609d185960 전민식 2026-03-20 2009 if (ret) ae1c609d185960 전민식 2026-03-20 2010 return ret; ae1c609d185960 전민식 2026-03-20 2011 a97157440e1e69 Andy Chiu 2021-04-26 2012 if (!nvme_check_ready(&queue->ctrl->ctrl, rq, queue_ready)) a97157440e1e69 Andy Chiu 2021-04-26 2013 return nvme_fail_nonready_command(&queue->ctrl->ctrl, rq); 553cd9ef82edd8 Christoph Hellwig 2016-11-02 2014 71102307196028 Christoph Hellwig 2016-07-06 2015 dev = queue->device->dev; 62f99b62e5e3b8 Max Gurtovoy 2019-06-06 2016 62f99b62e5e3b8 Max Gurtovoy 2019-06-06 2017 req->sqe.dma = ib_dma_map_single(dev, req->sqe.data, 62f99b62e5e3b8 Max Gurtovoy 2019-06-06 2018 sizeof(struct nvme_command), 62f99b62e5e3b8 Max Gurtovoy 2019-06-06 2019 DMA_TO_DEVICE); 62f99b62e5e3b8 Max Gurtovoy 2019-06-06 2020 err = ib_dma_mapping_error(dev, req->sqe.dma); 62f99b62e5e3b8 Max Gurtovoy 2019-06-06 2021 if (unlikely(err)) 62f99b62e5e3b8 Max Gurtovoy 2019-06-06 2022 return BLK_STS_RESOURCE; 62f99b62e5e3b8 Max Gurtovoy 2019-06-06 2023 71102307196028 Christoph Hellwig 2016-07-06 2024 ib_dma_sync_single_for_cpu(dev, sqe->dma, 71102307196028 Christoph Hellwig 2016-07-06 2025 sizeof(struct nvme_command), DMA_TO_DEVICE); 71102307196028 Christoph Hellwig 2016-07-06 2026 6887fc6495f2df Sagi Grimberg 2022-10-03 2027 nvme_start_request(rq); 71102307196028 Christoph Hellwig 2016-07-06 2028 5ec5d3bddc6b91 Max Gurtovoy 2020-05-19 2029 if (IS_ENABLED(CONFIG_BLK_DEV_INTEGRITY) && 5ec5d3bddc6b91 Max Gurtovoy 2020-05-19 2030 queue->pi_support && 5ec5d3bddc6b91 Max Gurtovoy 2020-05-19 2031 (c->common.opcode == nvme_cmd_write || 5ec5d3bddc6b91 Max Gurtovoy 2020-05-19 2032 c->common.opcode == nvme_cmd_read) && 0372dd4e361717 Daniel Wagner 2023-12-18 2033 nvme_ns_has_pi(ns->head)) 5ec5d3bddc6b91 Max Gurtovoy 2020-05-19 2034 req->use_sig_mr = true; 5ec5d3bddc6b91 Max Gurtovoy 2020-05-19 2035 else 5ec5d3bddc6b91 Max Gurtovoy 2020-05-19 2036 req->use_sig_mr = false; 5ec5d3bddc6b91 Max Gurtovoy 2020-05-19 2037 fc17b6534eb839 Christoph Hellwig 2017-06-03 2038 err = nvme_rdma_map_data(queue, rq, c); a7b7c7a105a528 Max Gurtovoy 2017-08-14 2039 if (unlikely(err < 0)) { 71102307196028 Christoph Hellwig 2016-07-06 2040 dev_err(queue->ctrl->ctrl.device, fc17b6534eb839 Christoph Hellwig 2017-06-03 2041 "Failed to map data (%d)\n", err); 71102307196028 Christoph Hellwig 2016-07-06 2042 goto err; 71102307196028 Christoph Hellwig 2016-07-06 2043 } 71102307196028 Christoph Hellwig 2016-07-06 2044 b4b591c87f2b0f Sagi Grimberg 2017-11-23 2045 sqe->cqe.done = nvme_rdma_send_done; b4b591c87f2b0f Sagi Grimberg 2017-11-23 2046 71102307196028 Christoph Hellwig 2016-07-06 2047 ib_dma_sync_single_for_device(dev, sqe->dma, 71102307196028 Christoph Hellwig 2016-07-06 2048 sizeof(struct nvme_command), DMA_TO_DEVICE); 71102307196028 Christoph Hellwig 2016-07-06 2049 fc17b6534eb839 Christoph Hellwig 2017-06-03 2050 err = nvme_rdma_post_send(queue, sqe, req->sge, req->num_sge, f41725bbe16b07 Israel Rukshin 2017-11-26 2051 req->mr ? &req->reg_wr.wr : NULL); 16686f3a6c3cd6 Max Gurtovoy 2019-10-13 2052 if (unlikely(err)) 16686f3a6c3cd6 Max Gurtovoy 2019-10-13 2053 goto err_unmap; 71102307196028 Christoph Hellwig 2016-07-06 2054 fc17b6534eb839 Christoph Hellwig 2017-06-03 2055 return BLK_STS_OK; 62f99b62e5e3b8 Max Gurtovoy 2019-06-06 2056 16686f3a6c3cd6 Max Gurtovoy 2019-10-13 2057 err_unmap: 16686f3a6c3cd6 Max Gurtovoy 2019-10-13 2058 nvme_rdma_unmap_data(queue, rq); 71102307196028 Christoph Hellwig 2016-07-06 2059 err: 62eca39722fd99 Chao Leng 2021-02-01 2060 if (err == -EIO) 62eca39722fd99 Chao Leng 2021-02-01 2061 ret = nvme_host_path_error(rq); 62eca39722fd99 Chao Leng 2021-02-01 2062 else if (err == -ENOMEM || err == -EAGAIN) 62f99b62e5e3b8 Max Gurtovoy 2019-06-06 2063 ret = BLK_STS_RESOURCE; 62f99b62e5e3b8 Max Gurtovoy 2019-06-06 2064 else 62f99b62e5e3b8 Max Gurtovoy 2019-06-06 2065 ret = BLK_STS_IOERR; 16686f3a6c3cd6 Max Gurtovoy 2019-10-13 2066 nvme_cleanup_cmd(rq); 62f99b62e5e3b8 Max Gurtovoy 2019-06-06 @2067 unmap_qe: 62f99b62e5e3b8 Max Gurtovoy 2019-06-06 2068 ib_dma_unmap_single(dev, req->sqe.dma, sizeof(struct nvme_command), 62f99b62e5e3b8 Max Gurtovoy 2019-06-06 2069 DMA_TO_DEVICE); 62f99b62e5e3b8 Max Gurtovoy 2019-06-06 2070 return ret; 71102307196028 Christoph Hellwig 2016-07-06 2071 } 71102307196028 Christoph Hellwig 2016-07-06 2072 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki