From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 120D2F54AD9 for ; Tue, 24 Mar 2026 16:03:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MC7m65enPeoK56w15mZU/jnX37Exa8SW0qeHJO7INHM=; b=AQP+fOuqlOcArkI+fAH7jrWWoM 472hLgZr8lMq65sCglfPJCaYAiZs0IopfRs2EoySmmNZW9+lBA8b7cI9ewt0ZgYfRm6kTefUkvJsk k/7S0eQsPNAjoJzzJLk9zg7TNo7IhA2bw5tpXHjY6QmvdgYhUFLmR7RSh9IZFwIea1a2Ya2UCKR4a s7xMzojobqB0H4vcu0mCUdV7tCEKONzSfCjjKBi4/UkmAZZyI31NtfzyO8JfZGCapgJ7csjpOp5Ob if2WGG5HwuGTTCfF0ApOEDDW2TNOJ2M74PcA6vTlxeinCeNPgoam66UyFXxTZmquSK42Ndh6JlGAH RnPeJmyA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1w54Dv-00000001oW3-39D7; Tue, 24 Mar 2026 16:03:19 +0000 Received: from sender4-pp-f112.zoho.com ([136.143.188.112]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1w54De-00000001oJI-3tHJ; Tue, 24 Mar 2026 16:03:10 +0000 ARC-Seal: i=1; a=rsa-sha256; t=1774368151; cv=none; d=zohomail.com; s=zohoarc; b=UQQkzW8hNoLun6nyBbgWt9ISGKM1w/1+pBxEoda6CTfmLl/TJbsptfHD9E/u18F48q41hzZEBXzj/4G6qn8GsUox0IE6Pcolqq7Na+8UPad2AvHUAFNGCBUQiMFU6lnnMOsuLp3/5ptcU6ZuVPkbohXDYcj/WB9i/ZK/UkohTW4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774368151; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=MC7m65enPeoK56w15mZU/jnX37Exa8SW0qeHJO7INHM=; b=hVMKmC3mIeZH5KCnvTcz3a+PG9s/9HhLLXzZplsax8d7RmvqwBJNlFYR1ewt5eTiOTCqbX7vY/63+PoGcCtv/8r/UPFiZGfYhAQkdgG3u1FVa/eyCzttfqlTFiMGjakFB0/caOW0/4kNsjGDxF1cnQyxoBvFO9BtD3cZRKyYZ1U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1774368151; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=MC7m65enPeoK56w15mZU/jnX37Exa8SW0qeHJO7INHM=; b=bL8HYVxSbY+4CG4VhaT7Te2g+WpUHw7repMdPHmkh6qV9HOhfclGl8xWklo7D2HC KHUflc9abp9vWPkSmGk4FEpugS8vQDhEdGxweRoJDjcVqIZ6x6E2P7xBuu2ojIVMbGI PCv9jItORtnVulASKOmsvbeizzTSimsghjzNp7ms= Received: by mx.zohomail.com with SMTPS id 177436815050185.95818000717009; Tue, 24 Mar 2026 09:02:30 -0700 (PDT) From: Nicolas Frattaroli Date: Tue, 24 Mar 2026 17:01:11 +0100 Subject: [PATCH v11 07/22] drm/display: hdmi-state-helper: Try subsampling in mode_valid MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260324-color-format-v11-7-605559af4fb4@collabora.com> References: <20260324-color-format-v11-0-605559af4fb4@collabora.com> In-Reply-To: <20260324-color-format-v11-0-605559af4fb4@collabora.com> To: Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Sandy Huang , =?utf-8?q?Heiko_St=C3=BCbner?= , Andy Yan , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , Dmitry Baryshkov , Sascha Hauer , Rob Herring , Jonathan Corbet , Shuah Khan Cc: kernel@collabora.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-doc@vger.kernel.org, Nicolas Frattaroli , Dmitry Baryshkov X-Mailer: b4 0.15.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260324_090303_089358_D9E49D7A X-CRM114-Status: GOOD ( 13.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org drm_hdmi_connector_mode_valid assumes modes are only valid if they work with RGB. The reality is more complex however: YCbCr 4:2:0 chroma-subsampled modes only require half the pixel clock that the same mode would require in RGB. This leads to drm_hdmi_connector_mode_valid rejecting perfectly valid 420-only or 420-also modes. Fix this by checking whether the mode is 420-capable first. If so, then proceed by checking it with DRM_OUTPUT_COLOR_FORMAT_YCBCR420 so long as the connector has legalized 420, otherwise error out. If the mode is not 420-capable, check with RGB as was previously always the case. Fixes: 47368ab437fd ("drm/display: hdmi: add generic mode_valid helper") Reviewed-by: Maxime Ripard Reviewed-by: Dmitry Baryshkov Signed-off-by: Nicolas Frattaroli --- drivers/gpu/drm/display/drm_hdmi_state_helper.c | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/display/drm_hdmi_state_helper.c b/drivers/gpu/drm/display/drm_hdmi_state_helper.c index 954f8b2973fc..5cc30da30989 100644 --- a/drivers/gpu/drm/display/drm_hdmi_state_helper.c +++ b/drivers/gpu/drm/display/drm_hdmi_state_helper.c @@ -942,8 +942,21 @@ drm_hdmi_connector_mode_valid(struct drm_connector *connector, const struct drm_display_mode *mode) { unsigned long long clock; + enum drm_output_color_format fmt; + + if (drm_mode_is_420_only(&connector->display_info, mode)) { + if (connector->ycbcr_420_allowed) + fmt = DRM_OUTPUT_COLOR_FORMAT_YCBCR420; + else + return MODE_NO_420; + } else if (drm_mode_is_420_also(&connector->display_info, mode) && + connector->ycbcr_420_allowed) { + fmt = DRM_OUTPUT_COLOR_FORMAT_YCBCR420; + } else { + fmt = DRM_OUTPUT_COLOR_FORMAT_RGB444; + } - clock = drm_hdmi_compute_mode_clock(mode, 8, DRM_OUTPUT_COLOR_FORMAT_RGB444); + clock = drm_hdmi_compute_mode_clock(mode, 8, fmt); if (!clock) return MODE_ERROR; -- 2.53.0