From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 101EF106F2EA for ; Thu, 26 Mar 2026 07:58:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=hJidR7QlZb7c5WIdyj3iesak/Jfa6pt2GqscpVScNO0=; b=NW9Iq1LJGlxfGS EBEnXcWrgU0CAx/IqkqOJEn6VQ4EVBnT2CBxFPKP/rYwVH0RmTAtRncvk/+6aPENOp6s4Mny2S0E6 9Fdmt3h6bqVkz6c3GOhhZvzCCOPVENghlWvzhAYm95wjY2EuuHkRABF+wKPAb15VUdZ44Xk3CtIoO ViQjDdnrhSc5ojqNxK8l2zpUAp1VkIRWdIs98N7FzhJ3s1LuKZG8PYCvPDoLsCeDgX+B2wzcn6Dny 7fCpQBpiN2O2bRiUCOwYk2nw5ADucU88yKV+QRsKW9sASqclcI097/W69Z+fjQTj1N9dT464AeUa1 EkbSSw0JvqHyJwWZiLNg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1w5fc4-00000004yTX-0OQq; Thu, 26 Mar 2026 07:58:44 +0000 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1w5fc1-00000004ySP-2NJp for linux-arm-kernel@lists.infradead.org; Thu, 26 Mar 2026 07:58:42 +0000 Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-43b4f48c47cso458302f8f.0 for ; Thu, 26 Mar 2026 00:58:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1774511919; x=1775116719; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=hJidR7QlZb7c5WIdyj3iesak/Jfa6pt2GqscpVScNO0=; b=egh2YDgdpkODhKY3puBoNIZUC/hCmJBfGHtUTa/4qgcliLhVCpvsLISCvSy6CqoO9i H5OgVK4vA19wBtMrnh5j5nm2035XJFcPHKj04zgQCg+o8GdmnQ/nN9TFkGcFJeGpvMQN ulu31aBqiAp8iIt5WgwKWEKdJzYqIhHsBimLR+ZsF+U5zbZA6hAXfvtqrNcjQyrp7sfq rX5dEoLxOlVrGDEXXn70AuCufEVmrTBtsy9dUvr0/MpE4dupv4ZSmrQnurNJ+EiSGkSP +Cs8BgR4F3NeTHcTh9UkM3CPRtdbzeH8B7eV2o65e3zeR1Au9qCJny7TTxbmDyzJ1o5l t3gA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774511919; x=1775116719; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hJidR7QlZb7c5WIdyj3iesak/Jfa6pt2GqscpVScNO0=; b=LZUNi+U0sQLuQPWjuw4fW535Tuuxi0kXu5pR7kYAEZjFEDLCultVukI4wqiTAtDVgA 7rTIcYMJ8FhUfcChmmx601xFPcD0THIGqTyUsYpkyUBTT04GYI8JYtaa0LpRI46kmOBV X98nId2H2C9H+AcDegoM9FzrkpCBdkIEysZlaNlPVh1E14LvPX7Nnj/YDQtNnogdqXZ/ YyDDf7+NIosuG1eMD0+VOMmc9hGlquW3tgvmlCIG6jOfaa8GvMv4PQkjbZxRfKUwh66l 37xPQoDb5V2vZOKqdSZBxRiBe39hKEPV2hd62IJVOOaDdg/IEc1+ZNHUtbzmKZjwL9DW 4/bg== X-Forwarded-Encrypted: i=1; AJvYcCVydK5Aqkj6vToIidFsUE4AgLHtCAtRweXnd4UvV8lDonYyhN08e6XWYoj1vAtTnWZd7ubbTfMMlFATqaY1Q6d0@lists.infradead.org X-Gm-Message-State: AOJu0YzNaOrEsEcB0befvuPsgMacG94TGbj5rkDeRHrFN+tx6rdvBA3N HPeSVfkVqBQb8vSs2YawWjyjEFlIzwmeBp+CvTHZvKgUYcgCuWaAblRl/ChXNU0TV8tKuNPxXau 9renv X-Gm-Gg: ATEYQzy1kDPaAlWZiJqeYCB8X/SM361nJSAUsFNXZHgtDxEJQW1eMhEZWd/u75WDdS7 Y+slR3OQAXSkHKj12o29RP1+Kihu4ay6sNGYObG+w7mFzMNMyl+Xev73m216Po42RwoB8Zkwcjo EEmNh28ScWdyTb5qFVZnWton35dvf77wmaJMF81n4G74Z9MgpGOC+Tmhj7ADzdWIPwwoejKjcoD 5SFWidNiUd2Dkz4I2+VvCRh7x3LjsaZZdNND14JiXYHHGtZhn8vzWlavZzW3+OfAyzGQdwpsy5i G7iRpBj0Ke8U5jROMttE5LePt0eS9JLCX3yCdj6qemuE+Xmpf4mEAoMnfXiDRhZrYvylD2dgO3o wtekJj6rH8MjTuNcgkiWXCJFQOBSCnTHL7pYnrJSXkY6Og81GFrDNMe1cJkxbSPtEVedP9aOdtd qpAPHsIb9SFaS84HfKx+tDvM+xluoR X-Received: by 2002:a05:6000:438a:b0:43b:564d:c123 with SMTP id ffacd0b85a97d-43b8898d57amr9770384f8f.3.1774511918517; Thu, 26 Mar 2026 00:58:38 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b919e7111sm5918551f8f.37.2026.03.26.00.58.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2026 00:58:37 -0700 (PDT) Date: Thu, 26 Mar 2026 10:58:27 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Chen-Yu Tsai , Stephen Boyd , Matthias Brugger , AngeloGioacchino Del Regno , Frank Binns , Matt Coster , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, Icenowy Zheng , Chen-Yu Tsai , David Airlie , Simona Vetter , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/5] clk: mediatek: Add mt8173-mfgtop driver Message-ID: <202603261444.jANdMbNC-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260325071951.544031-3-wenst@chromium.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260326_005841_628984_5F81C1E7 X-CRM114-Status: UNSURE ( 9.56 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Chen-Yu, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Chen-Yu-Tsai/dt-bindings-clock-mediatek-Add-mt8173-mfgtop/20260325-202618 base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next patch link: https://lore.kernel.org/r/20260325071951.544031-3-wenst%40chromium.org patch subject: [PATCH v2 2/5] clk: mediatek: Add mt8173-mfgtop driver config: csky-randconfig-r073-20260326 (https://download.01.org/0day-ci/archive/20260326/202603261444.jANdMbNC-lkp@intel.com/config) compiler: csky-linux-gcc (GCC) 11.5.0 smatch: v0.5.0-9004-gb810ac53 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202603261444.jANdMbNC-lkp@intel.com/ smatch warnings: drivers/clk/mediatek/clk-mt8173-mfgtop.c:163 clk_mt8173_mfgtop_probe() warn: missing error code 'ret' vim +/ret +163 drivers/clk/mediatek/clk-mt8173-mfgtop.c edc2074329e271 Chen-Yu Tsai 2026-03-25 153 ret = mtk_clk_register_gates(dev, node, mfg_clks, ARRAY_SIZE(mfg_clks), edc2074329e271 Chen-Yu Tsai 2026-03-25 154 data->clk_data); edc2074329e271 Chen-Yu Tsai 2026-03-25 155 if (ret) { edc2074329e271 Chen-Yu Tsai 2026-03-25 156 dev_err_probe(dev, ret, "Failed to register clock gates\n"); edc2074329e271 Chen-Yu Tsai 2026-03-25 157 goto put_pm_runtime; edc2074329e271 Chen-Yu Tsai 2026-03-25 158 } edc2074329e271 Chen-Yu Tsai 2026-03-25 159 edc2074329e271 Chen-Yu Tsai 2026-03-25 160 data->clk_26m = clk_hw_get_clk(data->clk_data->hws[CLK_MFG_26M], "26m"); edc2074329e271 Chen-Yu Tsai 2026-03-25 161 if (IS_ERR(data->clk_26m)) { edc2074329e271 Chen-Yu Tsai 2026-03-25 162 dev_err_probe(dev, PTR_ERR(data->clk_26m), "Failed to get 26 MHz clock\n"); edc2074329e271 Chen-Yu Tsai 2026-03-25 @163 goto unregister_clks; ret = dev_err_probe() or ret = PTR_ERR(data->clk_26m)? edc2074329e271 Chen-Yu Tsai 2026-03-25 164 } edc2074329e271 Chen-Yu Tsai 2026-03-25 165 edc2074329e271 Chen-Yu Tsai 2026-03-25 166 ret = of_clk_add_hw_provider(node, of_clk_hw_onecell_get, data->clk_data); edc2074329e271 Chen-Yu Tsai 2026-03-25 167 if (ret) { edc2074329e271 Chen-Yu Tsai 2026-03-25 168 dev_err_probe(dev, ret, "Failed to add clk OF provider\n"); edc2074329e271 Chen-Yu Tsai 2026-03-25 169 goto put_26m_clk; edc2074329e271 Chen-Yu Tsai 2026-03-25 170 } edc2074329e271 Chen-Yu Tsai 2026-03-25 171 edc2074329e271 Chen-Yu Tsai 2026-03-25 172 data->genpd.name = "mfg-top"; edc2074329e271 Chen-Yu Tsai 2026-03-25 173 data->genpd.power_on = clk_mt8173_mfgtop_power_on; edc2074329e271 Chen-Yu Tsai 2026-03-25 174 data->genpd.power_off = clk_mt8173_mfgtop_power_off; edc2074329e271 Chen-Yu Tsai 2026-03-25 175 ret = pm_genpd_init(&data->genpd, NULL, true); edc2074329e271 Chen-Yu Tsai 2026-03-25 176 if (ret) { edc2074329e271 Chen-Yu Tsai 2026-03-25 177 dev_err_probe(dev, ret, "Failed to add power domain\n"); edc2074329e271 Chen-Yu Tsai 2026-03-25 178 goto del_clk_provider; edc2074329e271 Chen-Yu Tsai 2026-03-25 179 } edc2074329e271 Chen-Yu Tsai 2026-03-25 180 edc2074329e271 Chen-Yu Tsai 2026-03-25 181 ret = of_genpd_add_provider_simple(node, &data->genpd); edc2074329e271 Chen-Yu Tsai 2026-03-25 182 if (ret) { edc2074329e271 Chen-Yu Tsai 2026-03-25 183 dev_err_probe(dev, ret, "Failed to add power domain OF provider\n"); edc2074329e271 Chen-Yu Tsai 2026-03-25 184 goto remove_pd; edc2074329e271 Chen-Yu Tsai 2026-03-25 185 } edc2074329e271 Chen-Yu Tsai 2026-03-25 186 edc2074329e271 Chen-Yu Tsai 2026-03-25 187 ret = of_genpd_add_subdomain(&data->parent_pd, &data->child_pd); edc2074329e271 Chen-Yu Tsai 2026-03-25 188 if (ret) { edc2074329e271 Chen-Yu Tsai 2026-03-25 189 dev_err_probe(dev, ret, "Failed to link PM domains\n"); edc2074329e271 Chen-Yu Tsai 2026-03-25 190 goto del_pd_provider; edc2074329e271 Chen-Yu Tsai 2026-03-25 191 } edc2074329e271 Chen-Yu Tsai 2026-03-25 192 edc2074329e271 Chen-Yu Tsai 2026-03-25 193 pm_runtime_put(dev); edc2074329e271 Chen-Yu Tsai 2026-03-25 194 return 0; edc2074329e271 Chen-Yu Tsai 2026-03-25 195 edc2074329e271 Chen-Yu Tsai 2026-03-25 196 del_pd_provider: edc2074329e271 Chen-Yu Tsai 2026-03-25 197 of_genpd_del_provider(node); edc2074329e271 Chen-Yu Tsai 2026-03-25 198 remove_pd: edc2074329e271 Chen-Yu Tsai 2026-03-25 199 pm_genpd_remove(&data->genpd); edc2074329e271 Chen-Yu Tsai 2026-03-25 200 del_clk_provider: edc2074329e271 Chen-Yu Tsai 2026-03-25 201 of_clk_del_provider(node); edc2074329e271 Chen-Yu Tsai 2026-03-25 202 put_26m_clk: edc2074329e271 Chen-Yu Tsai 2026-03-25 203 clk_put(data->clk_26m); edc2074329e271 Chen-Yu Tsai 2026-03-25 204 unregister_clks: edc2074329e271 Chen-Yu Tsai 2026-03-25 205 mtk_clk_unregister_gates(mfg_clks, ARRAY_SIZE(mfg_clks), data->clk_data); edc2074329e271 Chen-Yu Tsai 2026-03-25 206 put_pm_runtime: edc2074329e271 Chen-Yu Tsai 2026-03-25 207 pm_runtime_put(dev); edc2074329e271 Chen-Yu Tsai 2026-03-25 208 put_of_node: edc2074329e271 Chen-Yu Tsai 2026-03-25 209 of_node_put(data->parent_pd.np); edc2074329e271 Chen-Yu Tsai 2026-03-25 210 return ret; edc2074329e271 Chen-Yu Tsai 2026-03-25 211 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki